Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend ConstantRollupData to include global variables #826

Closed
Tracked by #824
LHerskind opened this issue Jun 13, 2023 · 0 comments · Fixed by #882
Closed
Tracked by #824

feat: Extend ConstantRollupData to include global variables #826

LHerskind opened this issue Jun 13, 2023 · 0 comments · Fixed by #882
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jun 13, 2023

Part of #824

The ConstantRollupData which is used in Base and Merge rollup circuits should be updated to include:

  • block.timestamp
  • block.number
  • chainid
  • version

To handle #705, the kernel should use its chainid as a public input, allowing us to have the Base rollup circuit check that both kernels have same chainid as the constant values.

The Merge rollup is checking that constants from both left and right child is the same, and forwarding the constants already, so no changes should be required there.

Small illustration below (showing only chainid but same for the other values).

Image

The root rollup requires minor changes to include the added values as part of the public inputs hash such that they can be anchored in data provided by the state transition contract.

Note that the state transition contract needs to update to include the extra values in public input computation. Note that the values in the L2 block should be constrained on L1 but that this should be done in separate issues, to not bloat this PR needlessly:

@LHerskind LHerskind added this to A3 Jun 13, 2023
@LHerskind LHerskind converted this from a draft issue Jun 13, 2023
@LHerskind LHerskind self-assigned this Jun 15, 2023
@LHerskind LHerskind linked a pull request Jun 15, 2023 that will close this issue
6 tasks
@LHerskind LHerskind linked a pull request Jun 19, 2023 that will close this issue
12 tasks
@LHerskind LHerskind removed a link to a pull request Jun 19, 2023
6 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jun 22, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant