Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable attestation and epoch proof metrics after #9226 #9227

Open
ludamad opened this issue Oct 13, 2024 · 1 comment
Open

Reenable attestation and epoch proof metrics after #9226 #9227

ludamad opened this issue Oct 13, 2024 · 1 comment
Assignees
@ludamad @Maddiaa0

Comments

@ludamad
Copy link
Collaborator

ludamad commented Oct 13, 2024

See #9226 for reasoning
@ludamad ludamad mentioned this issue Oct 13, 2024
Merged
@ludamad
Copy link
Collaborator Author

ludamad commented Oct 13, 2024

There were duplicate labels here apparently blocking all metrics

ludamad pushed a commit that referenced this issue Oct 13, 2024
@just-mitch
fix: prometheus metrics (#9226)
9445a4f 
Prometheus/otel demand that these metric names be unique, so when we're
generic over the different pools, we break uniqueness, and get zero
metrics.

Temporarily turn the attestation and epoch proof metrics to no-ops to
fix metrics.

Proof:
<img width="779" alt="Screenshot 2024-10-13 at 14 56 51"
src="https://github.com/user-attachments/assets/01a53d8a-e430-4d68-9df5-c5fca128ef56">

Disabled until
#9227
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludamad ludamad

@Maddiaa0 Maddiaa0

Labels
None yet
Projects
A3
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ludamad @Maddiaa0