Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find app tagged logs #9380

Closed
Tracked by #9119
nventuro opened this issue Oct 23, 2024 · 0 comments · Fixed by #9595
Closed
Tracked by #9119

Find app tagged logs #9380

nventuro opened this issue Oct 23, 2024 · 0 comments · Fixed by #9595
Assignees
@Thunkar
Labels
C-pxe Component: PXE (Private eXecution Envrionment) team-fairies Nico's team

Comments

@nventuro
Copy link
Contributor

nventuro commented Oct 23, 2024 •
edited
Loading

We need to be able to find logs that were tagged following #9373. The logs will be obtained by getTaggedLogs (#9268), which requires a list of tags. #9373 defines tags as

let tag: Field = poseidon2([app_siloed_secret, recipient_address, index]);

recipient_address is simply the user's address, app_siloed_secret is obtained from #9365 for a given contract querying for logs, and index is a counter we must increment from whatever #9268 returned until we find no more logs (mirroring #9373). Once we're done, we use #9368 to update the recipient index, and instruct PXE to store any notes found via #9370.
@nventuro nventuro mentioned this issue Oct 23, 2024
Open
@nventuro nventuro added C-pxe Component: PXE (Private eXecution Envrionment) team-fairies Nico's team labels Oct 23, 2024
@nventuro nventuro mentioned this issue Oct 23, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 28, 2024
@Thunkar Thunkar mentioned this issue Oct 30, 2024
Merged
@Thunkar Thunkar self-assigned this Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 31, 2024
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue Nov 1, 2024
@Thunkar @AztecBot
feat: sync tagged logs (#9595)
0be4fae 
Closes: AztecProtocol/aztec-packages#9380

Implements the logic to sync tagged note logs from the node, taking into
account the indices of "last seen" ones.

Unfortunately, the approach of modularizing it as oracles and putting
the logic in the contract itself was met with limitations in noir
(namely, nested slices) and even the code is ready and close to becoming
separate oracles, it cannot be done (yet! or at least without major
caveats and performance implications)
@nventuro nventuro mentioned this issue Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thunkar Thunkar

Labels
C-pxe Component: PXE (Private eXecution Envrionment) team-fairies Nico's team
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: sync tagged logs AztecProtocol/aztec-packages
2 participants
@nventuro @Thunkar