Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain hashing of function circuit VKs. #9592

Closed
Tracked by #9298
LeilaWang opened this issue Oct 30, 2024 · 0 comments · Fixed by #9756
Closed
Tracked by #9298

Constrain hashing of function circuit VKs. #9592

LeilaWang opened this issue Oct 30, 2024 · 0 comments · Fixed by #9756
Assignees
@sirasistant
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) team-turing Leila's team
Milestone
TestNet

Comments

@LeilaWang
Copy link
Collaborator

No description provided.

@LeilaWang LeilaWang mentioned this issue Oct 30, 2024
Open
@LeilaWang LeilaWang added the team-turing Leila's team label Oct 30, 2024
@LeilaWang LeilaWang added this to A3 Oct 30, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 30, 2024
@LeilaWang LeilaWang added this to the TestNet milestone Oct 30, 2024
@LeilaWang LeilaWang added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Oct 30, 2024
@sirasistant sirasistant mentioned this issue Nov 6, 2024
Merged
sirasistant added a commit that referenced this issue Nov 7, 2024
@sirasistant
feat: Constrain App function VKs (#9756)
ae7cfe7 
Resolves #9592
 - Now contract artifacts must have VKs in their private functions
- aztec-nargo inserts the verification keys after public function
transpilation
 - We no longer derive any VK in the TX proving flow
 - App VKs are now constrained in the private kernels
 - Bootstrap generates VKs for all apps (with s3 caching)
- PXE is currently accepting any VK present in the artifact as valid: we
should explore the correct interface for this in the future and wether
PXE can use those VKs without rederiving them from ACIR
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Nov 7, 2024
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Nov 8, 2024
@sirasistant @AztecBot
feat: Constrain App function VKs (#9756)
f443c2e 
Resolves AztecProtocol/aztec-packages#9592
 - Now contract artifacts must have VKs in their private functions
- aztec-nargo inserts the verification keys after public function
transpilation
 - We no longer derive any VK in the TX proving flow
 - App VKs are now constrained in the private kernels
 - Bootstrap generates VKs for all apps (with s3 caching)
- PXE is currently accepting any VK present in the artifact as valid: we
should explore the correct interface for this in the future and wether
PXE can use those VKs without rederiving them from ACIR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) team-turing Leila's team
Projects
A3
Archived in project
Milestone
TestNet
Development

Successfully merging a pull request may close this issue.

feat: Constrain App function VKs AztecProtocol/aztec-packages
2 participants
@sirasistant @LeilaWang