Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up data configuration #9973

Merged
merged 43 commits into from
Nov 19, 2024
Merged

chore: Clean up data configuration #9973

merged 43 commits into from
Nov 19, 2024

Conversation

PhilWindle
Copy link
Collaborator

@PhilWindle PhilWindle commented Nov 14, 2024

This PR changes the following related to data storage configuration

  • PXE_DATA_DIRECTORY has been removed. The PXE uses DATA_DIRECTORY along with everything else.
  • DATA_DIRECTORY is deemed to be the root of all state directories. This was already partly implemented. Each component stores it's state in one or more sub-directories of this root.
  • DATA_STORE_MAP_SIZE_KB is a new environment variable and represented the mmap size provided to all environments of LMDB.
  • WS_DATA_DIRECTORY is a new optional environment variable. If provided, represents an alternative root directory for the world state only.
  • WS_DB_MAP_SIZE_KB is a new optional environment variable. If provided, represent the mmap size provided to all LMDB environment used in the world state.

@PhilWindle PhilWindle added the e2e-all CI: Enables this CI job. label Nov 14, 2024
@PhilWindle PhilWindle changed the base branch from master to pw/world-state-cleanup November 15, 2024 09:28
@PhilWindle PhilWindle marked this pull request as ready for review November 15, 2024 09:47
Base automatically changed from pw/world-state-cleanup to master November 15, 2024 14:30
@PhilWindle PhilWindle enabled auto-merge (squash) November 18, 2024 18:53
@@ -120,6 +120,7 @@
"ierc",
"indexeddb",
"initialise",
"initialising",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇬🇧

@PhilWindle PhilWindle removed the e2e-all CI: Enables this CI job. label Nov 19, 2024
@PhilWindle PhilWindle merged commit b660739 into master Nov 19, 2024
66 checks passed
@PhilWindle PhilWindle deleted the pw/data-config branch November 19, 2024 12:04
TomAFrench added a commit that referenced this pull request Nov 19, 2024
* master: (67 commits)
  chore: Fix bad merge on AztecLMDBStore initializer
  feat: add persisted database of proving jobs (#9942)
  chore: Clean up data configuration (#9973)
  chore: remove public kernels (#10027)
  chore: misc cleanup, docs and renaming (#9968)
  feat: IPA Accumulator in Builder (#9846)
  chore(docs): Updates to token contract (#9954)
  test(avm): minor benchmarking (#9869)
  chore(ci): run `l1-contracts` CI in parallel with `build` step (#10024)
  chore: build acir test programs in parallel to e2e build step (#9988)
  chore: pull out `array_set` pass changes (#9993)
  feat(avm): ephemeral avm tree (#9798)
  fix: don't take down runners with faulty runner check (#10019)
  feat(docs): add transaction profiler docs (#9932)
  chore: hotfix runner wait (#10018)
  refactor: remove EnqueuedCallSimulator (#10015)
  refactor: stop calling public kernels (#9971)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants