chore: remove public kernels #10027
Merged
chore: remove public kernels #10027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeilaWang
requested review from
fcarreiro,
dbanks12,
jeanmon and
IlyasRidhuan
as code owners
dbanks12
approved these changes
Nov 18, 2024
Comment on lines
53
to
57
| const expectNonEmptyItems = <T extends IsEmpty>(array: T[], expected: T[]) => { | ||
| const numNonEmptyItems = countAccumulatedItems(array); | ||
| expect(expected.length).toBe(numNonEmptyItems); | ||
| expect(array.slice(0, numNonEmptyItems)).toEqual(expected); | ||
| }; |
There was a problem hiding this comment.
Since we are using getSideEffects now, we probably don't need to do some of this because getSideEffects returns regular TS arrays, not constant length "Tuples"
There was a problem hiding this comment.
Ohhh didn't realise that. Lovely 🙌
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
TomAFrench
added a commit
that referenced
this pull request
Nov 19, 2024
* master: (67 commits) chore: Fix bad merge on AztecLMDBStore initializer feat: add persisted database of proving jobs (#9942) chore: Clean up data configuration (#9973) chore: remove public kernels (#10027) chore: misc cleanup, docs and renaming (#9968) feat: IPA Accumulator in Builder (#9846) chore(docs): Updates to token contract (#9954) test(avm): minor benchmarking (#9869) chore(ci): run `l1-contracts` CI in parallel with `build` step (#10024) chore: build acir test programs in parallel to e2e build step (#9988) chore: pull out `array_set` pass changes (#9993) feat(avm): ephemeral avm tree (#9798) fix: don't take down runners with faulty runner check (#10019) feat(docs): add transaction profiler docs (#9932) chore: hotfix runner wait (#10018) refactor: remove EnqueuedCallSimulator (#10015) refactor: stop calling public kernels (#9971) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.