Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish l1-contracts on NPM #10029

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Nov 19, 2024

No description provided.

@spypsy spypsy marked this pull request as ready for review November 19, 2024 10:12
Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: 8b59cce508a24958906a624672b5b1bb210133ee, compared to commit: 8e74cd09a8b65c3903c91197d599e722518ab315

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::sha256_hash -20 ✅ -0.51%
AvmTest::public_dispatch -380 ✅ -0.62%
CardGame::on_card_played -40 ✅ -0.67%
Uniswap::public_dispatch -180 ✅ -0.71%
AvmTest::keccak_hash -20 ✅ -0.72%
CardGame::on_game_joined -40 ✅ -0.79%
TokenBridge::public_dispatch -220 ✅ -0.98%
TokenBridge::exit_to_l1_public -80 ✅ -0.99%
TestLog::emit_unencrypted_events -20 ✅ -1.06%
Uniswap::swap_public -180 ✅ -1.13%
AvmTest::bulk_testing -280 ✅ -1.16%
TokenBridge::claim_public -180 ✅ -1.37%
Test::public_dispatch -300 ✅ -1.45%
AvmTest::pedersen_commit -20 ✅ -1.59%
Test::consume_mint_to_public_message -180 ✅ -1.60%
CardGame::on_cards_claimed -120 ✅ -1.61%
Test::consume_message_from_arbitrary_sender_public -160 ✅ -1.97%
CardGame::public_dispatch -400 ✅ -2.40%
CardGame::start_game -200 ✅ -2.79%
AvmTest::pedersen_hash -160 ✅ -5.17%
AvmTest::pedersen_hash_with_index -160 ✅ -5.17%
Test::create_l2_to_l1_message_public -160 ✅ -7.27%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::sha256_hash 3,890 (-20) -0.51%
AvmTest::public_dispatch 61,361 (-380) -0.62%
CardGame::on_card_played 5,947 (-40) -0.67%
Uniswap::public_dispatch 25,076 (-180) -0.71%
AvmTest::keccak_hash 2,749 (-20) -0.72%
CardGame::on_game_joined 5,046 (-40) -0.79%
TokenBridge::public_dispatch 22,192 (-220) -0.98%
TokenBridge::exit_to_l1_public 7,996 (-80) -0.99%
TestLog::emit_unencrypted_events 1,865 (-20) -1.06%
Uniswap::swap_public 15,723 (-180) -1.13%
AvmTest::bulk_testing 23,795 (-280) -1.16%
TokenBridge::claim_public 12,956 (-180) -1.37%
Test::public_dispatch 20,364 (-300) -1.45%
AvmTest::pedersen_commit 1,235 (-20) -1.59%
Test::consume_mint_to_public_message 11,104 (-180) -1.60%
CardGame::on_cards_claimed 7,338 (-120) -1.61%
Test::consume_message_from_arbitrary_sender_public 7,977 (-160) -1.97%
CardGame::public_dispatch 16,243 (-400) -2.40%
CardGame::start_game 6,965 (-200) -2.79%
AvmTest::pedersen_hash 2,935 (-160) -5.17%
AvmTest::pedersen_hash_with_index 2,935 (-160) -5.17%
Test::create_l2_to_l1_message_public 2,042 (-160) -7.27%

@rahul-kothari rahul-kothari merged commit d2d7334 into master Nov 19, 2024
103 of 106 checks passed
@rahul-kothari rahul-kothari deleted the spy/publish-l1-contracts branch November 19, 2024 14:04
Copy link
Contributor

@stevenplatt stevenplatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I notice the token stored in the repo is 1yr old now (due for rotation) - but that it outside of this PR.

TomAFrench added a commit that referenced this pull request Nov 19, 2024
Please read [contributing guidelines](CONTRIBUTING.md) and remove this
line.
bb.js releases is broken because of a missing brace introduced in #10029

This PR fixes this and moves bb.js to be the first thing we publish
because it's the most important.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants