Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deploy terraforms #3124

Closed
wants to merge 18 commits into from
Closed

chore: deploy terraforms #3124

wants to merge 18 commits into from

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Oct 30, 2023

Fixes #2994
Fixes #2999

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@spypsy spypsy force-pushed the spy/ci-terraforms branch from fe6e99e to 627ff1f Compare October 30, 2023 14:19
@AztecBot
Copy link
Collaborator

AztecBot commented Oct 30, 2023

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 3295fdd9 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,960 868,112 3,449,324
l1_rollup_execution_gas 842,047 3,595,220 22,204,693
l2_block_processing_time_in_ms 2,015 (+1%) 7,589 (+1%) 29,714
note_successful_decrypting_time_in_ms 296 (+2%) 868 (+1%) 3,147 (+1%)
note_trial_decrypting_time_in_ms 99.0 (+9%) 75.0 (+14%) 135 (+1%)
l2_block_building_time_in_ms 13,213 (+1%) 52,616 209,528 (+1%)
l2_block_rollup_simulation_time_in_ms 11,867 (+1%) 47,232 188,284 (+1%)
l2_block_public_tx_process_time_in_ms 1,308 (+1%) 5,246 (+2%) 20,739 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 21,345 (-2%) 41,742 (-2%)
note_history_successful_decrypting_time_in_ms 1,974 (-5%) 3,870 (-4%)
note_history_trial_decrypting_time_in_ms 120 (-1%) 143 (+1%)
node_database_size_in_bytes 1,631,808 1,100,146
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 778 (+1%) 61,697 18,905
private-kernel-ordering 123 24,297 8,153
base-rollup 1,770 656,311 814
root-rollup 79.4 (-7%) 4,072 1,097
private-kernel-inner 789 81,568 18,905
public-kernel-private-input 41.6 41,519 18,841
public-kernel-non-first-iteration 26.3 41,497 18,841
merge-rollup 0.942 (-4%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,787 27,547

@@ -400,7 +400,7 @@ resource "aws_ecs_task_definition" "aztec-node-2" {
[
{
"name": "${var.DEPLOY_TAG}-aztec-node-2",
"image": "${var.ECR_URL}/aztec-node:aztec3-packages-prod",
"image": "${var.ECR_URL}/aztec-node:aztec3-packages-${}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing an env var?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed good catch 👍

@spypsy spypsy closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deploy faucet Deploy Terraform configs in CI
3 participants