Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert push cli docker image to docker hub #3142

Merged

Conversation

alexghr
Copy link
Contributor

@alexghr alexghr commented Oct 31, 2023

Reverts #3120

@rahul-kothari rahul-kothari enabled auto-merge (squash) October 31, 2023 10:23
@rahul-kothari rahul-kothari merged commit 7119382 into master Oct 31, 2023
2 checks passed
@rahul-kothari rahul-kothari deleted the revert-3120-alexg/feat/publish-aztec-cli-docker-image branch October 31, 2023 10:44
@AztecBot
Copy link
Collaborator

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit db67aa1e and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,744 868,148 3,449,672
l1_rollup_execution_gas 841,831 3,595,256 22,205,041
l2_block_processing_time_in_ms 1,993 (-1%) 7,551 (-1%) 29,613 (-1%)
note_successful_decrypting_time_in_ms 295 (+2%) 853 3,145 (-3%)
note_trial_decrypting_time_in_ms 98.0 (+5%) 60.0 (-2%) 133 (-2%)
l2_block_building_time_in_ms 13,204 52,825 (+1%) 208,351
l2_block_rollup_simulation_time_in_ms 11,881 47,609 (+1%) 187,421
l2_block_public_tx_process_time_in_ms 1,281 5,084 20,446

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 21,302 (-2%) 41,709 (-1%)
note_history_successful_decrypting_time_in_ms 2,000 (-2%) 3,909 (-2%)
note_history_trial_decrypting_time_in_ms 121 142 (-24%)
node_database_size_in_bytes 1,629,376 1,096,592
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 72.0 61,697 18,841
private-kernel-ordering 43.2 (-1%) 24,233 8,089
base-rollup 1,766 656,309 811
root-rollup 75.1 (-3%) 4,072 1,097
private-kernel-inner 52.8 (-1%) 81,504 18,841
public-kernel-private-input 41.3 41,455 18,841
public-kernel-non-first-iteration 26.1 (-1%) 41,497 18,841
merge-rollup 0.920 (+2%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,240

alexghr pushed a commit that referenced this pull request Oct 31, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.13.1</summary>

##
[0.13.1](aztec-packages-v0.13.0...aztec-packages-v0.13.1)
(2023-10-31)


### Bug Fixes

* Exposing `PXE.getBlock`, exporting `createAztecNodeClient` from
`aztec.js`
([#3139](#3139))
([7af345e](7af345e))
* Revert push cli docker image to docker hub
([#3142](#3142))
([7119382](7119382))
</details>

<details><summary>barretenberg.js: 0.13.1</summary>

##
[0.13.1](barretenberg.js-v0.13.0...barretenberg.js-v0.13.1)
(2023-10-31)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.13.1</summary>

##
[0.13.1](barretenberg-v0.13.0...barretenberg-v0.13.1)
(2023-10-31)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Nov 7, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.13.1</summary>

##
[0.13.1](AztecProtocol/aztec-packages@aztec-packages-v0.13.0...aztec-packages-v0.13.1)
(2023-10-31)


### Bug Fixes

* Exposing `PXE.getBlock`, exporting `createAztecNodeClient` from
`aztec.js`
([#3139](AztecProtocol/aztec-packages#3139))
([7af345e](AztecProtocol/aztec-packages@7af345e))
* Revert push cli docker image to docker hub
([#3142](AztecProtocol/aztec-packages#3142))
([7119382](AztecProtocol/aztec-packages@7119382))
</details>

<details><summary>barretenberg.js: 0.13.1</summary>

##
[0.13.1](AztecProtocol/aztec-packages@barretenberg.js-v0.13.0...barretenberg.js-v0.13.1)
(2023-10-31)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.13.1</summary>

##
[0.13.1](AztecProtocol/aztec-packages@barretenberg-v0.13.0...barretenberg-v0.13.1)
(2023-10-31)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants