-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(yellowpaper): AVM high-level execution #3717
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
49ce589
pc and control flow in avm yp
dbanks12 69cd9e9
yp avm gas
dbanks12 6f5b856
avm yp halting
dbanks12 e6536c3
avm yp bolded keywords, link fix
dbanks12 1cfa370
avm yp finish halting section
dbanks12 a0b4a6f
nested context initialization
dbanks12 09fd453
Merge branch 'master' into db/avm-yellowpaper-execution
dbanks12 fea6573
updates after pr feedback
dbanks12 873c3ae
fixes from PR
dbanks12 cc2ee4e
Merge branch 'master' into db/avm-yellowpaper-execution
dbanks12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
updates after pr feedback
- Loading branch information
commit fea657346d4e38cf240681137fb937432b2d54e8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth mentioning only instructions with a side effect / data commitment cost will require l1 gas. Logical operations will not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I think they only have an l1 gas cost if they modify world state (storage, trees, etc) or append to accrued substate (logs, messages):
"> Note: many instructions (including all basic arithmetic operations) have 0
l1GasCost
. Instructions only incur an L1 cost if they modify world state or accrued substate."