-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Just nargo compile. #3775
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
bf127da
initial
charlielye 19c9dbe
wip
charlielye caafead
Move noir contract code out of src.
charlielye f12b05a
wip
charlielye 35c7ee5
cleanup
charlielye 79981ab
wip
charlielye e79d2d1
wip
charlielye 1526c6e
fixup
charlielye 32f83ab
fix
charlielye 0de17dc
fix
charlielye a0e4e90
fix
charlielye c435b07
fix
charlielye 96ec508
fix
charlielye 68c0408
boxes
charlielye b1313dd
formatting
charlielye 2f395ca
some fixes
charlielye 8c9b311
Merge remote-tracking branch 'origin/master' into cl/just_nargo_compile
charlielye 05ad1b9
update paths
charlielye 2a64b30
nargo needed in boxes
charlielye ca7c1df
fix
charlielye 86bec8a
add dep
charlielye 3d732b0
fix
charlielye b3ce313
add debug info
charlielye a2f5c37
perm
charlielye ee07c86
Merge remote-tracking branch 'origin/master' into cl/just_nargo_compile
charlielye 95930f8
Merge remote-tracking branch 'origin/master' into cl/just_nargo_compile
charlielye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
#!/usr/bin/env bash | ||
set -euo pipefail | ||
|
||
export VERSION=${1:-$VERSION} | ||
export SKIP_TITLE=1 | ||
bash -i <(curl -s http://install.aztec.network) | ||
bash -i <(curl -s http://install.aztec.network) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,14 @@ | ||
# Builds the boxes (they were copied into yarn-project-base so the cli can unbox). | ||
# Produces a container that can be run to test a specific box. See docker-compose.yml. | ||
FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/aztec-sandbox AS aztec-sandbox | ||
FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/noir as noir | ||
|
||
# We need yarn. Start fresh container. | ||
FROM node:18.19.0 | ||
COPY --from=aztec-sandbox /usr/src /usr/src | ||
COPY --from=noir /usr/src/noir/target/release/nargo /usr/src/noir/target/release/nargo | ||
WORKDIR /usr/src/boxes | ||
ENV AZTEC_CLI=../../yarn-project/cli/aztec-cli-dest | ||
ENV AZTEC_NARGO=/usr/src/noir/target/release/nargo | ||
ENV AZTEC_CLI=/usr/src/yarn-project/cli/aztec-cli-dest | ||
RUN yarn && yarn build | ||
ENTRYPOINT ["yarn", "workspace"] | ||
ENTRYPOINT ["yarn", "workspace"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -166,6 +166,7 @@ boxes: | |
buildDir: boxes | ||
dependencies: | ||
- aztec-sandbox | ||
- noir | ||
runDependencies: | ||
- aztec-sandbox | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this perform the noir output transformations now?
edit: codegen now does it - this is a breaking change?