-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: build protocol circuits on CI and stop committing artifacts #3816
Changes from 9 commits
035a8a6
243a77e
1d2e663
f2913c2
144af27
4fa2c29
6ab13de
b0d20d1
935c50f
f449ccf
b88e2d1
4296afa
ba0bec7
1548a57
0ca1a37
9d79c0c
6372bcb
cdc1089
fb1cb49
caa0d39
379a995
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,4 @@ Prover.toml | |
Verifier.toml | ||
src/target | ||
src/crs | ||
src/types |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ | |
"scripts": { | ||
"build": "yarn clean && tsc -b", | ||
"build:dev": "tsc -b --watch", | ||
"build:noir": "yarn noir:build && node --loader ts-node/esm src/scripts/generate_ts_from_abi.ts", | ||
"clean": "rm -rf ./dest .tsbuildinfo", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
"formatting": "run -T prettier --check ./src && run -T eslint ./src", | ||
"formatting:fix": "NODE_OPTIONS='--max-old-space-size=8096' run -T eslint --fix ./src && run -T prettier -w ./src", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,7 +87,7 @@ import { | |
AztecAddress as NoirAztecAddress, | ||
EthAddress as NoirEthAddress, | ||
Field as NoirField, | ||
Point as NoirPoint, | ||
GrumpkinPoint as NoirPoint, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why does it suddenly become There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there was a small type change in https://github.com/AztecProtocol/aztec-packages/pull/3814/files |
||
OptionallyRevealedData as OptionallyRevealedDataNoir, | ||
PrivateCallData as PrivateCallDataNoir, | ||
PrivateCallStackItem as PrivateCallStackItemNoir, | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: couldn't do
&& yarn noir:types
because its final commandyarn formatting:fix
was failing with missing dep @yarn/merkle-tree . but, it's just formatting, so seems like better to leave image as-is?