Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bb): rearrange namespaces #4147

Merged
merged 53 commits into from
Jan 23, 2024
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
7286f87
refactor: proof_system=>bb
ludamad0 Jan 18, 2024
3329c32
refactor: plonk::stdlib => stdlib
ludamad0 Jan 18, 2024
751d6e3
remove redundant lines
ludamad0 Jan 18, 2024
e01edd7
refactor: more deplonking
ludamad0 Jan 18, 2024
eaeaa8f
Flatten namespaces
ludamad0 Jan 18, 2024
e1a4dd8
fix: fuzzing
ludamad0 Jan 18, 2024
87751ec
More condensing namespaces
ludamad0 Jan 18, 2024
87c60ad
More condensing namespaces
ludamad0 Jan 18, 2024
711ede0
shortening
ludamad0 Jan 18, 2024
55b16ca
namespace standardization
ludamad0 Jan 18, 2024
2f1f0ad
plookup in bb
ludamad0 Jan 19, 2024
9d292f1
crypto as bb::crypto
ludamad0 Jan 19, 2024
673be48
remove test namespaces
ludamad0 Jan 19, 2024
96822cd
Test namespace removal
ludamad0 Jan 19, 2024
7316725
Test namespace removal
ludamad0 Jan 19, 2024
3377abe
acir namespace simplification
ludamad0 Jan 19, 2024
25ccd58
acir namespace simplification
ludamad0 Jan 19, 2024
492c028
acir namespace simplification
ludamad0 Jan 19, 2024
df92cc0
remove rest of test namespaces
ludamad0 Jan 19, 2024
e3492fa
numeric namespace passes
ludamad0 Jan 19, 2024
89044d3
numeric namespace passes
ludamad0 Jan 19, 2024
5cf65f7
numeric namespace passes
ludamad0 Jan 19, 2024
d614a79
namespace randomness simplification
ludamad0 Jan 19, 2024
f10f22f
blake2s namespace gone
ludamad0 Jan 19, 2024
7a71095
Missing files
ludamad0 Jan 19, 2024
7d22216
ecdsa prefix
ludamad0 Jan 19, 2024
e5863c7
namespace simplification
ludamad0 Jan 19, 2024
aaf29f9
ecdsa namespace gone
ludamad0 Jan 19, 2024
1242848
schnorr prefix
ludamad0 Jan 19, 2024
9936ba6
schnorr namespace gone
ludamad0 Jan 19, 2024
8d66268
fix: builder
ludamad0 Jan 22, 2024
f70ff6c
fix typed test
ludamad0 Jan 22, 2024
03fca1a
Merge commit '14d39edbe1a6753849581a664184d4e98baf923d' into ad/refac…
ludamad0 Jan 22, 2024
431bb6a
Fix join split
ludamad Jan 22, 2024
7d74e64
Fix join split
ludamad Jan 22, 2024
1ead4a9
Fix join spliut
ludamad Jan 22, 2024
2b104ec
fix schnorr forward declares
ludamad Jan 22, 2024
b95b435
fix: build
ludamad0 Jan 22, 2024
9a36398
fix: build
ludamad0 Jan 22, 2024
eb25f5f
Standardize tests
ludamad0 Jan 22, 2024
6cda77c
fix: build
ludamad0 Jan 22, 2024
6e0acb2
Remove bb:: prefixes in tests
ludamad0 Jan 22, 2024
cf41943
build fix
ludamad0 Jan 22, 2024
78823cb
fix: fuzzer
ludamad0 Jan 22, 2024
a33236d
Merge remote-tracking branch 'origin/master' into ad/refactor/bb/flatten
ludamad0 Jan 22, 2024
94756a7
post-merge fixes
ludamad0 Jan 22, 2024
eebb62e
fix: small fix
ludamad0 Jan 22, 2024
415af1e
fix: revert helpers.test.*
ludamad0 Jan 22, 2024
4002336
fix: revert helpers.test.*
ludamad0 Jan 22, 2024
cfc6295
More namespace cleanup
ludamad0 Jan 23, 2024
d93a4fe
array utilities in bb
ludamad0 Jan 23, 2024
8cc49aa
Merge remote-tracking branch 'origin/master' into ad/refactor/bb/flatten
ludamad0 Jan 23, 2024
506d45e
Fix merge
ludamad0 Jan 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More condensing namespaces
  • Loading branch information
ludamad0 committed Jan 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 87c60adf9d890d8d477d663385dad3183aefc057
6 changes: 2 additions & 4 deletions barretenberg/cpp/src/barretenberg/flavor/ecc_vm.hpp
Original file line number Diff line number Diff line change
@@ -26,8 +26,7 @@

// NOLINTBEGIN(cppcoreguidelines-avoid-const-or-ref-data-members)

namespace bb::honk {
namespace flavor {
namespace bb::honk::flavor {

template <typename CycleGroup_T, typename Curve_T, typename PCS_T> class ECCVMBase {
public:
@@ -929,5 +928,4 @@ class ECCVM : public ECCVMBase<bb::g1, curve::Grumpkin, pcs::ipa::IPA<curve::Gru

// NOLINTEND(cppcoreguidelines-avoid-const-or-ref-data-members)

} // namespace flavor
} // namespace bb::honk
} // namespace bb::honk::flavor
Original file line number Diff line number Diff line change
@@ -17,8 +17,7 @@
#include "barretenberg/relations/generated/Toy/two_column_perm.hpp"
#include "barretenberg/transcript/transcript.hpp"

namespace bb::honk {
namespace flavor {
namespace bb::honk::flavor {

class ToyFlavor {
public:
@@ -368,5 +367,4 @@ class ToyFlavor {
};
};

} // namespace flavor
} // namespace bb::honk
} // namespace bb::honk::flavor
Original file line number Diff line number Diff line change
@@ -9,12 +9,10 @@ construction in stdlib and contains macros for explicit instantiation.
#pragma once
#include <concepts>

namespace bb::honk {
namespace flavor {
namespace bb::honk::flavor {
class Standard;
class Ultra;
} // namespace flavor
} // namespace bb::honk
} // namespace bb::honk::flavor

namespace bb {
class Bn254FrParams;