Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: nullifier key #4166

Merged
merged 7 commits into from
Jan 22, 2024
Merged

feat!: nullifier key #4166

merged 7 commits into from
Jan 22, 2024

Conversation

LeilaWang
Copy link
Collaborator

@LeilaWang LeilaWang commented Jan 22, 2024 •
edited
Loading

  • Rename oracle call get_secret_key to get_nullifier_secret_key.
  • Add new method request_nullifier_secret_key(account: Address) to PrivateContext, which returns a nullifier secret key for an account, and also pushes a request for the kernel circuit to verify the keys.
  • Changes to NoteInterface:
    • Change compute_nullifier() to compute_nullifier(private_context: PrivateContext). If a secret is used in creating a nullifier, it must be fetched via private_context.request_nullifier_secret_key(account_address).
    • Add new method compute_nullifier_without_context(). This will be used in unconstrained functions where the private context is not available, and using an unverified nullifier keys won't affect other users. For example, it's used in compute_note_hash_and_nullifier to compute values for the user's own notes.
  • Add new apis to KeyStore:
    • getNullifierSecretKey(pubKey: PublicKey)
    • getNullifierPublicKey(pubKey: PublicKey)
    • getSiloedNullifierSecretKey(pubKey: PublicKey, contractAddress: AztecAddress)

@AztecBot
Copy link
Collaborator

AztecBot commented Jan 22, 2024 •
edited
Loading

Benchmark results

Metrics with a significant change:

  • batch_insert_into_append_only_tree_32_depth_ms (512): 291 (+17%)
  • batch_insert_into_indexed_tree_20_depth_ms (512): 499 (+35%)
  • note_trial_decrypting_time_in_ms (8): 98.8 (+364%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 14d39edb and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,412 179,524 716,068
l1_rollup_calldata_gas 221,728 866,428 3,446,968
l1_rollup_execution_gas 314,147 984,100 3,666,557
l2_block_processing_time_in_ms 1,604 (+1%) 5,226 (-1%) 20,686 (-1%)
note_successful_decrypting_time_in_ms 287 (-6%) 849 (-8%) 3,188 (-10%)
note_trial_decrypting_time_in_ms ⚠️ 98.8 (+364%) 73.5 (+48%) 140 (-5%)
l2_block_building_time_in_ms 16,076 63,822 254,887 (-1%)
l2_block_rollup_simulation_time_in_ms 11,701 46,493 185,909 (-1%)
l2_block_public_tx_process_time_in_ms 4,342 17,243 68,692

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,743 (-4%) 29,973 (-5%)
note_history_successful_decrypting_time_in_ms 1,952 (-13%) 4,081 (-12%)
note_history_trial_decrypting_time_in_ms 130 (-55%) 201 (-17%)
node_database_size_in_bytes 3,517,085 3,546,989
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 212 44,681 25,561
private-kernel-ordering 165 (-1%) 43,753 14,809
base-rollup 1,194 128,338 881
root-rollup 82.9 (+5%) 4,088 677
private-kernel-inner 292 71,208 25,561
public-kernel-private-input 205 31,863 25,561
public-kernel-non-first-iteration 203 31,905 25,561
merge-rollup 7.64 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 12.0 (-1%) 18.0 13.7 (-7%) 20.2 (+2%) 24.4 (-5%) 66.7 (-4%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.618 (-1%) 0.648 (+5%) 0.549 (-8%) 0.554 (+1%) 0.483 (-1%) 0.442 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 83.0 (+1%) 51.8 (-1%) ⚠️ 291 (+17%) 477 (-2%) 917 3,561
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.477 (+2%) 0.499 0.475 (+9%) 0.437 0.432 (+1%) 0.426
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 118 (-1%) 61.5 (-3%) ⚠️ 499 (+35%) 762 (-4%) 1,426 (-1%) 5,596
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.515 (+2%) 0.501 (-1%) 0.510 (+7%) 0.485 (-1%) 0.473 0.472
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 66.6 (-3%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.595 (-1%) N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,455 32,220

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 374 1,082
Metric 1 public data writes
tx_sequencer_processing_time_ms 534 (-1%)

LeilaWang
LeilaWang commented Jan 22, 2024
View reviewed changes
yarn-project/aztec-nr/aztec/src/context.nr
let key_pair = get_nullifier_key_pair(account);
validate_nullifier_key_aginst_address(account, key_pair.public_key, key_pair.secret_key);
// TODO: Add request to context.
// self.context.push_nullifier_key_validation_request(public_key, secret_key);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done in another PR.

LeilaWang
LeilaWang commented Jan 22, 2024
View reviewed changes
yarn-project/acir-simulator/src/client/view_data_oracle.ts
public getSecretKey(owner: PublicKey) {
return this.db.getSecretKey(this.contractAddress, owner);
public getNullifierKeyPair(account: AztecAddress) {
return this.db.getNullifierKeyPair(account, this.contractAddress);
Copy link
Collaborator Author

@LeilaWang LeilaWang Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be storage contract address. Will change in another PR where the address is actually used to silo the key.

sirasistant
sirasistant approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀 Many docs-annotated notes removed, were all those unused? :O

yarn-project/aztec-nr/aztec/src/key/nullifier_key.nr Outdated Show resolved Hide resolved
@LeilaWang
Copy link
Collaborator Author

@AztecProtocol/devrel some changes to the NoteInterface in this PR.

@LeilaWang LeilaWang merged commit 7c07665 into master Jan 22, 2024
83 checks passed
@LeilaWang LeilaWang deleted the lw/nullifier_key branch January 22, 2024 15:03
@AztecBot AztecBot mentioned this pull request Jan 22, 2024
Merged
rahul-kothari pushed a commit that referenced this pull request Jan 23, 2024
@AztecBot
chore(master): Release 0.20.0 (#4086)
ca8b5d9 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.20.0</summary>

##
[0.20.0](aztec-packages-v0.19.0...aztec-packages-v0.20.0)
(2024-01-22)


### ⚠ BREAKING CHANGES

* nullifier key
([#4166](#4166))
* Unify ABIs between nargo and yarn-project
([#3989](#3989))

### Features

* **avm:** Add internal jump and return, adjust control flow
([#4140](#4140))
([b77afb1](b77afb1))
* **avm:** Better field arithmetic
([#4142](#4142))
([7308e31](7308e31))
* **avm:** Encode TS AVM instructions as bytecode, especially for
testing
([#4115](#4115))
([de6e2ed](de6e2ed))
* **avm:** Improve interpreter errors and tests
([#4173](#4173))
([f0fb594](f0fb594))
* Benchmark commit function
([#4178](#4178))
([ea84085](ea84085))
* Goblin acir composer
([#4112](#4112))
([5e85b92](5e85b92))
* Nullifier key
([#4166](#4166))
([7c07665](7c07665))
* **public-vm:** Avm journal
([#3945](#3945))
([5658468](5658468))
* Publish block body separately
([#4118](#4118))
([a04e1e3](a04e1e3)),
closes
[#3944](#3944)
* Unify ABIs between nargo and yarn-project
([#3989](#3989))
([d083438](d083438))
* Update noir
([#4082](#4082))
([0e6037a](0e6037a))
* Updating L2 Block encoding and `Rollup.process` function
([#4015](#4015))
([2d8eb37](2d8eb37)),
closes
[#3936](#3936)
[#4010](#4010)
[#4011](#4011)


### Bug Fixes

* Bb.js version in yarn lockfile
([7b96760](7b96760))
* **build:** Publish bb.js from CCI
([#4151](#4151))
([09dbfcd](09dbfcd))
* Make CMake version warning fatal
([#4144](#4144))
([b1443fa](b1443fa))
* Misleading error message in `PublicState::read`
([#4149](#4149))
([fa4d919](fa4d919))
* Nargo destination path in bootstrap cache
([#4103](#4103))
([4901309](4901309))
* Reinstate Ultra arith rec verifier test
([#3886](#3886))
([995973b](995973b))
* Upload_benchmarks_to_s3.sh missing exit
([#4046](#4046))
([52a9327](52a9327))


### Miscellaneous

* Archiver store
([#3966](#3966))
([af2be87](af2be87))
* **avm:** List avm opcodes in a (enum =&gt; class) map in TS
([#4113](#4113))
([dee564a](dee564a))
* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([#4146](#4146))
([14d39ed](14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([#4117](#4117))
([cd2f67f](cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([#4116](#4116))
([7438db3](7438db3))
* **docs:** Aztec-up doesnt need `latest`, remove warnings around
sandbox/cli npm pkgs
([#4138](#4138))
([2bbf7a9](2bbf7a9))
* **docs:** Update js release notes for 0.18.0
([#4051](#4051))
([bdbe963](bdbe963))
* **docs:** Update lsp install instructions
([#4110](#4110))
([3138816](3138816)),
closes
[#4098](#4098)
* Dont mirror build-system mirror_repos.yml
([#4067](#4067))
([04f8e0d](04f8e0d))
* Fixes many broken urls
([#4109](#4109))
([41ae75c](41ae75c))
* Remove dependency cycles in `sequencer-client`
([#4017](#4017))
([fe4538b](fe4538b))
* Remove lodash times in favor of foundation fn
([#3877](#3877))
([a10eef0](a10eef0))
* Remove mutex dependency
([#4160](#4160))
([3b82be0](3b82be0))
* Remove unnecessary computation
([#4133](#4133))
([f35bdb8](f35bdb8))
* Remove unused noir-version json
([#4105](#4105))
([afca819](afca819))
* Remove unwanted submodules
([#4085](#4085))
([dda7c9c](dda7c9c))
* Replace relative paths to noir-protocol-circuits
([59feeb5](59feeb5))
* Replace relative paths to noir-protocol-circuits
([44d9136](44d9136))
* Replace relative paths to noir-protocol-circuits
([84b0bad](84b0bad))
* Simplify and fix DocsExample contract, e2e singleton + codegen to not
show internal methods
([#4169](#4169))
([38d262e](38d262e))
* Update noir
([#4168](#4168))
([d40ad06](d40ad06))


### Documentation

* Update migration notes
([#4175](#4175))
([dbc8174](dbc8174))
* **yellow-paper:** Update circuit sections for nullifier keys and
static calls
([#4155](#4155))
([ed71a57](ed71a57))
* **yellowpaper:** Refresh of avm instruction set
([#4081](#4081))
([52162ee](52162ee))
</details>

<details><summary>barretenberg.js: 0.20.0</summary>

##
[0.20.0](barretenberg.js-v0.19.0...barretenberg.js-v0.20.0)
(2024-01-22)


### Features

* Goblin acir composer
([#4112](#4112))
([5e85b92](5e85b92))
</details>

<details><summary>barretenberg: 0.20.0</summary>

##
[0.20.0](barretenberg-v0.19.0...barretenberg-v0.20.0)
(2024-01-22)


### Features

* Benchmark commit function
([#4178](#4178))
([ea84085](ea84085))
* Goblin acir composer
([#4112](#4112))
([5e85b92](5e85b92))


### Bug Fixes

* Make CMake version warning fatal
([#4144](#4144))
([b1443fa](b1443fa))
* Reinstate Ultra arith rec verifier test
([#3886](#3886))
([995973b](995973b))
* Upload_benchmarks_to_s3.sh missing exit
([#4046](#4046))
([52a9327](52a9327))


### Miscellaneous

* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([#4146](#4146))
([14d39ed](14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([#4117](#4117))
([cd2f67f](cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([#4116](#4116))
([7438db3](7438db3))
* Remove mutex dependency
([#4160](#4160))
([3b82be0](3b82be0))
* Remove unwanted submodules
([#4085](#4085))
([dda7c9c](dda7c9c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Jan 24, 2024
@AztecBot
chore(master): Release 0.20.0 (#4086)
bb90d73 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@aztec-packages-v0.19.0...aztec-packages-v0.20.0)
(2024-01-22)


### ⚠ BREAKING CHANGES

* nullifier key
([#4166](AztecProtocol/aztec-packages#4166))
* Unify ABIs between nargo and yarn-project
([#3989](AztecProtocol/aztec-packages#3989))

### Features

* **avm:** Add internal jump and return, adjust control flow
([#4140](AztecProtocol/aztec-packages#4140))
([b77afb1](AztecProtocol/aztec-packages@b77afb1))
* **avm:** Better field arithmetic
([#4142](AztecProtocol/aztec-packages#4142))
([7308e31](AztecProtocol/aztec-packages@7308e31))
* **avm:** Encode TS AVM instructions as bytecode, especially for
testing
([#4115](AztecProtocol/aztec-packages#4115))
([de6e2ed](AztecProtocol/aztec-packages@de6e2ed))
* **avm:** Improve interpreter errors and tests
([#4173](AztecProtocol/aztec-packages#4173))
([f0fb594](AztecProtocol/aztec-packages@f0fb594))
* Benchmark commit function
([#4178](AztecProtocol/aztec-packages#4178))
([ea84085](AztecProtocol/aztec-packages@ea84085))
* Goblin acir composer
([#4112](AztecProtocol/aztec-packages#4112))
([5e85b92](AztecProtocol/aztec-packages@5e85b92))
* Nullifier key
([#4166](AztecProtocol/aztec-packages#4166))
([7c07665](AztecProtocol/aztec-packages@7c07665))
* **public-vm:** Avm journal
([#3945](AztecProtocol/aztec-packages#3945))
([5658468](AztecProtocol/aztec-packages@5658468))
* Publish block body separately
([#4118](AztecProtocol/aztec-packages#4118))
([a04e1e3](AztecProtocol/aztec-packages@a04e1e3)),
closes
[#3944](AztecProtocol/aztec-packages#3944)
* Unify ABIs between nargo and yarn-project
([#3989](AztecProtocol/aztec-packages#3989))
([d083438](AztecProtocol/aztec-packages@d083438))
* Update noir
([#4082](AztecProtocol/aztec-packages#4082))
([0e6037a](AztecProtocol/aztec-packages@0e6037a))
* Updating L2 Block encoding and `Rollup.process` function
([#4015](AztecProtocol/aztec-packages#4015))
([2d8eb37](AztecProtocol/aztec-packages@2d8eb37)),
closes
[#3936](AztecProtocol/aztec-packages#3936)
[#4010](AztecProtocol/aztec-packages#4010)
[#4011](AztecProtocol/aztec-packages#4011)


### Bug Fixes

* Bb.js version in yarn lockfile
([7b96760](AztecProtocol/aztec-packages@7b96760))
* **build:** Publish bb.js from CCI
([#4151](AztecProtocol/aztec-packages#4151))
([09dbfcd](AztecProtocol/aztec-packages@09dbfcd))
* Make CMake version warning fatal
([#4144](AztecProtocol/aztec-packages#4144))
([b1443fa](AztecProtocol/aztec-packages@b1443fa))
* Misleading error message in `PublicState::read`
([#4149](AztecProtocol/aztec-packages#4149))
([fa4d919](AztecProtocol/aztec-packages@fa4d919))
* Nargo destination path in bootstrap cache
([#4103](AztecProtocol/aztec-packages#4103))
([4901309](AztecProtocol/aztec-packages@4901309))
* Reinstate Ultra arith rec verifier test
([#3886](AztecProtocol/aztec-packages#3886))
([995973b](AztecProtocol/aztec-packages@995973b))
* Upload_benchmarks_to_s3.sh missing exit
([#4046](AztecProtocol/aztec-packages#4046))
([52a9327](AztecProtocol/aztec-packages@52a9327))


### Miscellaneous

* Archiver store
([#3966](AztecProtocol/aztec-packages#3966))
([af2be87](AztecProtocol/aztec-packages@af2be87))
* **avm:** List avm opcodes in a (enum =&gt; class) map in TS
([#4113](AztecProtocol/aztec-packages#4113))
([dee564a](AztecProtocol/aztec-packages@dee564a))
* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([#4146](AztecProtocol/aztec-packages#4146))
([14d39ed](AztecProtocol/aztec-packages@14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([#4117](AztecProtocol/aztec-packages#4117))
([cd2f67f](AztecProtocol/aztec-packages@cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([#4116](AztecProtocol/aztec-packages#4116))
([7438db3](AztecProtocol/aztec-packages@7438db3))
* **docs:** Aztec-up doesnt need `latest`, remove warnings around
sandbox/cli npm pkgs
([#4138](AztecProtocol/aztec-packages#4138))
([2bbf7a9](AztecProtocol/aztec-packages@2bbf7a9))
* **docs:** Update js release notes for 0.18.0
([#4051](AztecProtocol/aztec-packages#4051))
([bdbe963](AztecProtocol/aztec-packages@bdbe963))
* **docs:** Update lsp install instructions
([#4110](AztecProtocol/aztec-packages#4110))
([3138816](AztecProtocol/aztec-packages@3138816)),
closes
[#4098](AztecProtocol/aztec-packages#4098)
* Dont mirror build-system mirror_repos.yml
([#4067](AztecProtocol/aztec-packages#4067))
([04f8e0d](AztecProtocol/aztec-packages@04f8e0d))
* Fixes many broken urls
([#4109](AztecProtocol/aztec-packages#4109))
([41ae75c](AztecProtocol/aztec-packages@41ae75c))
* Remove dependency cycles in `sequencer-client`
([#4017](AztecProtocol/aztec-packages#4017))
([fe4538b](AztecProtocol/aztec-packages@fe4538b))
* Remove lodash times in favor of foundation fn
([#3877](AztecProtocol/aztec-packages#3877))
([a10eef0](AztecProtocol/aztec-packages@a10eef0))
* Remove mutex dependency
([#4160](AztecProtocol/aztec-packages#4160))
([3b82be0](AztecProtocol/aztec-packages@3b82be0))
* Remove unnecessary computation
([#4133](AztecProtocol/aztec-packages#4133))
([f35bdb8](AztecProtocol/aztec-packages@f35bdb8))
* Remove unused noir-version json
([#4105](AztecProtocol/aztec-packages#4105))
([afca819](AztecProtocol/aztec-packages@afca819))
* Remove unwanted submodules
([#4085](AztecProtocol/aztec-packages#4085))
([dda7c9c](AztecProtocol/aztec-packages@dda7c9c))
* Replace relative paths to noir-protocol-circuits
([59feeb5](AztecProtocol/aztec-packages@59feeb5))
* Replace relative paths to noir-protocol-circuits
([44d9136](AztecProtocol/aztec-packages@44d9136))
* Replace relative paths to noir-protocol-circuits
([84b0bad](AztecProtocol/aztec-packages@84b0bad))
* Simplify and fix DocsExample contract, e2e singleton + codegen to not
show internal methods
([#4169](AztecProtocol/aztec-packages#4169))
([38d262e](AztecProtocol/aztec-packages@38d262e))
* Update noir
([#4168](AztecProtocol/aztec-packages#4168))
([d40ad06](AztecProtocol/aztec-packages@d40ad06))


### Documentation

* Update migration notes
([#4175](AztecProtocol/aztec-packages#4175))
([dbc8174](AztecProtocol/aztec-packages@dbc8174))
* **yellow-paper:** Update circuit sections for nullifier keys and
static calls
([#4155](AztecProtocol/aztec-packages#4155))
([ed71a57](AztecProtocol/aztec-packages@ed71a57))
* **yellowpaper:** Refresh of avm instruction set
([#4081](AztecProtocol/aztec-packages#4081))
([52162ee](AztecProtocol/aztec-packages@52162ee))
</details>

<details><summary>barretenberg.js: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@barretenberg.js-v0.19.0...barretenberg.js-v0.20.0)
(2024-01-22)


### Features

* Goblin acir composer
([#4112](AztecProtocol/aztec-packages#4112))
([5e85b92](AztecProtocol/aztec-packages@5e85b92))
</details>

<details><summary>barretenberg: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@barretenberg-v0.19.0...barretenberg-v0.20.0)
(2024-01-22)


### Features

* Benchmark commit function
([#4178](AztecProtocol/aztec-packages#4178))
([ea84085](AztecProtocol/aztec-packages@ea84085))
* Goblin acir composer
([#4112](AztecProtocol/aztec-packages#4112))
([5e85b92](AztecProtocol/aztec-packages@5e85b92))


### Bug Fixes

* Make CMake version warning fatal
([#4144](AztecProtocol/aztec-packages#4144))
([b1443fa](AztecProtocol/aztec-packages@b1443fa))
* Reinstate Ultra arith rec verifier test
([#3886](AztecProtocol/aztec-packages#3886))
([995973b](AztecProtocol/aztec-packages@995973b))
* Upload_benchmarks_to_s3.sh missing exit
([#4046](AztecProtocol/aztec-packages#4046))
([52a9327](AztecProtocol/aztec-packages@52a9327))


### Miscellaneous

* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([#4146](AztecProtocol/aztec-packages#4146))
([14d39ed](AztecProtocol/aztec-packages@14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([#4117](AztecProtocol/aztec-packages#4117))
([cd2f67f](AztecProtocol/aztec-packages@cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([#4116](AztecProtocol/aztec-packages#4116))
([7438db3](AztecProtocol/aztec-packages@7438db3))
* Remove mutex dependency
([#4160](AztecProtocol/aztec-packages#4160))
([3b82be0](AztecProtocol/aztec-packages@3b82be0))
* Remove unwanted submodules
([#4085](AztecProtocol/aztec-packages#4085))
([dda7c9c](AztecProtocol/aztec-packages@dda7c9c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
@LeilaWang
feat!: nullifier key (AztecProtocol#4166)
8c1f719 
- Rename oracle call `get_secret_key` to `get_nullifier_secret_key`.
- Add new method `request_nullifier_secret_key(account: Address)` to
`PrivateContext`, which returns a nullifier secret key for an account,
and also pushes a request for the kernel circuit to verify the keys.
- Changes to `NoteInterface`:
- Change `compute_nullifier()` to `compute_nullifier(private_context:
PrivateContext)`. If a secret is used in creating a nullifier, it must
be fetched via
`private_context.request_nullifier_secret_key(account_address)`.
- Add new method `compute_nullifier_without_context()`. This will be
used in unconstrained functions where the private context is not
available, and using an unverified nullifier keys won't affect other
users. For example, it's used in `compute_note_hash_and_nullifier` to
compute values for the user's own notes.
- Add new apis to `KeyStore`:
  - `getNullifierSecretKey(pubKey: PublicKey)`
  - `getNullifierPublicKey(pubKey: PublicKey)`
- `getSiloedNullifierSecretKey(pubKey: PublicKey, contractAddress:
AztecAddress)`
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
@AztecBot
chore(master): Release 0.20.0 (AztecProtocol#4086)
4cf818f 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@aztec-packages-v0.19.0...aztec-packages-v0.20.0)
(2024-01-22)


### ⚠ BREAKING CHANGES

* nullifier key
([AztecProtocol#4166](AztecProtocol#4166))
* Unify ABIs between nargo and yarn-project
([AztecProtocol#3989](AztecProtocol#3989))

### Features

* **avm:** Add internal jump and return, adjust control flow
([AztecProtocol#4140](AztecProtocol#4140))
([b77afb1](AztecProtocol@b77afb1))
* **avm:** Better field arithmetic
([AztecProtocol#4142](AztecProtocol#4142))
([7308e31](AztecProtocol@7308e31))
* **avm:** Encode TS AVM instructions as bytecode, especially for
testing
([AztecProtocol#4115](AztecProtocol#4115))
([de6e2ed](AztecProtocol@de6e2ed))
* **avm:** Improve interpreter errors and tests
([AztecProtocol#4173](AztecProtocol#4173))
([f0fb594](AztecProtocol@f0fb594))
* Benchmark commit function
([AztecProtocol#4178](AztecProtocol#4178))
([ea84085](AztecProtocol@ea84085))
* Goblin acir composer
([AztecProtocol#4112](AztecProtocol#4112))
([5e85b92](AztecProtocol@5e85b92))
* Nullifier key
([AztecProtocol#4166](AztecProtocol#4166))
([7c07665](AztecProtocol@7c07665))
* **public-vm:** Avm journal
([AztecProtocol#3945](AztecProtocol#3945))
([5658468](AztecProtocol@5658468))
* Publish block body separately
([AztecProtocol#4118](AztecProtocol#4118))
([a04e1e3](AztecProtocol@a04e1e3)),
closes
[AztecProtocol#3944](AztecProtocol#3944)
* Unify ABIs between nargo and yarn-project
([AztecProtocol#3989](AztecProtocol#3989))
([d083438](AztecProtocol@d083438))
* Update noir
([AztecProtocol#4082](AztecProtocol#4082))
([0e6037a](AztecProtocol@0e6037a))
* Updating L2 Block encoding and `Rollup.process` function
([AztecProtocol#4015](AztecProtocol#4015))
([2d8eb37](AztecProtocol@2d8eb37)),
closes
[AztecProtocol#3936](AztecProtocol#3936)
[AztecProtocol#4010](AztecProtocol#4010)
[AztecProtocol#4011](AztecProtocol#4011)


### Bug Fixes

* Bb.js version in yarn lockfile
([7b96760](AztecProtocol@7b96760))
* **build:** Publish bb.js from CCI
([AztecProtocol#4151](AztecProtocol#4151))
([09dbfcd](AztecProtocol@09dbfcd))
* Make CMake version warning fatal
([AztecProtocol#4144](AztecProtocol#4144))
([b1443fa](AztecProtocol@b1443fa))
* Misleading error message in `PublicState::read`
([AztecProtocol#4149](AztecProtocol#4149))
([fa4d919](AztecProtocol@fa4d919))
* Nargo destination path in bootstrap cache
([AztecProtocol#4103](AztecProtocol#4103))
([4901309](AztecProtocol@4901309))
* Reinstate Ultra arith rec verifier test
([AztecProtocol#3886](AztecProtocol#3886))
([995973b](AztecProtocol@995973b))
* Upload_benchmarks_to_s3.sh missing exit
([AztecProtocol#4046](AztecProtocol#4046))
([52a9327](AztecProtocol@52a9327))


### Miscellaneous

* Archiver store
([AztecProtocol#3966](AztecProtocol#3966))
([af2be87](AztecProtocol@af2be87))
* **avm:** List avm opcodes in a (enum =&gt; class) map in TS
([AztecProtocol#4113](AztecProtocol#4113))
([dee564a](AztecProtocol@dee564a))
* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([AztecProtocol#4146](AztecProtocol#4146))
([14d39ed](AztecProtocol@14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([AztecProtocol#4117](AztecProtocol#4117))
([cd2f67f](AztecProtocol@cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([AztecProtocol#4116](AztecProtocol#4116))
([7438db3](AztecProtocol@7438db3))
* **docs:** Aztec-up doesnt need `latest`, remove warnings around
sandbox/cli npm pkgs
([AztecProtocol#4138](AztecProtocol#4138))
([2bbf7a9](AztecProtocol@2bbf7a9))
* **docs:** Update js release notes for 0.18.0
([AztecProtocol#4051](AztecProtocol#4051))
([bdbe963](AztecProtocol@bdbe963))
* **docs:** Update lsp install instructions
([AztecProtocol#4110](AztecProtocol#4110))
([3138816](AztecProtocol@3138816)),
closes
[AztecProtocol#4098](AztecProtocol#4098)
* Dont mirror build-system mirror_repos.yml
([AztecProtocol#4067](AztecProtocol#4067))
([04f8e0d](AztecProtocol@04f8e0d))
* Fixes many broken urls
([AztecProtocol#4109](AztecProtocol#4109))
([41ae75c](AztecProtocol@41ae75c))
* Remove dependency cycles in `sequencer-client`
([AztecProtocol#4017](AztecProtocol#4017))
([fe4538b](AztecProtocol@fe4538b))
* Remove lodash times in favor of foundation fn
([AztecProtocol#3877](AztecProtocol#3877))
([a10eef0](AztecProtocol@a10eef0))
* Remove mutex dependency
([AztecProtocol#4160](AztecProtocol#4160))
([3b82be0](AztecProtocol@3b82be0))
* Remove unnecessary computation
([AztecProtocol#4133](AztecProtocol#4133))
([f35bdb8](AztecProtocol@f35bdb8))
* Remove unused noir-version json
([AztecProtocol#4105](AztecProtocol#4105))
([afca819](AztecProtocol@afca819))
* Remove unwanted submodules
([AztecProtocol#4085](AztecProtocol#4085))
([dda7c9c](AztecProtocol@dda7c9c))
* Replace relative paths to noir-protocol-circuits
([59feeb5](AztecProtocol@59feeb5))
* Replace relative paths to noir-protocol-circuits
([44d9136](AztecProtocol@44d9136))
* Replace relative paths to noir-protocol-circuits
([84b0bad](AztecProtocol@84b0bad))
* Simplify and fix DocsExample contract, e2e singleton + codegen to not
show internal methods
([AztecProtocol#4169](AztecProtocol#4169))
([38d262e](AztecProtocol@38d262e))
* Update noir
([AztecProtocol#4168](AztecProtocol#4168))
([d40ad06](AztecProtocol@d40ad06))


### Documentation

* Update migration notes
([AztecProtocol#4175](AztecProtocol#4175))
([dbc8174](AztecProtocol@dbc8174))
* **yellow-paper:** Update circuit sections for nullifier keys and
static calls
([AztecProtocol#4155](AztecProtocol#4155))
([ed71a57](AztecProtocol@ed71a57))
* **yellowpaper:** Refresh of avm instruction set
([AztecProtocol#4081](AztecProtocol#4081))
([52162ee](AztecProtocol@52162ee))
</details>

<details><summary>barretenberg.js: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@barretenberg.js-v0.19.0...barretenberg.js-v0.20.0)
(2024-01-22)


### Features

* Goblin acir composer
([AztecProtocol#4112](AztecProtocol#4112))
([5e85b92](AztecProtocol@5e85b92))
</details>

<details><summary>barretenberg: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@barretenberg-v0.19.0...barretenberg-v0.20.0)
(2024-01-22)


### Features

* Benchmark commit function
([AztecProtocol#4178](AztecProtocol#4178))
([ea84085](AztecProtocol@ea84085))
* Goblin acir composer
([AztecProtocol#4112](AztecProtocol#4112))
([5e85b92](AztecProtocol@5e85b92))


### Bug Fixes

* Make CMake version warning fatal
([AztecProtocol#4144](AztecProtocol#4144))
([b1443fa](AztecProtocol@b1443fa))
* Reinstate Ultra arith rec verifier test
([AztecProtocol#3886](AztecProtocol#3886))
([995973b](AztecProtocol@995973b))
* Upload_benchmarks_to_s3.sh missing exit
([AztecProtocol#4046](AztecProtocol#4046))
([52a9327](AztecProtocol@52a9327))


### Miscellaneous

* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([AztecProtocol#4146](AztecProtocol#4146))
([14d39ed](AztecProtocol@14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([AztecProtocol#4117](AztecProtocol#4117))
([cd2f67f](AztecProtocol@cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([AztecProtocol#4116](AztecProtocol#4116))
([7438db3](AztecProtocol@7438db3))
* Remove mutex dependency
([AztecProtocol#4160](AztecProtocol#4160))
([3b82be0](AztecProtocol@3b82be0))
* Remove unwanted submodules
([AztecProtocol#4085](AztecProtocol#4085))
([dda7c9c](AztecProtocol@dda7c9c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirasistant sirasistant sirasistant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeilaWang @AztecBot @sirasistant