Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: post-merge aztec3-temporary #432

Merged
merged 8 commits into from
May 4, 2023
Merged

fix: post-merge aztec3-temporary #432

merged 8 commits into from
May 4, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented May 2, 2023

Description

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

ludamad
ludamad commented May 3, 2023
View reviewed changes
yarn-project/circuits.js/src/structs/kernel/__snapshots__/index.test.ts.snap
@@ -1,5 +1,147 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`structs/kernel serializes and prints CombinedAccumulatedData 1`] = `
"aggregation_object:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new test

ludamad
ludamad commented May 3, 2023
View reviewed changes
yarn-project/circuits.js/src/structs/kernel/__snapshots__/index.test.ts.snap
@@ -171,7 +313,7 @@ portal_contract_address: 0x404040404040404040404040404040404040404

chain_id: 0x501

signature: { 0101010101010101010101010101010101010101010101010101010101010101, 0202020202020202020202020202020202020202020202020202020202020202 }
signature: { 0101010101010101010101010101010101010101010101010101010101010101, 0202020202020202020202020202020202020202020202020202020202020202, 3 }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new field

dbanks12
dbanks12 approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once bberg PR is merged

@dbanks12 dbanks12 mentioned this pull request May 3, 2023
Merged
15 tasks
@dbanks12
Copy link
Contributor

dbanks12 commented May 4, 2023

Will merge when CI is done

@dbanks12 dbanks12 merged commit 1081179 into master May 4, 2023
@dbanks12 dbanks12 deleted the ad/close-bb-master-gap branch May 4, 2023 14:08
ludamad pushed a commit that referenced this pull request Jul 14, 2023
@maramihali
ensure all operand sizes are tested (#432)
f07c50f 
Co-authored-by: maramihali <mara@aztecprotocol.com>
This was referenced Jul 25, 2023
Closed
Closed
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@maramihali
ensure all operand sizes are tested (#432)
ad615ee 
Co-authored-by: maramihali <mara@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludamad @dbanks12