Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upadate migration note #4566

Merged
merged 1 commit into from
Feb 13, 2024
Merged

chore: upadate migration note #4566

merged 1 commit into from
Feb 13, 2024

Conversation

rahul-kothari
Copy link
Contributor

No description provided.

@rahul-kothari rahul-kothari enabled auto-merge (squash) February 13, 2024 11:07
@rahul-kothari rahul-kothari changed the title upadate migration note chore: upadate migration note Feb 13, 2024
@rahul-kothari rahul-kothari merged commit 3562f6d into master Feb 13, 2024
83 of 86 checks passed
@rahul-kothari rahul-kothari deleted the rk/docs branch February 13, 2024 11:26
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (8): 310 (-28%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9dc05bc3 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,956 181,604 724,196
l1_rollup_calldata_gas 227,252 888,776 3,535,676
l1_rollup_execution_gas 320,443 1,007,224 3,756,054
l2_block_processing_time_in_ms 1,200 (+1%) 4,708 (+5%) 17,627
note_successful_decrypting_time_in_ms ⚠️ 310 (-28%) 1,005 (+3%) 3,598
note_trial_decrypting_time_in_ms 21.5 (-48%) 42.8 (-59%) 170 (-1%)
l2_block_building_time_in_ms 18,227 71,772 288,657
l2_block_rollup_simulation_time_in_ms 13,544 53,310 214,730
l2_block_public_tx_process_time_in_ms 4,649 (-1%) 18,382 (-1%) 73,669

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,749 (+9%) 29,467 (+5%)
note_history_successful_decrypting_time_in_ms 2,463 (+1%) 5,024 (+7%)
note_history_trial_decrypting_time_in_ms 114 (+12%) 209 (+27%)
node_database_size_in_bytes 17,342,544 33,210,448
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 327 44,528 25,313
private-kernel-ordering 197 (+1%) 43,633 16,193
base-rollup 1,458 129,774 933
root-rollup 83.2 (-2%) 4,192 729
private-kernel-inner 437 70,819 25,313
public-kernel-private-input 239 33,663 26,945
public-kernel-non-first-iteration 239 33,705 26,945
merge-rollup 7.93 (-1%) 2,712 933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.3 10.8 (+1%) 12.8 (+1%) 17.1 (+1%) 22.8 (-2%) 63.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.594 0.597 (+1%) 0.541 0.525 0.477 (-1%) 0.440 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 75.3 (+1%) 47.7 239 465 (+1%) 898 (-1%) 3,545
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.464 (+1%) 0.488 0.436 0.433 (+1%) 0.428 (-1%) 0.426
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 105 56.8 350 (-1%) 697 (+1%) 1,362 5,415
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.493 0.495 0.475 0.475 (+1%) 0.473 0.470
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 57.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.578 N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 16,859 39,794

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 554 (-3%) 1,451 (+1%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 0.516 (+1%) 575 (+1%)

michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants