refactor: interaction for a mock first circuit handled inside the `EccOpQueue` #4854

maramihali · 2024-02-29T12:38:33Z

Because of issues with handling zero-commitments, we need to populate the EccOpQueue with some mock ops from a first circuit in order for the first merge prover to work without problems. This was done client-side which required manually calling either GoblinMockCircuits::perform_op_queue_interactions_for_mock_first_circuit or op_queue->populate_with_mock_initital_data (two functions for the same purpose) everywhere goblin and the merge protocol is used/tested. This PR ensures only GoblinMockCircuits::perform_op_queue_interactions_for_mock_first_circuit is used across the codebase since it's the one updating both ultra_ops and raw_ops, removing the other function, and isolates mocking inside the Goblin class so it doesn't have to be done in benchmarks.

Note: tried to isolate it inside EccOpQueue, which is possible but then requires us to have an op_offset (from which non-mocked operations start) which complicates some code and tests unnecessarily.

maramihali · 2024-02-29T12:41:21Z

barretenberg/cpp/src/barretenberg/proof_system/op_queue/ecc_op_queue.hpp

-     *
-     * @param op_queue
-     */
-    void populate_with_mock_initital_data()


moved this at the end of the file as a private function

maramihali · 2024-02-29T15:40:15Z

barretenberg/cpp/src/barretenberg/proof_system/op_queue/ecc_op_queue.hpp

@@ -120,11 +129,7 @@ class ECCOpQueue {
    [[nodiscard]] size_t get_previous_size() const { return previous_ultra_ops_size; }
    [[nodiscard]] size_t get_current_size() const { return current_ultra_ops_size; }

-    void set_commitment_data(std::array<Point, 4>& commitments)
-    {
-        previous_ultra_ops_commitments = ultra_ops_commitments;


nothing actually uses previous_ultra_ops_commitments (the merge prover considers C_T_prev to be ultra_ops_commitments) so removed the field

ledwards2225

I may be missing something but I expected that the mocked ops would need to be valid in order for the ECCVM to fail. The fact that this isn't causing any problems is concerning. What am I missing?

ledwards2225 · 2024-02-29T16:03:25Z

barretenberg/cpp/src/barretenberg/proof_system/op_queue/ecc_op_queue.hpp

@@ -120,11 +129,7 @@ class ECCOpQueue {
    [[nodiscard]] size_t get_previous_size() const { return previous_ultra_ops_size; }
    [[nodiscard]] size_t get_current_size() const { return current_ultra_ops_size; }

-    void set_commitment_data(std::array<Point, 4>& commitments)
-    {
-        previous_ultra_ops_commitments = ultra_ops_commitments;


barretenberg/cpp/src/barretenberg/proof_system/op_queue/ecc_op_queue.hpp

AztecBot · 2024-03-08T19:03:57Z

Benchmark results

Metrics with a significant change:

note_trial_decrypting_time_in_ms (32): 98.1 (+110%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 58e15edf and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,820	36,356
l1_rollup_calldata_gas	66,040	238,360	468,716
l1_rollup_execution_gas	666,672	953,221	1,336,024
l2_block_processing_time_in_ms	1,268 (-3%)	4,694 (-3%)	9,183 (+2%)
note_successful_decrypting_time_in_ms	134 (-4%)	482 (-10%)	940 (-2%)
note_trial_decrypting_time_in_ms	40.0 (-9%)	⚠️ 98.1 (+110%)	73.1 (-17%)
l2_block_building_time_in_ms	16,901 (-1%)	67,313 (-1%)	134,689
l2_block_rollup_simulation_time_in_ms	6,955 (-2%)	27,813 (-1%)	55,811
l2_block_public_tx_process_time_in_ms	9,919 (-1%)	39,444 (-1%)	78,778

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,491 (-3%)	26,417 (+1%)
note_history_successful_decrypting_time_in_ms	1,195 (+1%)	2,494 (+4%)
note_history_trial_decrypting_time_in_ms	67.7 (+1%)	152 (+25%)
node_database_size_in_bytes	19,046,480	35,635,280
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	278	44,338	27,700
private-kernel-ordering	217	52,324	14,326
base-rollup	632	177,083	925
root-rollup	68.0 (-1%)	4,176	789
private-kernel-inner	633	73,197	27,700
public-kernel-app-logic	439	35,198	28,215
public-kernel-tail	177	40,926	28,215
merge-rollup	8.29	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.94 (-1%)	15.9	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.580 (-1%)	0.492	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.7	71.8 (-1%)	229	442	863 (-1%)	1,713	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.469	0.444 (-1%)	0.418	0.414	0.411	0.411	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.7	106	333	656	1,304 (-1%)	2,600 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.478	0.478 (-1%)	0.454	0.453	0.452 (-1%)	0.453	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.1
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.535

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,014

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,964	1,731

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	11.0 (-15%)	1,229

…in benchmarks; make it unique function

maramihali · 2024-03-11T12:16:03Z

barretenberg/cpp/src/barretenberg/goblin/mock_circuits.hpp

    using VerifierInstance = bb::VerifierInstance_<Flavor>;
    using RecursiveVerifierInstance = ::bb::stdlib::recursion::honk::RecursiveVerifierInstance_<RecursiveFlavor>;
    using RecursiveVerifierAccumulator = std::shared_ptr<RecursiveVerifierInstance>;
    using VerificationKey = Flavor::VerificationKey;
    static constexpr size_t NUM_OP_QUEUE_COLUMNS = Flavor::NUM_WIRES;

+    struct KernelInput {


To mock inside Goblin I had to break the dependency between MockCircuits and Goblin (to avoid a circular dependency)

maramihali · 2024-03-11T14:30:28Z

barretenberg/cpp/src/barretenberg/bb/main.cpp

@@ -140,6 +140,13 @@ bool proveAndVerify(const std::string& bytecodePath, const std::string& witnessP
 */
 bool accumulateAndVerifyGoblin(const std::string& bytecodePath, const std::string& witnessPath)
 {
+    // TODO(https://github.com/AztecProtocol/barretenberg/issues/811): Don't hardcode dyadic circuit size. Currently set


GoblinAcirComposer initialises Goblin which calls the perform_op_queue_interactions_for_mock_first_circuit function so the crs needs to be initalised prior to this. Not sure if there's a better way to achieve this

ledwards2225

LGTM. Just a couple of small comments/requests

ledwards2225 · 2024-03-12T17:05:35Z

barretenberg/cpp/src/barretenberg/client_ivc/client_ivc.cpp

-    goblin.merge_proof_exists = false;
-    GoblinMockCircuits::perform_op_queue_interactions_for_mock_first_circuit(goblin.op_queue);
+    // Clean the Goblin state (reinitialise op_queue with mocking and clear merge proofs)
+    goblin = Goblin();


This seems a bit weird to me. I know it's not being introduced in this PR but is there some reason why we don't simply instantiate a new goblin instance for use within the scope of this function?

added to do to aim to move vk precomputaion out of client ivc

ledwards2225 · 2024-03-12T17:12:13Z

barretenberg/cpp/src/barretenberg/goblin/goblin.hpp

@@ -88,6 +89,7 @@ class Goblin {
    AccumulationOutput accumulator; // Used only for ACIR methods for now

  public:
+    Goblin() { GoblinMockCircuits::perform_op_queue_interactions_for_mock_first_circuit(op_queue); }


Can you add the appropriate TODO with issue here?

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.2</summary> ## [0.27.2](aztec-package-v0.27.1...aztec-package-v0.27.2) (2024-03-13) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.27.2</summary> ## [0.27.2](barretenberg.js-v0.27.1...barretenberg.js-v0.27.2) (2024-03-13) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.27.2</summary> ## [0.27.2](aztec-cli-v0.27.1...aztec-cli-v0.27.2) (2024-03-13) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.27.2</summary> ## [0.27.2](aztec-packages-v0.27.1...aztec-packages-v0.27.2) (2024-03-13) ### Features * Check initialization arguments in constructors ([#5144](#5144)) ([d003bd6](d003bd6)) * Multithreaded prover folding ([#5147](#5147)) ([94922fc](94922fc)) * Run tests in parallel in `nargo test` (noir-lang/noir#4484) ([58e15ed](58e15ed)) * Track stack frames and their variables in the debugger (noir-lang/noir#4188) ([58e15ed](58e15ed)) ### Bug Fixes * **acir_gen:** More granular element sizes array check (noir-lang/noir#4528) ([58e15ed](58e15ed)) * Add `follow_bindings` to follow `Type::Alias` links (noir-lang/noir#4521) ([58e15ed](58e15ed)) * Allow type aliases in main (noir-lang/noir#4505) ([58e15ed](58e15ed)) * Constant gen ([#5172](#5172)) ([394a0e0](394a0e0)) * **docs:** Update quickstart.md ([#5021](#5021)) ([be9f8a1](be9f8a1)) * Dynamic assert messages in brillig (noir-lang/noir#4531) ([58e15ed](58e15ed)) * Fix brillig slowdown when assigning arrays in loops (noir-lang/noir#4472) ([58e15ed](58e15ed)) * Fix deployments ([#5183](#5183)) ([596253b](596253b)) * Force src impl for == on slices (noir-lang/noir#4507) ([58e15ed](58e15ed)) * Handling of gh deps in noir_wasm (noir-lang/noir#4499) ([58e15ed](58e15ed)) * Intermittent invert 0 in Goblin ([#5174](#5174)) ([3e68b49](3e68b49)) * Iterative flattening pass (noir-lang/noir#4492) ([58e15ed](58e15ed)) * Noir mirror merge strat ([#5166](#5166)) ([74fa8d6](74fa8d6)) * **ssa:** Handle mergers of slices returned from calls (noir-lang/noir#4496) ([58e15ed](58e15ed)) ### Miscellaneous * Add `ModuleDeclaration` struct (noir-lang/noir#4512) ([58e15ed](58e15ed)) * Add HashMap docs (noir-lang/noir#4457) ([58e15ed](58e15ed)) * Add regression test for issue 4449 (noir-lang/noir#4503) ([58e15ed](58e15ed)) * Better output in ci_deploy_contracts.sh ([#5171](#5171)) ([8d73f8a](8d73f8a)) * Bump bb to 0.26.3 (noir-lang/noir#4488) ([58e15ed](58e15ed)) * **ci:** Fix JS publishing workflow checking out inconsistent commits (noir-lang/noir#4493) ([58e15ed](58e15ed)) * Custom hash for eddsa (noir-lang/noir#4440) ([58e15ed](58e15ed)) * Deterministic mode ([#5155](#5155)) ([e68b56a](e68b56a)) * Document big integers (noir-lang/noir#4487) ([58e15ed](58e15ed)) * Generalise `FunctionVisibility` to `ItemVisibility` (noir-lang/noir#4495) ([58e15ed](58e15ed)) * Interaction for a mock first circuit handled inside the `EccOpQueue` ([#4854](#4854)) ([d9cbdc8](d9cbdc8)) * Move `check_method_signatures` to type checking phase (noir-lang/noir#4516) ([58e15ed](58e15ed)) * Move templated code for assert_message into the stdlib (noir-lang/noir#4475) ([58e15ed](58e15ed)) * Organize the `blackbox_solver` crate (noir-lang/noir#4519) ([58e15ed](58e15ed)) * Pass `import_directive` by reference (noir-lang/noir#4511) ([58e15ed](58e15ed)) * Pass macro processors by reference (noir-lang/noir#4501) ([58e15ed](58e15ed)) * Pull out separate function for compiling and running a test ([58e15ed](58e15ed)) * Release Noir(0.25.0) (noir-lang/noir#4352) ([58e15ed](58e15ed)) * Update cargo deny config (noir-lang/noir#4486) ([58e15ed](58e15ed)) * Update various dependencies (noir-lang/noir#4513) ([58e15ed](58e15ed)) </details> <details><summary>barretenberg: 0.27.2</summary> ## [0.27.2](barretenberg-v0.27.1...barretenberg-v0.27.2) (2024-03-13) ### Features * Multithreaded prover folding ([#5147](#5147)) ([94922fc](94922fc)) ### Bug Fixes * Intermittent invert 0 in Goblin ([#5174](#5174)) ([3e68b49](3e68b49)) ### Miscellaneous * Interaction for a mock first circuit handled inside the `EccOpQueue` ([#4854](#4854)) ([d9cbdc8](d9cbdc8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@aztec-package-v0.27.1...aztec-package-v0.27.2) (2024-03-13) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@barretenberg.js-v0.27.1...barretenberg.js-v0.27.2) (2024-03-13) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@aztec-cli-v0.27.1...aztec-cli-v0.27.2) (2024-03-13) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@aztec-packages-v0.27.1...aztec-packages-v0.27.2) (2024-03-13) ### Features * Check initialization arguments in constructors ([#5144](AztecProtocol/aztec-packages#5144)) ([d003bd6](AztecProtocol/aztec-packages@d003bd6)) * Multithreaded prover folding ([#5147](AztecProtocol/aztec-packages#5147)) ([94922fc](AztecProtocol/aztec-packages@94922fc)) * Run tests in parallel in `nargo test` (noir-lang/noir#4484) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Track stack frames and their variables in the debugger (noir-lang/noir#4188) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) ### Bug Fixes * **acir_gen:** More granular element sizes array check (noir-lang/noir#4528) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Add `follow_bindings` to follow `Type::Alias` links (noir-lang/noir#4521) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Allow type aliases in main (noir-lang/noir#4505) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Constant gen ([#5172](AztecProtocol/aztec-packages#5172)) ([394a0e0](AztecProtocol/aztec-packages@394a0e0)) * **docs:** Update quickstart.md ([#5021](AztecProtocol/aztec-packages#5021)) ([be9f8a1](AztecProtocol/aztec-packages@be9f8a1)) * Dynamic assert messages in brillig (noir-lang/noir#4531) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Fix brillig slowdown when assigning arrays in loops (noir-lang/noir#4472) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Fix deployments ([#5183](AztecProtocol/aztec-packages#5183)) ([596253b](AztecProtocol/aztec-packages@596253b)) * Force src impl for == on slices (noir-lang/noir#4507) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Handling of gh deps in noir_wasm (noir-lang/noir#4499) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Intermittent invert 0 in Goblin ([#5174](AztecProtocol/aztec-packages#5174)) ([3e68b49](AztecProtocol/aztec-packages@3e68b49)) * Iterative flattening pass (noir-lang/noir#4492) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Noir mirror merge strat ([#5166](AztecProtocol/aztec-packages#5166)) ([74fa8d6](AztecProtocol/aztec-packages@74fa8d6)) * **ssa:** Handle mergers of slices returned from calls (noir-lang/noir#4496) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) ### Miscellaneous * Add `ModuleDeclaration` struct (noir-lang/noir#4512) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Add HashMap docs (noir-lang/noir#4457) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Add regression test for issue 4449 (noir-lang/noir#4503) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Better output in ci_deploy_contracts.sh ([#5171](AztecProtocol/aztec-packages#5171)) ([8d73f8a](AztecProtocol/aztec-packages@8d73f8a)) * Bump bb to 0.26.3 (noir-lang/noir#4488) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * **ci:** Fix JS publishing workflow checking out inconsistent commits (noir-lang/noir#4493) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Custom hash for eddsa (noir-lang/noir#4440) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Deterministic mode ([#5155](AztecProtocol/aztec-packages#5155)) ([e68b56a](AztecProtocol/aztec-packages@e68b56a)) * Document big integers (noir-lang/noir#4487) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Generalise `FunctionVisibility` to `ItemVisibility` (noir-lang/noir#4495) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Interaction for a mock first circuit handled inside the `EccOpQueue` ([#4854](AztecProtocol/aztec-packages#4854)) ([d9cbdc8](AztecProtocol/aztec-packages@d9cbdc8)) * Move `check_method_signatures` to type checking phase (noir-lang/noir#4516) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Move templated code for assert_message into the stdlib (noir-lang/noir#4475) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Organize the `blackbox_solver` crate (noir-lang/noir#4519) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Pass `import_directive` by reference (noir-lang/noir#4511) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Pass macro processors by reference (noir-lang/noir#4501) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Pull out separate function for compiling and running a test ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Release Noir(0.25.0) (noir-lang/noir#4352) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Update cargo deny config (noir-lang/noir#4486) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Update various dependencies (noir-lang/noir#4513) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) </details> <details><summary>barretenberg: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@barretenberg-v0.27.1...barretenberg-v0.27.2) (2024-03-13) ### Features * Multithreaded prover folding ([#5147](AztecProtocol/aztec-packages#5147)) ([94922fc](AztecProtocol/aztec-packages@94922fc)) ### Bug Fixes * Intermittent invert 0 in Goblin ([#5174](AztecProtocol/aztec-packages#5174)) ([3e68b49](AztecProtocol/aztec-packages@3e68b49)) ### Miscellaneous * Interaction for a mock first circuit handled inside the `EccOpQueue` ([#4854](AztecProtocol/aztec-packages#4854)) ([d9cbdc8](AztecProtocol/aztec-packages@d9cbdc8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

PR #4854 removed the mocking function from the `EccOpQueue` `populate_with_mock_initital_data` which was stale and only populating the `ultra_ops` rather than both `raw_ops` and `ultra_ops` and ensured mocking (required to avoid commitments to 0) is done everywhere with a single function `GoblinMockCircuits::perform_op_queue_interactions_for_mock_first_circuit(op_queue);`. A mis-merge reintroduced `populate_with_mock_initital_data` so removing again.

maramihali self-assigned this Feb 29, 2024

maramihali added the crypto cryptography label Feb 29, 2024

maramihali commented Feb 29, 2024

View reviewed changes

maramihali changed the title ~~refactor: interaction for a mock first circuit handled inside the ECCOPQueue~~ refactor: interaction for a mock first circuit handled inside the EccOpQueue Feb 29, 2024

maramihali marked this pull request as ready for review February 29, 2024 13:10

maramihali requested a review from ledwards2225 February 29, 2024 13:10

maramihali commented Feb 29, 2024

View reviewed changes

ledwards2225 requested changes Feb 29, 2024

View reviewed changes

maramihali requested a review from ledwards2225 March 8, 2024 18:39

maramihali added 2 commits March 11, 2024 11:34

rework code so goblin is not used in mock_circuits

9d67a9a

ensure first op queue mocking is internal to the Goblin and not done …

82b6428

…in benchmarks; make it unique function

maramihali force-pushed the mm/initial-merge branch from 2f52efa to 82b6428 Compare March 11, 2024 12:10

maramihali commented Mar 11, 2024

View reviewed changes

maramihali added 4 commits March 11, 2024 12:19

remove unnecessary include

5371b60

fix acir tests?

8191d2d

hm

1e3e447

initalise crs at the correct time?

2adaa14

maramihali commented Mar 11, 2024

View reviewed changes

ledwards2225 approved these changes Mar 12, 2024

View reviewed changes

maramihali added 2 commits March 12, 2024 19:30

Merge remote-tracking branch 'origin/master' into mm/initial-merge

b799a50

add todo comment with issue

d96ef57

maramihali force-pushed the mm/initial-merge branch from 18a6090 to d96ef57 Compare March 12, 2024 19:47

maramihali enabled auto-merge (squash) March 12, 2024 19:48

maramihali merged commit d9cbdc8 into master Mar 12, 2024
94 of 95 checks passed

maramihali deleted the mm/initial-merge branch March 12, 2024 20:15

AztecBot mentioned this pull request Mar 12, 2024

chore(master): Release 0.27.2 #5170

Merged

maramihali mentioned this pull request Mar 23, 2024

chore: Remove mocking function in EccOpQueue again #5413

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: interaction for a mock first circuit handled inside the `EccOpQueue` #4854

refactor: interaction for a mock first circuit handled inside the `EccOpQueue` #4854

maramihali commented Feb 29, 2024 •

edited

Loading

maramihali Feb 29, 2024

maramihali Feb 29, 2024

ledwards2225 Feb 29, 2024

ledwards2225 left a comment

ledwards2225 Feb 29, 2024

AztecBot commented Mar 8, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

maramihali Mar 11, 2024

maramihali Mar 11, 2024

ledwards2225 left a comment

ledwards2225 Mar 12, 2024

maramihali Mar 12, 2024

ledwards2225 Mar 12, 2024

refactor: interaction for a mock first circuit handled inside the EccOpQueue #4854

refactor: interaction for a mock first circuit handled inside the EccOpQueue #4854

Conversation

maramihali commented Feb 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ledwards2225 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AztecBot commented Mar 8, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ledwards2225 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refactor: interaction for a mock first circuit handled inside the `EccOpQueue` #4854

refactor: interaction for a mock first circuit handled inside the `EccOpQueue` #4854

maramihali commented Feb 29, 2024 •

edited

Loading

AztecBot commented Mar 8, 2024 •

edited

Loading