chore(avm-simulator): formatting and fixes

[fcarreiro]

• Logging
• Call and StaticCall were returning Field while per YP should be Uint8.
• I'm also moving the RETURN and REVERT opcodes to external_calls.ts (from control_flow.ts).

Relates to #4313, #4127.

[fcarreiro]

• feat(avm-simulator): individual storage access #5095
• feat(avm-simulator): external static calls + integration #5089
• chore(avm-simulator): enable compressed strings unencrypted log test #5083
• feat(avm-simulator): external calls + integration #5051
• chore(avm-simulator): formatting and fixes #5092 👈
• feat(avm): fix some Brillig problems #5091
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• circuit_simulation_time_in_ms (private-kernel-inner): 366 (+16%)
• note_successful_decrypting_time_in_ms (8): 231 (+70%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 8b106001 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,564	239,360	469,388
l1_rollup_execution_gas	674,027	980,181	1,388,162
l2_block_processing_time_in_ms	1,343 (+1%)	4,857	9,301 (+5%)
note_successful_decrypting_time_in_ms	⚠️ 231 (+70%)	496 (+3%)	937 (-1%)
note_trial_decrypting_time_in_ms	37.0 (-9%)	117 (+21%)	66.1 (-15%)
l2_block_building_time_in_ms	12,774 (+5%)	50,538 (+6%)	100,188 (+6%)
l2_block_rollup_simulation_time_in_ms	7,569 (+1%)	30,058 (+2%)	59,636 (+2%)
l2_block_public_tx_process_time_in_ms	5,174 (+10%)	20,416 (+12%)	40,405 (+11%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,096 (+1%)	26,978 (+2%)
note_history_successful_decrypting_time_in_ms	1,281	2,418 (+1%)
note_history_trial_decrypting_time_in_ms	110 (+10%)	139 (-4%)
node_database_size_in_bytes	18,845,776	35,385,424
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	283 (+13%)	44,736	28,001
private-kernel-ordering	210 (+8%)	52,625	14,627
base-rollup	682 (+4%)	177,932	997
root-rollup	68.8 (+1%)	4,320	825
private-kernel-inner	⚠️ 366 (+16%)	73,715	28,001
public-kernel-app-logic	188 (+16%)	34,920	27,972
public-kernel-tail	92.4 (+14%)	34,507	27,972
merge-rollup	8.52 (+2%)	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.80 (+1%)	10.5 (+4%)	12.2 (-1%)	16.1 (+1%)	22.5 (+1%)	35.3 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.569 (+1%)	0.584 (+4%)	0.518	0.498 (+1%)	0.469 (+1%)	0.441 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	46.0 (+2%)	71.9 (-1%)	230	443 (+2%)	879	1,725 (+3%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.472 (+2%)	0.444	0.421	0.415 (+2%)	0.418	0.414 (+3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	53.7 (-1%)	107 (+1%)	337	658 (+2%)	1,318 (+1%)	2,595 (+3%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.479 (-1%)	0.482 (+1%)	0.457	0.453 (+2%)	0.456	0.452 (+3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	60.9 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.533 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,650

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,967 (+9%)	1,475 (+8%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	7.77	635 (+12%)

[Maddiaa0]

Very nice spring cleaning! Some notes

[fcarreiro]

Merge activity

• Mar 11, 6:44 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 11, 6:50 AM EDT: @fcarreiro merged this pull request with Graphite.