feat: remove unnecessary mulmods from verifier contract

[TomAFrench]

We're currently calculating xx and then immediately dropping it again without using it. This PR removes these and just collapses the mload and mstore into the same line.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 4d04a7e8 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,820	36,356
l1_rollup_calldata_gas	66,352	239,164	468,848
l1_rollup_execution_gas	659,675	941,748	1,317,255
l2_block_processing_time_in_ms	1,270 (-3%)	4,817	9,022
note_successful_decrypting_time_in_ms	190 (+8%)	508 (-2%)	1,017 (+4%)
note_trial_decrypting_time_in_ms	95.0 (+21%)	23.3 (-34%)	45.8 (-58%)
l2_block_building_time_in_ms	18,164	68,534	136,011
l2_block_rollup_simulation_time_in_ms	8,182	28,847	56,779 (+1%)
l2_block_public_tx_process_time_in_ms	9,959	39,630	79,130

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,400	27,266
note_history_successful_decrypting_time_in_ms	1,275 (+4%)	2,497 (+3%)
note_history_trial_decrypting_time_in_ms	102 (+68%)	185 (+29%)
node_database_size_in_bytes	19,087,440	35,840,080
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	278 (+1%)	44,366	28,244
private-kernel-ordering	215	52,868	14,326
base-parity	1,825 (+1%)	128	311
base-rollup	725 (+1%)	165,787	925
root-parity	1,637 (+6%)	1,244	311
root-rollup	68.9 (+1%)	4,487	789
private-kernel-inner	643	73,771	28,244
public-kernel-app-logic	444	35,260	28,215
public-kernel-tail	172 (+1%)	40,926	28,215
merge-rollup	8.29 (+1%)	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0 (+1%)	16.0	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.583	0.495	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.1 (+1%)	72.3	231	443 (+1%)	878 (-1%)	1,736	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.473 (+1%)	0.445	0.421	0.414 (+1%)	0.416 (-1%)	0.415	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.7	107 (+1%)	335 (-1%)	659 (+1%)	1,326 (-1%)	2,632 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.487	0.485 (+1%)	0.457 (-1%)	0.454 (+1%)	0.458 (-1%)	0.458	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.1 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.534 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,012

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,255 (-1%)	1,746 (+1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	10.9 (-4%)	1,238 (+1%)

[TomAFrench]

CI failure seems to be unrelated.