Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove mocking function in EccOpQueue again #5413

Merged
merged 2 commits into from
Mar 24, 2024
Merged

chore: Remove mocking function in EccOpQueue again #5413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6223f6
remove mocking function in ecc_op_queue because it's no longer used
maramihali Mar 23, 2024
6741d6b
Merge branch 'master' into mm/remove-mock-func
maramihali Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions barretenberg/cpp/src/barretenberg/proof_system/op_queue/ecc_op_queue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,30 +208,6 @@ class ECCOpQueue {
return result;
}

/**
* @brief TESTING PURPOSES ONLY: Populate ECC op queue with mock data as stand in for "previous circuit" in tests
* @details TODO(#723): We currently cannot support Goblin proofs (specifically, transcript aggregation) if there
* is not existing data in the ECC op queue (since this leads to zero-commitment issues). This method populates the
* op queue with mock data so that the prover of an arbitrary 'first' circuit can behave as if it were not the
* prover over the first circuit in the stack. This method should be removed entirely once this is resolved.
*
* @param op_queue
*/
void populate_with_mock_initital_data()
{
// Add a single row of data to the op queue and commit to each column as [1] * FF(data)
std::array<Point, 4> mock_op_queue_commitments;
for (size_t idx = 0; idx < 4; idx++) {
auto mock_data = Fr::random_element();
this->ultra_ops[idx].emplace_back(mock_data);
mock_op_queue_commitments[idx] = Point::one() * mock_data;
}
// Set some internal data based on the size of the op queue data
this->set_size_data();
// Add the commitments to the op queue data for use by the next circuit
this->set_commitment_data(mock_op_queue_commitments);
}

/**
* @brief Get the number of rows in the 'msm' column section o the ECCVM, associated with a single multiscalar mul
*
Expand Down
Loading