refactor: pad when needed and not sooner

[benesjan]

Fixes #5357

[benesjan]

• refactor: pad when needed and not sooner #5482 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[benesjan]

This was all outdated so I sneaked the fix in.

[benesjan]

Added the helper here because I needed the computeNumTxEffectsToPad here to correctly pad l2 to l1 messages.

[benesjan]

Had to do this change because txLogs.length now does not contain logs of padding txs and for this reason the original formula stopped working. Anyway I think it's more understandable now.

[AztecBot]

Benchmark results

Metrics with a significant change:

• batch_insert_into_append_only_tree_32_depth_ms (2048): 877 (-34%)
• batch_insert_into_append_only_tree_32_depth_hash_ms (2048): 0.416 (-34%)
• batch_insert_into_indexed_tree_20_depth_ms (2048): 1,311 (-29%)
• l2_block_processing_time_in_ms (32): 4,796 (-17%)
• note_successful_decrypting_time_in_ms (32): 615 (+19%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 02524e13 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,412	6,412
l1_rollup_execution_gas	585,745	585,745	585,745
l2_block_processing_time_in_ms	1,299 (-6%)	⚠️ 4,796 (-17%)	8,986 (+1%)
note_successful_decrypting_time_in_ms	264 (-1%)	⚠️ 615 (+19%)	981 (-3%)
note_trial_decrypting_time_in_ms	67.7 (-5%)	24.4 (-27%)	98.3 (-24%)
l2_block_building_time_in_ms	12,303 (+5%)	44,805 (+5%)	89,800 (+5%)
l2_block_rollup_simulation_time_in_ms	7,532 (+5%)	26,102 (+5%)	51,691 (+3%)
l2_block_public_tx_process_time_in_ms	4,748 (+5%)	18,651 (+5%)	38,006 (+6%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,546 (+4%)	27,712 (+7%)
note_history_successful_decrypting_time_in_ms	1,297 (+6%)	2,504 (+4%)
note_history_trial_decrypting_time_in_ms	66.7 (+11%)	115 (-13%)
node_database_size_in_bytes	18,653,264	35,143,760
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	184 (+3%)	44,379	28,214
private-kernel-ordering	171 (+4%)	52,880	14,296
base-parity	3,578 (+1%)	128	311
root-parity	1,311 (+7%)	1,244	311
base-rollup	15,106 (+5%)	165,760	861
root-rollup	49.6 (+2%)	4,359	725
private-kernel-inner	229 (+4%)	73,795	28,214
public-kernel-app-logic	96.1 (+3%)	35,252	28,217
public-kernel-tail	139 (+3%)	40,928	28,217
merge-rollup	9.05 (+13%)	2,568	861
public-kernel-teardown	92.3 (-2%)	35,252	28,217
public-kernel-setup	91.0	35,252	28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2 (+2%)	16.2 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.589 (+1%)	0.498	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.1 (+2%)	72.2 (-6%)	235 (-15%)	455 (+6%)	⚠️ 877 (-34%)	1,733 (+2%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.482 (+1%)	0.445 (-6%)	0.426 (-15%)	0.424 (+5%)	⚠️ 0.416 (-34%)	0.413 (+2%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	55.1 (+5%)	107 (-4%)	338 (-10%)	677 (+6%)	⚠️ 1,311 (-29%)	2,626 (+4%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.485 (+4%)	0.482 (-4%)	0.459 (-10%)	0.465 (+6%)	0.455 (-28%)	0.456 (+4%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.9 (+3%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.538 (+2%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,968	495,320

Transaction size based on fee payment method

Metric	none fee payment method	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	773	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,799 (+2%)	1,216 (+4%)	5,680 (+1%)

Metric	0 public data writes	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	10.3 (-5%)	587 (+4%)	438 (-2%)	1,176 (+1%)	602 (+3%)	2,040 (+1%)	565 (+1%)

[benesjan]

Body is now even smaller because empty tx effects are not included. We could shrink this value even more because we will probably never need 4 bytes for num tx effects but that's not so important now.

[sklppy88]

Looks great ! Some tiny nits, but nothing blocking. Feel free to address if nits make sense to you.