refactor: inject fetcher instead of using global

[alexghr]

This PR refactors the GithubDependencyResolver to take a fetch implementation instead of always using the global default

[alexghr]

• refactor: inject fetcher instead of using global #5502 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexghr and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No base data found for comparison.

Detailed results

Except for proving times, all benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

Values are compared against data from master at commit latest and shown if the difference exceeds 1%.

Proving times

Average proving times for benchmarks measured in bb.

Circuit	2^20 gates
ultrahonk_proving_time_in_ms	0.0158

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,388	6,400	6,424
l1_rollup_execution_gas	585,721	585,733	585,757
l2_block_processing_time_in_ms	1,354	4,501	9,427
note_successful_decrypting_time_in_ms	180	567	918
note_trial_decrypting_time_in_ms	86.1	81.7	49.4
l2_block_building_time_in_ms	12,161	44,326	87,911
l2_block_rollup_simulation_time_in_ms	7,429	25,709	50,711
l2_block_public_tx_process_time_in_ms	4,711	18,569	37,103

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,712	26,316
note_history_successful_decrypting_time_in_ms	1,218	2,377
note_history_trial_decrypting_time_in_ms	93.9	117
node_database_size_in_bytes	18,677,840	35,012,688
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	184	44,379	28,214
private-kernel-ordering	170	52,880	14,296
base-parity	3,566	128	311
root-parity	1,273	1,244	311
base-rollup	15,016	165,760	861
root-rollup	49.9	4,359	725
private-kernel-inner	229	73,795	28,214
public-kernel-app-logic	95.9	35,252	28,217
public-kernel-tail	139	40,928	28,217
merge-rollup	8.49	2,568	861
public-kernel-teardown	92.0	35,252	28,217
public-kernel-setup	91.3	35,252	28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1	16.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.585	0.497	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.2	72.7	230	448	875	1,728	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.484	0.449	0.420	0.418	0.416	0.414	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.6	106	340	662	1,304	2,596	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.482	0.480	0.461	0.455	0.452	0.453	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.2
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.534

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,968	495,320

Transaction size based on fee payment method

Metric	none fee payment method	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	773	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,826	1,209	4,503

Metric	0 public data writes	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	9.94	584	446	1,182	491	2,049	567