Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avm): add Header to AvmExecutionEnvironment #5592

Closed
wants to merge 1 commit into from

Conversation

fcarreiro
Copy link
Contributor

@fcarreiro fcarreiro commented Apr 5, 2024

This is not currently used in the AVM-simulator, but it's needed to have interoperability with the ACVM. In any case, we might use it for HEADERMEMBER.

Copy link
Contributor Author

fcarreiro commented Apr 5, 2024

public readonly contractCallDepth: Fr,

public readonly header: Header,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could put it in hostStorage if you prefer.

@fcarreiro fcarreiro requested a review from Maddiaa0 April 5, 2024 15:55
@fcarreiro fcarreiro marked this pull request as ready for review April 5, 2024 15:55
@fcarreiro fcarreiro force-pushed the fc/avm-env-header branch from 9c4eee1 to 46bd9b9 Compare April 5, 2024 16:08
@AztecBot
Copy link
Collaborator

AztecBot commented Apr 5, 2024

Benchmark results

Metrics with a significant change:

  • tx_sequencer_processing_time_ms (2): 437 (-20%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d531b259 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 676 676 676
l1_rollup_calldata_gas 6,388 6,400 6,424
l1_rollup_execution_gas 585,721 585,733 585,757
l2_block_processing_time_in_ms 1,314 (-5%) 5,033 (+6%) 9,706 (+2%)
note_successful_decrypting_time_in_ms 255 (+8%) 613 (-3%) 1,095 (+7%)
note_trial_decrypting_time_in_ms 58.6 (+52%) 24.5 (-41%) 33.0 (-16%)
l2_block_building_time_in_ms 12,078 (+1%) 43,889 (+1%) 86,237 (+1%)
l2_block_rollup_simulation_time_in_ms 7,205 (+1%) 24,740 (+1%) 47,723 (+1%)
l2_block_public_tx_process_time_in_ms 4,831 19,022 (+1%) 38,266 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,689 (+2%) 27,816
note_history_successful_decrypting_time_in_ms 1,337 (+3%) 2,530 (+3%)
note_history_trial_decrypting_time_in_ms 115 (-9%) 118 (+10%)
node_database_size_in_bytes 18,624,592 35,098,704 (+1%)
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 180 44,377 26,164
private-kernel-ordering 163 (+1%) 50,830 39,325
base-parity 4,198 128 311
root-parity 1,235 (+11%) 1,244 311
base-rollup 14,527 (+1%) 116,608 861
root-rollup 49.9 4,359 725
private-kernel-inner 220 (+1%) 71,744 26,164
public-kernel-app-logic 121 (+2%) 47,695 40,661
public-kernel-tail 164 53,372 13,269
merge-rollup 9.67 (-6%) 2,568 861
public-kernel-teardown 117 (-1%) 47,695 40,661
public-kernel-setup 117 (-1%) 47,695 40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.2 (+1%) 16.2 (+1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.589 (+1%) 0.498 (+1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.3 (+1%) 73.1 (+1%) 233 (+1%) 451 (+1%) 887 (+2%) 1,755 (+1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.474 0.449 (+1%) 0.424 (+1%) 0.420 (+1%) 0.419 (+1%) 0.419 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 55.0 (+2%) 109 (+2%) 339 (+1%) 671 (+2%) 1,332 (+2%) 2,649 (+1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.483 (+1%) 0.485 (+1%) 0.457 0.460 (+1%) 0.458 (+1%) 0.459 (+1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 62.0 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.538 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 40,548 501,142

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,718 (+1%) 1,095 (+1%) 5,435 (+1%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 585 (+2%) ⚠️ 437 (-20%) 1,071 (-1%) 525 1,755 593 (+1%)

@fcarreiro fcarreiro removed the request for review from Maddiaa0 April 5, 2024 16:32
@fcarreiro fcarreiro closed this Apr 5, 2024
@fcarreiro fcarreiro deleted the fc/avm-env-header branch April 9, 2024 09:39
@fcarreiro fcarreiro mentioned this pull request May 31, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants