Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: new Accumulator class to clarify PG state #5621

Closed
wants to merge 1 commit into from

Conversation

lucasxia01
Copy link
Contributor

@lucasxia01 lucasxia01 commented Apr 8, 2024

Fixes AztecProtocol/barretenberg#881

Please read contributing guidelines and remove this line.

@AztecBot
Copy link
Collaborator

AztecBot commented Apr 8, 2024

Benchmark results

Metrics with a significant change:

  • circuit_output_size_in_bytes (public-kernel-tail): 13,269 (+86%)
  • l2_block_rollup_simulation_time_in_ms (8): 7,129 (-39%)
  • l2_block_rollup_simulation_time_in_ms (32): 24,439 (-43%)
  • l2_block_rollup_simulation_time_in_ms (64): 47,040 (-44%)
  • l2_block_public_tx_process_time_in_ms (8): 4,739 (-23%)
  • l2_block_public_tx_process_time_in_ms (32): 18,639 (-23%)
  • l2_block_public_tx_process_time_in_ms (64): 37,099 (-24%)
  • note_successful_decrypting_time_in_ms (32): 518 (-17%)
  • note_trial_decrypting_time_in_ms (64): 77.0 (+152%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit a9a349db and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 676 676 676
l1_rollup_calldata_gas 6,424 6,412 6,424
l1_rollup_execution_gas 585,757 585,745 585,757
l2_block_processing_time_in_ms 1,335 (+4%) 4,777 (+1%) 9,467 (+1%)
note_successful_decrypting_time_in_ms 236 ⚠️ 518 (-17%) 958 (-7%)
note_trial_decrypting_time_in_ms 54.1 (+31%) 26.7 (-12%) ⚠️ 77.0 (+152%)
l2_block_building_time_in_ms 11,906 (+1%) 43,203 (+1%) 84,377 (-1%)
l2_block_rollup_simulation_time_in_ms ⚠️ 7,129 (-39%) ⚠️ 24,439 (-43%) ⚠️ 47,040 (-44%)
l2_block_public_tx_process_time_in_ms ⚠️ 4,739 (-23%) ⚠️ 18,639 (-23%) ⚠️ 37,099 (-24%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,771 (+6%) 27,866 (+4%)
note_history_successful_decrypting_time_in_ms 1,276 (-4%) 2,419 (+1%)
note_history_trial_decrypting_time_in_ms 68.4 (-6%) 113 (+13%)
node_database_size_in_bytes 18,612,304 34,807,888 (-1%)
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 181 44,377 26,164
private-kernel-ordering 162 (-1%) 50,830 39,325 (+1%)
base-parity 4,194 (+5%) 128 311
root-parity 1,174 (+12%) 1,244 311
base-rollup 14,406 (+1%) 116,608 (+6%) 861
root-rollup 49.9 4,359 725
private-kernel-inner 218 71,744 26,164
public-kernel-app-logic 120 (-1%) 47,695 40,661
public-kernel-tail 163 (-1%) 53,372 ⚠️ 13,269 (+86%)
merge-rollup 9.86 (-4%) 2,568 861
public-kernel-teardown 118 (+2%) 47,695 40,661
public-kernel-setup 117 (+2%) 47,695 40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.1 (-1%) 16.1 (-2%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.588 (-1%) 0.497 (-2%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.0 (-1%) 72.8 234 (+1%) 450 (+1%) 887 (+1%) 1,732 (-1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.472 (-1%) 0.448 0.425 (+1%) 0.420 (+1%) 0.420 (+1%) 0.415 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 54.6 108 338 663 1,318 2,614 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.481 0.486 0.460 0.456 0.457 0.454 (-1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 61.5
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.536

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 40,548 501,142 (+1%)

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,730 (+2%) 1,085 (-1%) 5,484 (+1%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 577 449 (+13%) 1,070 534 (+1%) 1,760 (+1%) 595 (+2%)

@lucasxia01 lucasxia01 self-assigned this Apr 10, 2024
@lucasxia01 lucasxia01 marked this pull request as draft April 10, 2024 13:31
@codygunton
Copy link
Contributor

Experiment over

@codygunton codygunton closed this May 17, 2024
@ludamad ludamad deleted the lx/clarify-pg-accumulator branch August 22, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify Protogalaxy state
3 participants