refactor: replacing unsafe::zeroed()

[benesjan]

Replacement of #5628 . This one uses the old Empty naming but replaces the use of unsafe::zeroed() with the code @sklppy88 created.

In some situations it would be better to use zero() instead of empty() but I think it doesn't matter that much. This has become too much of a time sink given how low priority it is.

Anyway, renamed AppendOnlyTreeSnapshot::empty() to AppendOnlyTreeSnapshot::zero() in Noir, because we had it named like that in TS and that's one of the cases were it's confusing (is it a snapshot of a zeroed out tree or of a correctly hashed tree that has zero leaves?).

[benesjan]

• refactor: replacing unsafe::zeroed() #5685 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 107 (+166%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,412	6,412
l1_rollup_execution_gas	585,757	585,745	585,745
l2_block_processing_time_in_ms	1,318 (+1%)	4,872 (+2%)	9,435 (+1%)
note_successful_decrypting_time_in_ms	230 (-9%)	496 (-6%)	907 (-7%)
note_trial_decrypting_time_in_ms	32.6 (-36%)	⚠️ 107 (+166%)	25.1 (-75%)
l2_block_building_time_in_ms	10,398 (-1%)	37,049 (-1%)	72,252 (-3%)
l2_block_rollup_simulation_time_in_ms	10,283 (-1%)	36,650 (-1%)	71,497 (-3%)
l2_block_public_tx_process_time_in_ms	4,890 (-1%)	19,169 (-1%)	38,051 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,318 (+3%)	27,140 (+1%)
note_history_successful_decrypting_time_in_ms	1,166 (-7%)	2,278 (-2%)
note_history_trial_decrypting_time_in_ms	36.1 (-42%)	83.8 (+8%)
node_database_size_in_bytes	18,657,360	35,037,264
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	144 (-1%)	44,281	26,164
private-kernel-inner	151 (-1%)	71,648	26,164
private-kernel-ordering	111 (-2%)	50,830	39,026
base-parity	3,937 (-1%)	128	311
root-parity	1,055 (-5%)	1,244	311
base-rollup	13,216 (-3%)	110,464	861
root-rollup	49.3 (-4%)	4,359	725
public-kernel-app-logic	79.0 (-1%)	47,599	40,661
public-kernel-tail	112 (-1%)	53,372	7,125
merge-rollup	10.7 (-18%)	2,568	861
public-kernel-teardown	76.5	47,599	40,661
public-kernel-setup	75.3	47,599	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0 (-1%)	16.0 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.583 (-1%)	0.496 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.0 (-1%)	72.5	232	446	875 (-1%)	1,733	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.471 (-1%)	0.447	0.422	0.417	0.414 (-1%)	0.415	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.2	107	337 (-1%)	659	1,313 (-1%)	2,621 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.480	0.483	0.457 (-1%)	0.454	0.454 (-1%)	0.454	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.1
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.534

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,372	496,534

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,176 (-1%)	816 (-1%)	4,005

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	419 (-1%)	286	741 (+1%)	365 (-1%)	1,210 (-1%)	428 (-1%)

[sklppy88]

lgtm