Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement canonical key registry 5609 and implement shared mutable getter from another contract 5689 #5723
feat: implement canonical key registry 5609 and implement shared mutable getter from another contract 5689 #5723
Changes from 6 commits
c149e2c
7365b17
4549dd8
a1907b0
01bbd3b
f976ac0
8545e23
f742400
6a86b9d
b58da64
32a24e8
6032daa
600ac9a
cbda439
ae19d83
c75dc4d
8270e04
a84c9bd
ed2466d
ac9adc3
9d3c831
9e184de
192d870
bf4529a
d39ac15
442d745
634c15b
d663fa8
9ab61ba
2f7e492
d9e61c7
51180e3
4918f41
8867e5e
78093cd
2b1b5cb
b655e76
bb4b7cb
8666545
96ed013
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just call this register and the other function rotate_nullifier_public_key. The preimage check is an implementation detail so I don't think it makes sense to have it in func name and I think we'll always want to rotate the keys only 1 by 1 so it doesn't make sense to have generic rotate_keys function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, addressed in
2b1b5c
, along with all the other feedback. Thank you 🙏