Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump crs to handle range checks #5724

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

IlyasRidhuan
Copy link
Contributor

Please read contributing guidelines and remove this line.

@IlyasRidhuan IlyasRidhuan requested a review from jeanmon April 12, 2024 12:18
Copy link
Contributor

@jeanmon jeanmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IlyasRidhuan

@jeanmon jeanmon merged commit 3712263 into jm/5641-enable-range-alu Apr 12, 2024
20 of 26 checks passed
@jeanmon jeanmon deleted the ir/fix_avm_bb branch April 12, 2024 12:23
jeanmon pushed a commit that referenced this pull request Apr 12, 2024
Please read [contributing guidelines](CONTRIBUTING.md) and remove this
line.
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (8): 241 (+53%)
  • note_successful_decrypting_time_in_ms (32): 574 (+17%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,784 6,808 (+1%) 6,796
l1_rollup_execution_gas 587,265 587,289 587,277
l2_block_processing_time_in_ms 1,308 4,782 (+1%) 9,354 (+4%)
note_successful_decrypting_time_in_ms ⚠️ 241 (+53%) ⚠️ 574 (+17%) 915 (-4%)
note_trial_decrypting_time_in_ms 43.5 (-29%) 81.3 (-18%) 33.3 (-52%)
l2_block_building_time_in_ms 10,606 37,850 75,000 (+1%)
l2_block_rollup_simulation_time_in_ms 10,484 37,455 74,234 (+1%)
l2_block_public_tx_process_time_in_ms 5,060 19,828 39,584

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,071 (+1%) 26,603 (-5%)
note_history_successful_decrypting_time_in_ms 1,171 (+3%) 2,229 (+4%)
note_history_trial_decrypting_time_in_ms 40.4 (+8%) 76.4 (+6%)
node_database_size_in_bytes 18,726,992 34,971,728
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 145 44,561 26,424
private-kernel-inner 155 (-1%) 72,188 26,424
private-kernel-ordering 108 51,090 39,297
base-parity 3,920 128 311
root-parity 1,047 (-1%) 1,244 311
base-rollup 13,411 (+1%) 110,820 957
root-rollup 49.0 4,551 821
public-kernel-app-logic 83.3 48,151 40,933
public-kernel-tail 121 (-1%) 53,644 7,385
merge-rollup 11.1 (+8%) 2,760 957
public-kernel-teardown 76.1 (-2%) 48,151 40,933
public-kernel-setup 75.1 (-2%) 48,151 40,933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.0 15.9 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.584 0.492 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 45.9 72.6 233 (+1%) 448 870 1,739 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.470 0.447 0.424 (+1%) 0.418 (-1%) 0.414 0.416 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 54.1 108 (+1%) 339 (-1%) 664 1,316 (+1%) 2,626 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.477 0.486 (+1%) 0.460 0.456 0.456 (+1%) 0.455 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 61.2
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.534

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 41,005 528,889

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,111 (-1%) 765 3,282 (-3%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 439 289 (-2%) 739 (-2%) 373 (-2%) 1,197 (-2%) 439 (-3%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants