Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Brillig pointer codegen and execution #5737

Merged
merged 66 commits into from
Apr 16, 2024
Merged

feat: Brillig pointer codegen and execution #5737

merged 66 commits into from
Apr 16, 2024

Commits on Apr 11, 2024

  1. initial BrilligPointer opcode without any implementation

    @vezenovm
    vezenovm committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8ebbfd8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mv/brillig-pointer

    @vezenovm
    vezenovm authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    45083bc View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. initial codegen work for brillig pointer and execution in the acvm

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    be85a53 View commit details
    Browse the repository at this point in the history

  2. update circuit serialization and instance deployer constant

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6bbd4f6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mv/brillig-pointer

    @vezenovm
    vezenovm authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    37ce65c View commit details
    Browse the repository at this point in the history

  4. revert commented hash check

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b93a95f View commit details
    Browse the repository at this point in the history

  5. update todo comment

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ae72419 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into mv/brillig-pointer

    @vezenovm
    vezenovm authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    993174e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into mv/brillig-pointer

    @vezenovm
    vezenovm authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    34513f8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'mv/brillig-pointer' into mv/codegen-brillig-pointer

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    445dd78 View commit details
    Browse the repository at this point in the history

  9. handle brillig pointer in acvm js and cargo fmt

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    375f9f6 View commit details
    Browse the repository at this point in the history

  10. cleanup BrilligSolver new methods

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e868e46 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into mv/brillig-pointer

    @vezenovm
    vezenovm authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9800a83 View commit details
    Browse the repository at this point in the history

  12. some cleanup

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3f58cf6 View commit details
    Browse the repository at this point in the history

  13. cargo fmt

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3885f47 View commit details
    Browse the repository at this point in the history

  14. Apply suggestions from code review

    @TomAFrench
    TomAFrench authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    202534b View commit details
    Browse the repository at this point in the history

  15. use Vec inside of map for generated brilligs

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3d79f62 View commit details
    Browse the repository at this point in the history

  16. cargo fmt

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0b5ae02 View commit details
    Browse the repository at this point in the history

  17. fix to use generated index when setting brillig pointer

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1570818 View commit details
    Browse the repository at this point in the history

  18. cargo mft

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0beb7fb View commit details
    Browse the repository at this point in the history

  19. update instance deployer address

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7f7ddf3 View commit details
    Browse the repository at this point in the history

  20. some improvements, store GeneratedBrilligs during SSA as a Vec

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    db06865 View commit details
    Browse the repository at this point in the history

  21. make both brillig func info a mutable reference on an AcirContext

    @vezenovm
    vezenovm committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    dcf586d View commit details
    Browse the repository at this point in the history

  22. Update noir/noir-repo/tooling/nargo_cli/src/cli/info_cmd.rs

    @TomAFrench
    TomAFrench authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3028114 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. change serde to BrilligCall and no inner struct

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    32536f8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mv/brillig-pointer

    @vezenovm
    vezenovm authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    98872f1 View commit details
    Browse the repository at this point in the history

  3. undo comment in serde test

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    94d4837 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/mv/brillig-pointer' into mv/bril… 

    …lig-pointer
    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3e2e6a2 View commit details
    Browse the repository at this point in the history

  5. Update noir/noir-repo/acvm-repo/acir/src/circuit/opcodes.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @vezenovm @TomAFrench
    vezenovm and TomAFrench authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a8820cb View commit details
    Browse the repository at this point in the history

  6. brillig call display

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2efd923 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into mv/brillig-pointer

    @vezenovm
    vezenovm authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8953725 View commit details
    Browse the repository at this point in the history

  8. fix mem op serde

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8ca0782 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/mv/brillig-pointer' into mv/bril… 

    …lig-pointer
    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    eae0ea3 View commit details
    Browse the repository at this point in the history

  10. merge conflcits w/ mv/brillig-pointer

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    c8f3556 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into mv/brillig-pointer

    @TomAFrench
    TomAFrench authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1c9fc63 View commit details
    Browse the repository at this point in the history

  12. working again after merge conflicts

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    191b1dc View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into mv/brillig-pointer

    @vezenovm
    vezenovm authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a3c1303 View commit details
    Browse the repository at this point in the history

  14. move to shraed context in acir gen

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    733eac0 View commit details
    Browse the repository at this point in the history

  15. cleanup

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    fba8b6e View commit details
    Browse the repository at this point in the history

  16. cleanup comment in test

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f141f7b View commit details
    Browse the repository at this point in the history

  17. Merge branch 'mv/brillig-pointer' into mv/codegen-brillig-pointer

    @vezenovm
    vezenovm authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    33661df View commit details
    Browse the repository at this point in the history

  18. Merge branch 'master' into mv/brillig-pointer

    @vezenovm
    vezenovm authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a5d2dd4 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'mv/brillig-pointer' into mv/codegen-brillig-pointer

    @vezenovm
    vezenovm authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    fdb44a7 View commit details
    Browse the repository at this point in the history

  20. update serde

    @vezenovm
    vezenovm committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    32a1514 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. merge conflicts w/ master

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f0fddbe View commit details
    Browse the repository at this point in the history

  2. update instance delployer address

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    78b8db0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mv/codegen-brillig-pointer

    @vezenovm
    vezenovm authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0da51ba View commit details
    Browse the repository at this point in the history

  4. Update noir/noir-repo/acvm-repo/acvm/src/pwg/mod.rs 

    Co-authored-by: jfecher <jfecher11@gmail.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    657180e View commit details
    Browse the repository at this point in the history

  5. Update noir/noir-repo/compiler/noirc_evaluator/src/ssa.rs 

    Co-authored-by: jfecher <jfecher11@gmail.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b36c539 View commit details
    Browse the repository at this point in the history

  6. Update noir/noir-repo/compiler/noirc_evaluator/src/ssa/acir_gen/acir_… 

    …ir/acir_variable.rs

Co-authored-by: jfecher <jfecher11@gmail.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5a838ee View commit details
    Browse the repository at this point in the history

  7. Update noir/noir-repo/compiler/noirc_evaluator/src/ssa/acir_gen/acir_… 

    …ir/acir_variable.rs

Co-authored-by: jfecher <jfecher11@gmail.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9bb9288 View commit details
    Browse the repository at this point in the history

  8. Update noir/noir-repo/compiler/noirc_evaluator/src/ssa/acir_gen/acir_… 

    …ir/acir_variable.rs

Co-authored-by: jfecher <jfecher11@gmail.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ae0d8a9 View commit details
    Browse the repository at this point in the history

  9. Update noir/noir-repo/compiler/noirc_evaluator/src/ssa/acir_gen/acir_… 

    …ir/acir_variable.rs

Co-authored-by: jfecher <jfecher11@gmail.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c210697 View commit details
    Browse the repository at this point in the history

  10. Update noir/noir-repo/compiler/noirc_evaluator/src/ssa/acir_gen/acir_… 

    …ir/acir_variable.rs

Co-authored-by: jfecher <jfecher11@gmail.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    368b7d8 View commit details
    Browse the repository at this point in the history

  11. Update noir/noir-repo/compiler/noirc_evaluator/src/ssa/acir_gen/acir_… 

    …ir/acir_variable.rs

Co-authored-by: jfecher <jfecher11@gmail.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    389da97 View commit details
    Browse the repository at this point in the history

  12. Update noir/noir-repo/cspell.json 

    Co-authored-by: jfecher <jfecher11@gmail.com>
    @vezenovm @jfecher
    vezenovm and jfecher authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a617ff5 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into mv/codegen-brillig-pointer

    @vezenovm
    vezenovm authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c19d0cf View commit details
    Browse the repository at this point in the history

  14. rename generated_brilligs

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3327c91 View commit details
    Browse the repository at this point in the history

  15. back to loop for brillig array input

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    01c78c5 View commit details
    Browse the repository at this point in the history

  16. missed name

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    76b7b7a View commit details
    Browse the repository at this point in the history

  17. Merge branch 'master' into mv/codegen-brillig-pointer

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    848fe07 View commit details
    Browse the repository at this point in the history

  18. label the entry point indices

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0aa917d View commit details
    Browse the repository at this point in the history

  19. add unit test for brilligcall gen and delete brillig_acir_loop

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7afebb6 View commit details
    Browse the repository at this point in the history

  20. merge conflicts

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    477840d View commit details
    Browse the repository at this point in the history

  21. Merge branch 'master' into mv/codegen-brillig-pointer

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9920110 View commit details
    Browse the repository at this point in the history

  22. update constants

    @vezenovm
    vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    fd3af40 View commit details
    Browse the repository at this point in the history