feat: add the storage layout to the contract artifact

[LHerskind]

Fixes #5947 and includes the notes as well. The notes was part of the contract object, but not directly exposed on the artifact itself.

Needed to fix a few additional things to make it work:

• The deploy_contract function was broken (old call flow), it cannot do the new flow because that would be a circular dependency.
• Using the storageLayout values to get the storageSlot that we are using in multiple tests
• Using the notes values to get the noteTypeId that we are using in multiple tests
• Removed lodash.uniqby as the dependency was not needed after this.

[LHerskind]

• feat: add the storage layout to the contract artifact #5952 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 108 (+171%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,832	6,832	6,820
l1_rollup_execution_gas	587,313	587,313	587,301
l2_block_processing_time_in_ms	1,557 (+7%)	5,565	10,326 (-2%)
note_successful_decrypting_time_in_ms	257 (+6%)	609 (+13%)	1,084 (-1%)
note_trial_decrypting_time_in_ms	47.0 (+37%)	⚠️ 108 (+171%)	120 (+3%)
l2_block_building_time_in_ms	18,957 (+1%)	74,382 (+1%)	147,088
l2_block_rollup_simulation_time_in_ms	18,738 (+1%)	73,591 (+1%)	145,586
l2_block_public_tx_process_time_in_ms	8,607 (+2%)	33,916 (+2%)	67,176

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,048 (-2%)	30,256 (-2%)
note_history_successful_decrypting_time_in_ms	1,322 (-4%)	2,611 (-8%)
note_history_trial_decrypting_time_in_ms	76.8 (-8%)	122 (-18%)
node_database_size_in_bytes	19,177,552	35,868,752
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	157	47,763	31,978
private-kernel-inner	179 (+1%)	80,794	31,978
private-kernel-ordering	138 (+1%)	57,732	50,043
base-parity	74.6 (-4%)	128	265
root-parity	120 (-5%)	1,244	265
base-rollup	12,251	110,926	957
root-rollup	49.8	4,551	821
public-kernel-app-logic	1,660	62,017	52,067
public-kernel-tail	4,181 (-1%)	168,566	7,491
merge-rollup	3,151	2,760	957
public-kernel-teardown	118 (+1%)	62,017	52,067
public-kernel-setup	117 (-1%)	62,017	52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.1 (+1%)	17.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.643 (+1%)	0.551	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	51.3	80.8 (+1%)	262 (+2%)	500 (-1%)	989 (+2%)	1,952 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.526	0.499 (+1%)	0.477 (+1%)	0.468 (-1%)	0.470 (+1%)	0.466 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.4	119	379 (+1%)	737 (-1%)	1,478 (+1%)	2,922 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.534	0.536	0.513	0.508 (-1%)	0.511 (+1%)	0.508	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.5
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.589

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	51,411	543,524

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,274 (+1%)	875 (+1%)	3,488

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	839	753 (-1%)	1,340 (-1%)	897 (-1%)	2,055 (-1%)	1,082 (-1%)

[benesjan]

That's a lot of 💩🚪➡️🗑️

Feel free to merge once my nits are addressed

[benesjan]

Suggested change

	* Type of the note
	* Type of the note (e.g. `ValueNote`)

Is my suggestion correct? If yes would be helpful to have it committed

[benesjan]

Suggested change

	* Type being stored at the slot
	* Type being stored at the slot (e.g. `Map<AztecAddress, PublicMutable<bool>>`)

[benesjan]

Suggested change

	// The test is flaky, up this constant if the test fails 💀
	// The test is flaky, increse this constant if the test fails 💀

[benesjan]

Should an issue be created an linked here?