-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert "chore: don't strip bb wasm" #6068
Conversation
This reverts commit d4cb410.
Benchmark resultsNo metrics with a significant change found. Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method
Transaction processing duration by data writes.
|
Would be great to get a non-stripped version published separately (#5647) instead of / following a revert. Bb's stack traces are great for easing both Noir users and us (Noir Dev Rel + engineering) to gather insights on bb-related Issues. |
I can revisit that with cycles, but per Charlie we'd just prefer to keep this as-is if no one is complaining about the uncompressed size (compressed is just +2MB) |
Reverts #5743
This proved too big