fix: Bump gates buffer for GoblinUltraHonk circuit size estimation #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ended up finding a cleaner solution right here (#6164). Which can replace this PR and resolve the issue. |
|
Closing in favor of #6164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6138 we starting getting an assertion failure due to an incorrect circuit size estimation for goblin ultra honk. I have simply bumped the additional gates buffer for now as to bring back the
witness_compressiontest and linked to this newly made issue (#6161) so that we can more accurately estimate the total circuit size no matter the builder.