Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #6234

Merged
merged 9 commits into from
May 7, 2024
Merged

feat: Sync from noir #6234

merged 9 commits into from
May 7, 2024

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented May 7, 2024

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: set index and value to 0 for array_get with predicate (noir-lang/noir#4971)
fix: Compute the correct slice length when coercing from a literal array of complex types (noir-lang/noir#4986)
feat: add Neg trait to stdlib (noir-lang/noir#4983)
feat: implement From array trait for BoundedVec (noir-lang/noir#4927)
chore: Release Noir(0.29.0) (noir-lang/noir#4905)
fix: Move remove_if_else pass after second inlining (noir-lang/noir#4976)
END_COMMIT_OVERRIDE

AztecBot and others added 5 commits May 7, 2024 09:15
noir-lang/noir#4971)

fix: Compute the correct slice length when coercing from a literal array of complex types (noir-lang/noir#4986)
feat: add `Neg` trait to stdlib (noir-lang/noir#4983)
feat: implement `From` array trait for `BoundedVec` (noir-lang/noir#4927)
chore: Release Noir(0.29.0) (noir-lang/noir#4905)
fix: Move remove_if_else pass after second inlining  (noir-lang/noir#4976)
* master: (196 commits)
  fix: various aztec-builder issues (#6233)
  feat: always including debug data in a function artifact (#6223)
  feat: proving benchmark (#6051)
  fix: use random id for proving jobs (#6084)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  fix: Sporadic failure of GoblinRecursionTests.Vanilla (#6218)
  feat(avm): Add TransactionFee opcode to simulator (#6210)
  chore(avm-simulator): avm's nested calls now stay internal and properly track PublicExecutionResult (#6165)
  chore(avm-simulator): track recursive public execution result in avm-simulator for integration with old kernel (#6106)
  chore(ci): optimize e2e build (#6202)
  chore(ci): more stable spot request (#6212)
  feat: making keys getters complete (#6171)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  feat: move noir-tests to earthly (#6185)
  ...
Copy link
Contributor

github-actions bot commented May 7, 2024

Changes to circuit sizes

Generated at commit: 9f92570c7dc36ed3ba0e8fc9986dffced922cad3, compared to commit: f6b1ba60daf37a5a6466ca1e5ee7be70354af485

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_setup +29 ❌ +0.04% +56 ❌ +0.02%
public_kernel_teardown +29 ❌ +0.04% +56 ❌ +0.02%
public_kernel_app_logic +23 ❌ +0.03% +61 ❌ +0.02%
private_kernel_inner +23 ❌ +0.02% +37 ❌ +0.01%
private_kernel_init +13 ❌ +0.01% +22 ❌ +0.01%
public_kernel_tail +47 ❌ +0.01% +47 ❌ +0.00%
private_kernel_tail -200 ✅ -0.15% +7 ❌ +0.00%
private_kernel_tail_to_public -200 ✅ -0.06% +2 ❌ +0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_setup 71,814 (+29) +0.04% 301,914 (+56) +0.02%
public_kernel_teardown 71,955 (+29) +0.04% 302,050 (+56) +0.02%
public_kernel_app_logic 86,993 (+23) +0.03% 382,839 (+61) +0.02%
private_kernel_inner 106,995 (+23) +0.02% 380,740 (+37) +0.01%
private_kernel_init 91,755 (+13) +0.01% 285,752 (+22) +0.01%
public_kernel_tail 382,097 (+47) +0.01% 1,379,979 (+47) +0.00%
private_kernel_tail 135,680 (-200) -0.15% 1,063,385 (+7) +0.00%
private_kernel_tail_to_public 348,878 (-200) -0.06% 1,536,196 (+2) +0.00%

@TomAFrench TomAFrench enabled auto-merge (squash) May 7, 2024 11:17
* master:
  Revert "cl/split_out_e2e_tests"
  feat: `multi_scalar_mul` blackbox func (#6097)
  cl/split_out_e2e_tests
  fix: aztec-run not exposing port for builder (#6241)
  feat: add ciphertext computation for log header (#6175)
@TomAFrench TomAFrench merged commit 02d3d17 into master May 7, 2024
62 checks passed
@TomAFrench TomAFrench deleted the sync-noir branch May 7, 2024 16:11
TomAFrench added a commit that referenced this pull request May 8, 2024
* master: (25 commits)
  fix: Enable client proof tests (#6249)
  chore: update cspell for abi demonomorphizer (#6258)
  feat(aztec-nr): add 'with_gas()' function to avm call interface (#6256)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  fix: Pw/update merge check (#6201)
  chore(master): Release 0.37.1 (#6148)
  fix: Cl/split out e2e tests (#6242)
  feat: Typings generator with generics (#6235)
  chore(ci): fix restarts with fresh spot, acir test fixes, non-mandatory benches (#6226)
  chore: misc AVM migration prep changes (#6253)
  feat!: AES blackbox (#6016)
  chore(docs): Fix some typos in specs of private kernel initial (#6224)
  chore(aztec-macros): avm function return types are auto tagged as `pub` (#6250)
  chore(aztec-nr): create a 'with_selector' version of `emit_unencrypted_log` in avm context (#6248)
  fix: registering PublicDataWitness in JsonRpcServer (#6243)
  feat: Sync from noir (#6234)
  feat(avm-simulator): consider previous pending nullifiers across enqueued calls (#6188)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants