fix(avm-simulator): always set revertReason when reverting

[fcarreiro]

Part of the current setup seems to assume that a simulation reverts if and only if there's a revertReason. This is why some e2e tests were failing to see the revert (and throw an exception) when the revert message was empty.

Example

/**
 * Makes a processed tx out of source tx.
 * @param tx - Source tx.
 * @param kernelOutput - Output of the kernel circuit simulation for this tx.
 * @param proof - Proof of the kernel circuit for this tx.
 */
export function makeProcessedTx(
  tx: Tx,
  kernelOutput: KernelCircuitPublicInputs,
  proof: Proof,
  publicKernelRequests: PublicKernelRequest[],
  revertReason?: SimulationError,
  gasUsed: ProcessedTx['gasUsed'] = {},
): ProcessedTx {
  return {
    hash: tx.getTxHash(),
    data: kernelOutput,
    proof,
    encryptedLogs: revertReason ? EncryptedTxL2Logs.empty() : tx.encryptedLogs,
    unencryptedLogs: revertReason ? UnencryptedTxL2Logs.empty() : tx.unencryptedLogs,
    isEmpty: false,
    revertReason,
    publicKernelRequests,
    gasUsed,
  };
}

cc @just-mitch because I see his name in some parts of the code.

[fcarreiro]

• fix(avm-simulator): always set revertReason when reverting #6297 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[fcarreiro]

Merge activity

• May 9, 8:05 AM EDT: @fcarreiro merged this pull request with Graphite.