Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: validating private call data #6316

Merged
merged 4 commits into from
May 10, 2024
Merged

refactor: validating private call data #6316

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b80551
Create PrivateCallDataValidator.
LeilaWang May 9, 2024
f2c1e4b
Merge remote-tracking branch 'origin/master' into lw/private_call_dat…
LeilaWang May 10, 2024
9ccd183
Move some checks to validator.
LeilaWang May 10, 2024
8aeb392
Merge remote-tracking branch 'origin/master' into lw/private_call_dat…
LeilaWang May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
190 changes: 0 additions & 190 deletions noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/common.nr
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to private_call_data_validator.nr.

This file was deleted.

4 changes: 3 additions & 1 deletion ...-protocol-circuits/crates/private-kernel-lib/src/kernel_circuit_public_inputs_composer.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ impl KernelCircuitPublicInputsComposer {

fn silo_note_hashes(&mut self) {
let first_nullifier = self.public_inputs.end.new_nullifiers.get_unchecked(0).value();
assert(first_nullifier != 0, "The 0th nullifier in the accumulated nullifier array is zero");

// This check is unnecessary. The 0th nullifier will always be set a non-zero value in private_kernel_init.
// assert(first_nullifier != 0, "The 0th nullifier in the accumulated nullifier array is zero");

let note_hashes = self.public_inputs.end.new_note_hashes.storage;
for i in 0..MAX_NEW_NOTE_HASHES_PER_TX {
Expand Down
5 changes: 2 additions & 3 deletions noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/lib.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
mod kernel_circuit_public_inputs_composer;
mod private_call_data_validator;
mod private_kernel_circuit_public_inputs_composer;
mod private_kernel_init;
mod private_kernel_inner;
mod private_kernel_tail;
mod private_kernel_tail_to_public;
mod tests;

use private_kernel_init::PrivateKernelInitCircuitPrivateInputs;
use private_kernel_inner::PrivateKernelInnerCircuitPrivateInputs;
use private_kernel_tail::PrivateKernelTailCircuitPrivateInputs;
use private_kernel_tail_to_public::PrivateKernelTailToPublicCircuitPrivateInputs;

// TODO: rename to be precise as to what its common to.
mod common;
Loading
Loading