-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add simple bb
installer script
#6376
Conversation
I think it's worth progressing with this in the short term pending the client/server model switch and have |
Benchmark resultsNo base data found for comparison. Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | Transaction processing duration by data writes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script seems to rely on some nargo env variables such as $NOIRUP_REPO, $NARGO_BIN_DIR. I wonder if it should check for a nargo installation first?
Actually, that code referencing |
For posterity's additional context, If anyone reading is has an updated recommended way to install bb, please update the Noir docs and give the Noir team a heads up. Thanks! |
As of #6320, we're now expecting users to maintain an installation of
bb
and update its version as required.To help with this, this PR adds an ultra dumb
bbup
script fashioned fromnoirup
which only allows installing released versions ofbb
. This means that users can runbbup -v 0.38.0
to install 0.38.0 ofbb
.Happy to make any changes as requested.