-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert ClientIVC mock sizes #6693
Conversation
Benchmark resultsNo metrics with a significant change found. Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | |
The pull request #6391 coarsely adjusted the ClientIVC benchmarks to account for more expensive biggroup operations, leading to an artificial improvment in the bencmark. This PR fine tunes the mock circuits to more-or-less revert that change.
MockKernelTest.PinFoldingKernelSizes
before #6391 (7fbe7a0)
#6391 (bd72db5)
This PR
MegaMockCircuitsPinning
before #6391 (7fbe7a0)
#6391 (bd72db5)
this PR
ClientIVCBenchmarks
Benchmark on master before this PR (bd72db5):
Benchmark on this PR
The PR that artificially improved the benchmark went took the circuit construction time from 4400ms to 3400ms. This PR takes that number to 4500ms.
Benchmark on the commit (7fbe7a0) prior to the PR that disturbed the benchmarks
WASM benches
On 9f0827f
On bd72db5
Currently