feat: Make decoder a library instead #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHerskind
force-pushed
the
lh/593-fixing-linter-issues
branch
2 times, most recently
from
b23e2e8
to
066bbd7
Compare
LHerskind
force-pushed
the
lh/decoder-library
branch
from
38a3aec
to
0df6d4d
Compare
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the decoder contract into a library instead, it is never to be used directly anyway so seemed nice to just make it as a library instead.
Did not change the test to use the library directly instead of using the decoder helper mainly as we are using the decoder helper in the end to end test, so it is nice to have it checked here.
Checklist: