Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Small fixes for the tube flows #7014

Merged
merged 5 commits into from
Jun 11, 2024
Merged

chore: Small fixes for the tube flows #7014

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f40dab
remove vk hacks and add new flow to Earthfile
maramihali Jun 11, 2024
ea3c95d
Merge remote-tracking branch 'origin/master' into mm/flow-fixes
maramihali Jun 11, 2024
3e45cd4
update description
maramihali Jun 11, 2024
2d92b32
fix prove_then_verify_tube flow by creating required folder
maramihali Jun 11, 2024
dd1193b
Merge branch 'master' into mm/flow-fixes
maramihali Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions barretenberg/Earthfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
RUN FLOW=prove_and_verify_mega_honk_program ./run_acir_tests.sh
# Fold and verify an ACIR program stack using ClientIvc
RUN FLOW=fold_and_verify_program ./run_acir_tests.sh fold_basic
# Fold and verify an ACIR program stack using ClientIvc, recursively verify as part of the Tube circuit and produce and verify a Honk proof
RUN FLOW=prove_then_verify_tube ./run_acir_tests.sh fold_basic

Check failure on line 46 in barretenberg/Earthfile

View workflow job for this annotation

GitHub Actions / bb-acir-tests-bb

Error 

The command RUN FLOW=prove_then_verify_tube ./run_acir_tests.sh fold_basic did not complete successfully. Exit code 1
# Construct and separately verify a UltraHonk proof for a single program that recursively verifies a Honk proof
RUN FLOW=prove_then_verify_ultra_honk ./run_acir_tests.sh verify_honk_proof
# Construct and verify a UltraHonk proof for a single program that recursively verifies a Honk proof
Expand Down
5 changes: 3 additions & 2 deletions barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ template <typename PCS> class ZeroMorphProver_ {
using Polynomial = bb::Polynomial<FF>;

// TODO(#742): Set this N_max to be the number of G1 elements in the mocked zeromorph SRS once it's in place.
// (Then, eventually, set it based on the real SRS). For now we set it to be large but more or less arbitrary.
static const size_t N_max = 1 << 23;
// (Then, eventually, set it based on the real SRS). For now we set it to be larger then the Client IVC recursive
// verifier circuit.
static const size_t N_max = 1 << 25;

public:
/**
Expand Down
6 changes: 0 additions & 6 deletions barretenberg/cpp/src/barretenberg/eccvm/eccvm_verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ bool ECCVMVerifier::verify_proof(const HonkProof& proof)

for (auto [comm, label] : zip_view(commitments.get_wires(), commitment_labels.get_wires())) {
comm = transcript->template receive_from_prover<Commitment>(label);
// TODO(https://github.com/AztecProtocol/barretenberg/issues/1017): This is a hack to ensure zero commitments
// are still on curve as the transcript doesn't currently support a point at infinity representation for
// cycle_group
if (!comm.on_curve()) {
comm.self_set_infinity();
}
}

// Get challenge for sorted list batching and wire four memory records
Expand Down
Loading