Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix noir-projects dockerfile for CircleCI #7093

Merged
merged 78 commits into from
Jun 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
39e88bf
Adapt public immutable
nventuro May 30, 2024
de4dfef
Add comments to private imnmutable
nventuro May 31, 2024
584250d
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar Jun 3, 2024
8c5bdf1
TXE
Thunkar Jun 3, 2024
3fbc3ee
improvements
Thunkar Jun 3, 2024
58c4c82
fixed tsconfig
Thunkar Jun 3, 2024
84af5e8
public data tree witness
Thunkar Jun 3, 2024
aab9959
return null
Thunkar Jun 3, 2024
c94d32e
more oracle calls
Thunkar Jun 4, 2024
5d857ae
more oracles, timetravel
Thunkar Jun 4, 2024
717a16a
fix
Thunkar Jun 4, 2024
58e7bfa
Sketch nr tests for txe testing
nventuro Jun 4, 2024
d543edf
fix
Thunkar Jun 4, 2024
92b9a48
Begin test refactor
nventuro Jun 4, 2024
c6fdef6
fix
Thunkar Jun 4, 2024
b29b3a4
fixes
Thunkar Jun 4, 2024
6628ab0
fix
Thunkar Jun 4, 2024
460a1d1
private context inputs
Thunkar Jun 4, 2024
069a09a
return struct
Thunkar Jun 4, 2024
7edc719
fix
Thunkar Jun 4, 2024
f2820a7
configurable private inputs
Thunkar Jun 4, 2024
cbe1564
???
nventuro Jun 4, 2024
2250b98
???
nventuro Jun 4, 2024
45434f9
fixes
Thunkar Jun 4, 2024
c180bdb
git add .
nventuro Jun 4, 2024
a34bf85
fixes and moar
Thunkar Jun 4, 2024
fdbeaf8
note handling
Thunkar Jun 4, 2024
12453ea
Samples
nventuro Jun 5, 2024
fdd5cf1
Add address fixes
nventuro Jun 7, 2024
ff3fa71
almost there
Thunkar Jun 7, 2024
ea506ab
working proto
Thunkar Jun 7, 2024
562e92e
initial txe version
Thunkar Jun 10, 2024
e037804
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar Jun 10, 2024
21f3178
removed file
Thunkar Jun 10, 2024
c543a2c
Add TXE
nventuro Jun 10, 2024
0d1221a
Merge branch 'gj_nv/txe' of github.com:AztecProtocol/aztec-packages i…
Thunkar Jun 10, 2024
6083ade
fixes
Thunkar Jun 10, 2024
b80f6c7
fixes
Thunkar Jun 10, 2024
ca42523
account abstraction
Thunkar Jun 11, 2024
38fb77e
reverted parallel changes since we have session ids now
Thunkar Jun 11, 2024
dc373da
Merge branch 'master' into gj_nv/txe
Thunkar Jun 11, 2024
85b7dec
updated tsconfig
Thunkar Jun 11, 2024
84292d0
Merge branch 'master' into gj_nv/txe
Thunkar Jun 11, 2024
907e26d
external calls
Thunkar Jun 12, 2024
5a92553
private calls
Thunkar Jun 12, 2024
8b278a1
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar Jun 12, 2024
cf027a2
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar Jun 12, 2024
5e9486e
public initializers
Thunkar Jun 13, 2024
bbeaa00
34 token transfer
Thunkar Jun 13, 2024
963990a
cleanup
Thunkar Jun 14, 2024
a68fec7
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar Jun 14, 2024
44d63aa
sessionId compatibility
Thunkar Jun 14, 2024
9f1dbe6
corrected docs
Thunkar Jun 14, 2024
93f32d0
cleanup
Thunkar Jun 14, 2024
19123bd
formatting
Thunkar Jun 14, 2024
35fe257
better comment
Thunkar Jun 14, 2024
e41a19c
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar Jun 14, 2024
1ccfe4f
Merge branch 'master' into gj_nv/txe
Thunkar Jun 14, 2024
eb48006
Merge branch 'master' into gj_nv/txe
Thunkar Jun 17, 2024
cca4e8c
test ci
Thunkar Jun 17, 2024
83c16e5
Merge branch 'gj_nv/txe' of github.com:AztecProtocol/aztec-packages i…
Thunkar Jun 17, 2024
f564d92
working CI
Thunkar Jun 17, 2024
083b1f8
better dockerfile
Thunkar Jun 17, 2024
2155e79
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar Jun 18, 2024
c583065
Merge branch 'master' into gj_nv/txe
Thunkar Jun 18, 2024
ab5e0e9
nargo fmt
Thunkar Jun 18, 2024
44669d9
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar Jun 18, 2024
39b5f76
comments from PR
Thunkar Jun 18, 2024
9e0ac91
kill txe even if nargo test fails
Thunkar Jun 18, 2024
2dab518
fix circleCI
Thunkar Jun 18, 2024
8c43548
Merge branch 'master' into gj_nv/txe
Thunkar Jun 18, 2024
9e41eb1
fixed?
Thunkar Jun 18, 2024
df9d613
Merge branch 'gj_nv/txe' of github.com:AztecProtocol/aztec-packages i…
Thunkar Jun 18, 2024
4a80d7b
better test
Thunkar Jun 18, 2024
9fcfe12
improvements
Thunkar Jun 18, 2024
82c3860
typo+
Thunkar Jun 18, 2024
e3b1cc4
no way around it
Thunkar Jun 18, 2024
168e1cd
better comment
Thunkar Jun 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions build_manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ noir-projects:
- noir
- avm-transpiler

# Compiles all aztec noir projects using nargo and the avm-transpiler, then tests them using the TXE.
noir-projects-tests:
buildDir: noir-projects
dockerfile: Dockerfile.test
dependencies:
- noir
- avm-transpiler
- yarn-project

# Uses nargo to compile all the noir test programs, used to test bb and bb.js.
noir-compile-acir-tests:
buildDir: noir/noir-repo/test_programs
Expand Down
25 changes: 6 additions & 19 deletions noir-projects/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM aztecprotocol/noir as noir
FROM aztecprotocol/avm-transpiler as transpiler
FROM aztecprotocol/yarn-project AS yarn-project

FROM ubuntu:lunar AS builder
RUN apt-get update && apt-get install -y parallel nodejs npm
Expand All @@ -14,25 +13,13 @@ ENV PATH="/usr/src/avm-transpiler/target/release:${PATH}"
# Copy in noir projects
WORKDIR /usr/src/noir-projects
COPY . .


# Build
WORKDIR /usr/src/noir-projects
RUN cd noir-protocol-circuits && ./bootstrap.sh && nargo test --silence-warnings

RUN cd /usr/src/yarn-project/txe && yarn start & echo $! > /tmp/txe.pid && \
# Wait for TXE to initialize
sleep 5 && \
cd /usr/src/noir-projects/noir-contracts && \
./bootstrap.sh && nargo test --silence-warnings --oracle-resolver http://localhost:8080 ; \
kill $(cat /tmp/txe.pid)

RUN cd /usr/src/yarn-project/txe && yarn start & echo $! > /tmp/txe.pid && \
# Wait for TXE to initialize
sleep 5 && \
cd /usr/src/noir-projects/aztec-nr && \
nargo test --silence-warnings --oracle-resolver http://localhost:8080

WORKDIR /usr/src/noir-projects/noir-contracts
RUN ./bootstrap.sh
WORKDIR /usr/src/noir-projects/noir-protocol-circuits
RUN ./bootstrap.sh
WORKDIR /usr/src/noir-projects/aztec-nr
RUN nargo compile --silence-warnings

FROM scratch
COPY --from=builder /usr/src/noir-projects /usr/src/noir-projects
38 changes: 38 additions & 0 deletions noir-projects/Dockerfile.test
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
FROM aztecprotocol/noir as noir
FROM aztecprotocol/avm-transpiler as transpiler
FROM aztecprotocol/yarn-project as yarn-project

RUN apt-get update && apt-get install -y parallel

# Copy in nargo
COPY --from=noir /usr/src/noir/noir-repo/target/release/nargo /usr/src/noir/noir-repo/target/release/nargo
ENV PATH="/usr/src/noir/noir-repo/target/release:${PATH}"
# Copy in transpiler
COPY --from=transpiler /usr/src/avm-transpiler/target/release/avm-transpiler /usr/src/avm-transpiler/target/release/avm-transpiler
ENV PATH="/usr/src/avm-transpiler/target/release:${PATH}"

# All built files are ignored so we have to repeat the txe build here.
# It is fast (compared to the tests) and we're moving to earthly, so we don't bother with something more sophisticated.
WORKDIR /usr/src/yarn-project
RUN yarn workspaces focus @aztec/txe
RUN cd ./txe && yarn build

# Copy in noir projects
WORKDIR /usr/src/noir-projects
COPY . .

# Build & test
RUN cd ./noir-protocol-circuits && ./bootstrap.sh && nargo test --silence-warnings

RUN cd /usr/src/yarn-project/txe && yarn start & echo $! > /tmp/txe.pid && \
# Wait for TXE to initialize
sleep 5 && \
cd ./noir-contracts && \
./bootstrap.sh && nargo test --silence-warnings --oracle-resolver http://localhost:8080 ; \
kill $(cat /tmp/txe.pid)

RUN cd /usr/src/yarn-project/txe && yarn start & echo $! > /tmp/txe.pid && \
# Wait for TXE to initialize
sleep 5 && \
cd ./aztec-nr && \
nargo test --silence-warnings --oracle-resolver http://localhost:8080
Loading