feat: remove note hash nullifier counter. #7294

LeilaWang · 2024-07-03T08:31:41Z

…ier_counters

github-actions · 2024-07-03T09:40:47Z

Changes to circuit sizes

Generated at commit: 406a80150ba65985663c169531fcd5b95b317c6e, compared to commit: b7c6593ccd5b2d6247d65a37d57b4c2d790981bb

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init	-656 ✅	-2.60%	-1,024 ✅	-0.27%
private_kernel_tail_to_public	-80 ✅	-0.02%	-10,288 ✅	-0.61%
private_kernel_tail	-64 ✅	-0.30%	-10,140 ✅	-0.82%
private_kernel_reset	-2,934 ✅	-2.17%	-13,968 ✅	-0.82%
private_kernel_reset_big	-2,934 ✅	-2.50%	-13,968 ✅	-0.90%
private_kernel_inner	-1,369 ✅	-3.10%	-12,105 ✅	-1.04%
private_kernel_reset_medium	-2,486 ✅	-2.90%	-13,504 ✅	-1.20%
private_kernel_reset_small	-2,262 ✅	-3.23%	-13,272 ✅	-1.45%
private_kernel_init_simulated	0 ➖	0.00%	-64 ✅	-2.87%
private_kernel_inner_simulated	0 ➖	0.00%	-64 ✅	-2.87%
private_kernel_reset_simulated	0 ➖	0.00%	-64 ✅	-2.87%
private_kernel_reset_simulated_big	0 ➖	0.00%	-64 ✅	-2.87%
private_kernel_reset_simulated_medium	0 ➖	0.00%	-64 ✅	-2.87%
private_kernel_reset_simulated_small	0 ➖	0.00%	-64 ✅	-2.87%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init	24,591 (-656)	-2.60%	372,912 (-1,024)	-0.27%
private_kernel_tail_to_public	444,398 (-80)	-0.02%	1,666,714 (-10,288)	-0.61%
private_kernel_tail	21,180 (-64)	-0.30%	1,233,386 (-10,140)	-0.82%
private_kernel_reset	132,175 (-2,934)	-2.17%	1,683,027 (-13,968)	-0.82%
private_kernel_reset_big	114,511 (-2,934)	-2.50%	1,532,971 (-13,968)	-0.90%
private_kernel_inner	42,765 (-1,369)	-3.10%	1,147,721 (-12,105)	-1.04%
private_kernel_reset_medium	83,367 (-2,486)	-2.90%	1,112,567 (-13,504)	-1.20%
private_kernel_reset_small	67,794 (-2,262)	-3.23%	902,364 (-13,272)	-1.45%
private_kernel_init_simulated	1 (0)	0.00%	2,168 (-64)	-2.87%
private_kernel_inner_simulated	1 (0)	0.00%	2,168 (-64)	-2.87%
private_kernel_reset_simulated	1 (0)	0.00%	2,168 (-64)	-2.87%
private_kernel_reset_simulated_big	1 (0)	0.00%	2,168 (-64)	-2.87%
private_kernel_reset_simulated_medium	1 (0)	0.00%	2,168 (-64)	-2.87%
private_kernel_reset_simulated_small	1 (0)	0.00%	2,168 (-64)	-2.87%

AztecBot · 2024-07-03T10:15:08Z

Benchmark results

Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-reset-small): 316 (-33%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,760	1,561	708	763	775 (-1%)
proof_construction_time_sha256_30_ms	11,860	3,170	1,408	1,439	1,466
proof_construction_time_sha256_100_ms	44,100	11,808	5,421	5,403	5,351
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0 (-3%)	58.0 (-2%)	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,528	419	202 (+1%)	226 (-1%)	267
proof_construction_time_poseidon_hash_100_ms	5,787	1,571	729 (+1%)	783 (-4%)	801 (+2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,476	9,472	9,476
l1_rollup_execution_gas	611,215	611,362	611,517
l2_block_processing_time_in_ms	761 (-2%)	1,412	2,697 (-1%)
l2_block_building_time_in_ms	20,819	41,469 (-2%)	81,656 (-1%)
l2_block_rollup_simulation_time_in_ms	20,818	41,468 (-2%)	81,656 (-1%)
l2_block_public_tx_process_time_in_ms	17,806	38,257 (-2%)	78,493 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,003 (-1%)	9,807 (-1%)
node_database_size_in_bytes	12,476,496	16,203,856
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	100 (-3%)	373 (-5%)	13,565 (+5%)	19,418	53,878	71,872 (-3%)	2,179 (-3%)	524,288
private-kernel-inner	304 (-2%)	841 (+4%)	50,606 (+2%)	80,374	53,878	71,872 (-3%)	2,179 (-3%)	2,097,152
private-kernel-tail	1,039 (-6%)	2,502 (-5%)	50,431 (+1%)	61,201	62,057	14,912	399	2,097,152
base-parity	6.23	1,547 (-3%)	2,747	128	64.0	2,208	2.00	131,072
root-parity	49.5 (+1%)	72.8 (+4%)	43,246 (+1%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	6,527 (-2%)	4,931 (-1%)	92,267	170,330	728	3,648	47.0	4,194,304
root-rollup	112 (+2%)	84.6 (+3%)	24,943 (+4%)	25,253	620	3,456	41.0	1,048,576
public-kernel-setup	543	2,419 (-2%)	43,559 (+2%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-app-logic	499 (-2%)	3,383 (-1%)	44,593 (-7%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-tail	1,142 (-1%)	27,037	175,996 (-5%)	399,014	10,014	14,912	399	8,388,608
private-kernel-reset-small	⚠️ 316 (-33%)	1,244 (+15%)	31,503 (+1%)	93,105 (-15%)	53,878	71,872 (-3%)	2,179 (-3%)	1,048,576
public-kernel-teardown	493	3,404 (-2%)	44,880 (-2%)	102,121	80,278	106,912	3,274	2,097,152
merge-rollup	29.8	N/A	N/A	16,486	728	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,408 (-1%)	54,315 (+2%)	N/A	N/A	106,912	3,274	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	8,792	394	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	8,792	24.1 (-1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	8,792	1,156	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	8,792	830 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	8,792	478	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	8,792	1,601 (-1%)	14,720	55,199 (+4%)	2,097,152	393
Token:privately_mint_private_note	1,280	8,792	608	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	8,792	236 (+2%)	14,720	11,308	524,288	393
Token:transfer	1,312	8,792	1,782	14,720	13,396 (+1%)	524,288	393
AuthRegistry:set_authorized (avm)	19,226	N/A	N/A	91,264	1,389 (+6%)	N/A	N/A
FPC:prepare_fee (avm)	26,668	N/A	N/A	91,328	2,941 (+2%)	N/A	N/A
Token:transfer_public (avm)	42,918	N/A	N/A	91,328	4,047 (+1%)	N/A	N/A
AuthRegistry:consume (avm)	33,104	N/A	N/A	91,264	3,112 (+9%)	N/A	N/A
FPC:pay_refund (avm)	36,833	N/A	N/A	91,296	24,330 (+2%)	N/A	N/A
Benchmarking:create_note	1,344	8,792	466	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	8,792	40.6	N/A	N/A	N/A	N/A
Token:unshield	1,376	8,792	1,452	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	8,792	1,988	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	67.2 (-1%)	13,790
GasToken:set_portal	16.1 (-3%)	3,339
Token:constructor	92.2	23,692
FPC:constructor	64.2 (+4%)	13,592
GasToken:mint_public	51.0 (+1%)	10,158
Token:mint_public	507	19,034
Token:assert_minter_and_mint	58.7 (+5%)	12,925
AuthRegistry:set_authorized	30.5 (-7%)	7,812
FPC:prepare_fee	119 (+11%)	15,062
Token:transfer_public	46.9 (+9%)	31,218
FPC:pay_refund	142 (+13%)	25,260
Benchmarking:increment_balance	2,190 (-1%)	15,267
Token:_increase_public_balance	54.6 (+2%)	15,006
FPC:pay_refund_with_shielded_rebate	112 (-3%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.163 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.603	0.517	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.3	75.6 (-2%)	131 (-2%)	244 (-1%)	470 (-3%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.494	0.464 (-2%)	0.450 (-1%)	0.442 (-1%)	0.438 (-2%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.5	111 (-3%)	182 (-2%)	351 (-1%)	693 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.502	0.499 (-3%)	0.482 (-1%)	0.476	0.475 (-2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.7 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.517 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,057	667,841

Transaction size based on fee payment method

| Metric | |
| - | |

LeilaWang · 2024-07-03T13:07:11Z

noir-projects/noir-protocol-circuits/crates/reset-kernel-lib/src/reset/transient_data.nr

+        // - For empty logs, we expect is_propagated to be true, making them part of the note_logs_kept.
+        //   index_hint might point them to the same empty note. This doesn't matter because we increment the value of 
+        //   note_logs_kept and ensure that the correct number of empty logs are present in the expected_note_logs.
+        let is_propagated = expected_note_hashes[index_hint].counter() == log.note_hash_counter;


The critical change to make sure all the note logs linked to a note hash must be removed if the note hash is removed.

sirasistant

Nice!

sirasistant · 2024-07-04T10:26:42Z

noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_reset.nr

        }.validate();

-        verify_squashed_transient_note_hashes_and_nullifiers(
+        // Validate output.


I think we can skip this if within unconstrained? To go a bit faster 🥳

Good point! Will change 😄

sirasistant

Yay! 🎉

…ier_counters

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.45.1</summary> ## [0.45.1](aztec-package-v0.45.0...aztec-package-v0.45.1) (2024-07-04) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.45.1</summary> ## [0.45.1](barretenberg.js-v0.45.0...barretenberg.js-v0.45.1) (2024-07-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.45.1</summary> ## [0.45.1](aztec-packages-v0.45.0...aztec-packages-v0.45.1) (2024-07-04) ### Features * Add support for fieldable in events ([#7310](#7310)) ([694cebc](694cebc)), closes [#6951](#6951) * **avm:** Use template engine for codegen ([#7299](#7299)) ([d4359a3](d4359a3)) * Build releases for `aarch64-unknown-linux-gnu` target (noir-lang/noir#5289) ([2ae17f2](2ae17f2)) * Create codeql.yml ([#7318](#7318)) ([11fcfd2](11fcfd2)) * Deploy l1 contracts on devnet ([#7306](#7306)) ([b8eef86](b8eef86)) * Implement trait dispatch in the comptime interpreter (noir-lang/noir#5376) ([ccfa69c](ccfa69c)) * Lsp "find all references" (noir-lang/noir#5395) ([10076d9](10076d9)) * Lsp rename struct (noir-lang/noir#5380) ([2ae17f2](2ae17f2)) * **lsp:** Allow function rename (noir-lang/noir#4294) ([ccfa69c](ccfa69c)) * Remove note hash nullifier counter. ([#7294](#7294)) ([c0c9144](c0c9144)) * Sync from aztec-packages (noir-lang/noir#5387) ([ccfa69c](ccfa69c)) * Sync from aztec-packages (noir-lang/noir#5401) ([10076d9](10076d9)) ### Bug Fixes * Correctly detect signed/unsigned integer overflows/underflows (noir-lang/noir#5375) ([10076d9](10076d9)) * **docs:** Fix broken docs link to gihtub (noir-lang/noir#5398) ([10076d9](10076d9)) * **docs:** Fix colour leak ([#7289](#7289)) ([d3388d4](d3388d4)) * Don't panic when using undefined variables in the interpreter (noir-lang/noir#5381) ([10076d9](10076d9)) * Go to definition from `use` statement (noir-lang/noir#5390) ([2ae17f2](2ae17f2)) * Go to definition from aliased use (noir-lang/noir#5396) ([10076d9](10076d9)) * ICE when using a comptime let variable in runtime code (noir-lang/noir#5391) ([10076d9](10076d9)) * Include artifacts in noir-contracts package.json ([#7339](#7339)) ([7dd87c7](7dd87c7)) * Only create d.ts files for contract artifacts ([#7307](#7307)) ([b5e2a67](b5e2a67)) * Remove event selector from unencrypted log ([#7309](#7309)) ([c6eb734](c6eb734)) * Remove panics in the interpreter when a builtin fails to type check (noir-lang/noir#5382) ([ccfa69c](ccfa69c)) * Replace expects in interpreter with errors (noir-lang/noir#5383) ([ccfa69c](ccfa69c)) * Replace std::HashMap with FxHashMap to fix frontend indeterminism (noir-lang/noir#5385) ([ccfa69c](ccfa69c)) * Truncate flamegraph text to the right ([#7333](#7333)) ([b7c6593](b7c6593)) ### Miscellaneous * Add bb-pilcom to rust analyzer ([#7317](#7317)) ([694e68e](694e68e)) * ARGS_HASH constants 64 -> 16 ([#7284](#7284)) ([c19029a](c19029a)) * **avm:** Basic stat collection ([#7283](#7283)) ([adf2331](adf2331)) * **avm:** Less code in prover and verifier ([#7302](#7302)) ([f401a9a](f401a9a)) * **avm:** Migrate lookups and permutations ([#7335](#7335)) ([56fe4fe](56fe4fe)) * **avm:** Migrate to template engine ([#7316](#7316)) ([0fbfe11](0fbfe11)) * **avm:** Re-ordering routines by opcode order ([#7298](#7298)) ([4bb512d](4bb512d)) * **avm:** Remove shifts from full row ([#7327](#7327)) ([4d641ee](4d641ee)) * Charge for more l2 gas costs ([#7157](#7157)) ([3ab00c4](3ab00c4)) * **docs:** Remove persona boxes from the landing page (noir-lang/noir#5400) ([10076d9](10076d9)) * Nuking "new" from names ([#7273](#7273)) ([b12c6cb](b12c6cb)) * Refactor conversion between `FieldElement` and signed integers (noir-lang/noir#5397) ([10076d9](10076d9)) * Replace relative paths to noir-protocol-circuits ([0124665](0124665)) * Replace relative paths to noir-protocol-circuits ([4007885](4007885)) * Update flamegraph script link ([#7329](#7329)) ([0ec83ee](0ec83ee)) * Use `mod.nr` files in stdlib (noir-lang/noir#5379) ([ccfa69c](ccfa69c)) </details> <details><summary>barretenberg: 0.45.1</summary> ## [0.45.1](barretenberg-v0.45.0...barretenberg-v0.45.1) (2024-07-04) ### Features * **avm:** Use template engine for codegen ([#7299](#7299)) ([d4359a3](d4359a3)) ### Miscellaneous * **avm:** Basic stat collection ([#7283](#7283)) ([adf2331](adf2331)) * **avm:** Less code in prover and verifier ([#7302](#7302)) ([f401a9a](f401a9a)) * **avm:** Migrate lookups and permutations ([#7335](#7335)) ([56fe4fe](56fe4fe)) * **avm:** Migrate to template engine ([#7316](#7316)) ([0fbfe11](0fbfe11)) * **avm:** Re-ordering routines by opcode order ([#7298](#7298)) ([4bb512d](4bb512d)) * **avm:** Remove shifts from full row ([#7327](#7327)) ([4d641ee](4d641ee)) * Nuking "new" from names ([#7273](#7273)) ([b12c6cb](b12c6cb)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.45.1</summary> ## [0.45.1](AztecProtocol/aztec-packages@aztec-package-v0.45.0...aztec-package-v0.45.1) (2024-07-04) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.45.1</summary> ## [0.45.1](AztecProtocol/aztec-packages@barretenberg.js-v0.45.0...barretenberg.js-v0.45.1) (2024-07-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.45.1</summary> ## [0.45.1](AztecProtocol/aztec-packages@aztec-packages-v0.45.0...aztec-packages-v0.45.1) (2024-07-04) ### Features * Add support for fieldable in events ([#7310](AztecProtocol/aztec-packages#7310)) ([694cebc](AztecProtocol/aztec-packages@694cebc)), closes [#6951](AztecProtocol/aztec-packages#6951) * **avm:** Use template engine for codegen ([#7299](AztecProtocol/aztec-packages#7299)) ([d4359a3](AztecProtocol/aztec-packages@d4359a3)) * Build releases for `aarch64-unknown-linux-gnu` target (noir-lang/noir#5289) ([2ae17f2](AztecProtocol/aztec-packages@2ae17f2)) * Create codeql.yml ([#7318](AztecProtocol/aztec-packages#7318)) ([11fcfd2](AztecProtocol/aztec-packages@11fcfd2)) * Deploy l1 contracts on devnet ([#7306](AztecProtocol/aztec-packages#7306)) ([b8eef86](AztecProtocol/aztec-packages@b8eef86)) * Implement trait dispatch in the comptime interpreter (noir-lang/noir#5376) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Lsp "find all references" (noir-lang/noir#5395) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Lsp rename struct (noir-lang/noir#5380) ([2ae17f2](AztecProtocol/aztec-packages@2ae17f2)) * **lsp:** Allow function rename (noir-lang/noir#4294) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Remove note hash nullifier counter. ([#7294](AztecProtocol/aztec-packages#7294)) ([c0c9144](AztecProtocol/aztec-packages@c0c9144)) * Sync from aztec-packages (noir-lang/noir#5387) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Sync from aztec-packages (noir-lang/noir#5401) ([10076d9](AztecProtocol/aztec-packages@10076d9)) ### Bug Fixes * Correctly detect signed/unsigned integer overflows/underflows (noir-lang/noir#5375) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * **docs:** Fix broken docs link to gihtub (noir-lang/noir#5398) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * **docs:** Fix colour leak ([#7289](AztecProtocol/aztec-packages#7289)) ([d3388d4](AztecProtocol/aztec-packages@d3388d4)) * Don't panic when using undefined variables in the interpreter (noir-lang/noir#5381) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Go to definition from `use` statement (noir-lang/noir#5390) ([2ae17f2](AztecProtocol/aztec-packages@2ae17f2)) * Go to definition from aliased use (noir-lang/noir#5396) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * ICE when using a comptime let variable in runtime code (noir-lang/noir#5391) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Include artifacts in noir-contracts package.json ([#7339](AztecProtocol/aztec-packages#7339)) ([7dd87c7](AztecProtocol/aztec-packages@7dd87c7)) * Only create d.ts files for contract artifacts ([#7307](AztecProtocol/aztec-packages#7307)) ([b5e2a67](AztecProtocol/aztec-packages@b5e2a67)) * Remove event selector from unencrypted log ([#7309](AztecProtocol/aztec-packages#7309)) ([c6eb734](AztecProtocol/aztec-packages@c6eb734)) * Remove panics in the interpreter when a builtin fails to type check (noir-lang/noir#5382) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Replace expects in interpreter with errors (noir-lang/noir#5383) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Replace std::HashMap with FxHashMap to fix frontend indeterminism (noir-lang/noir#5385) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) * Truncate flamegraph text to the right ([#7333](AztecProtocol/aztec-packages#7333)) ([b7c6593](AztecProtocol/aztec-packages@b7c6593)) ### Miscellaneous * Add bb-pilcom to rust analyzer ([#7317](AztecProtocol/aztec-packages#7317)) ([694e68e](AztecProtocol/aztec-packages@694e68e)) * ARGS_HASH constants 64 -> 16 ([#7284](AztecProtocol/aztec-packages#7284)) ([c19029a](AztecProtocol/aztec-packages@c19029a)) * **avm:** Basic stat collection ([#7283](AztecProtocol/aztec-packages#7283)) ([adf2331](AztecProtocol/aztec-packages@adf2331)) * **avm:** Less code in prover and verifier ([#7302](AztecProtocol/aztec-packages#7302)) ([f401a9a](AztecProtocol/aztec-packages@f401a9a)) * **avm:** Migrate lookups and permutations ([#7335](AztecProtocol/aztec-packages#7335)) ([56fe4fe](AztecProtocol/aztec-packages@56fe4fe)) * **avm:** Migrate to template engine ([#7316](AztecProtocol/aztec-packages#7316)) ([0fbfe11](AztecProtocol/aztec-packages@0fbfe11)) * **avm:** Re-ordering routines by opcode order ([#7298](AztecProtocol/aztec-packages#7298)) ([4bb512d](AztecProtocol/aztec-packages@4bb512d)) * **avm:** Remove shifts from full row ([#7327](AztecProtocol/aztec-packages#7327)) ([4d641ee](AztecProtocol/aztec-packages@4d641ee)) * Charge for more l2 gas costs ([#7157](AztecProtocol/aztec-packages#7157)) ([3ab00c4](AztecProtocol/aztec-packages@3ab00c4)) * **docs:** Remove persona boxes from the landing page (noir-lang/noir#5400) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Nuking "new" from names ([#7273](AztecProtocol/aztec-packages#7273)) ([b12c6cb](AztecProtocol/aztec-packages@b12c6cb)) * Refactor conversion between `FieldElement` and signed integers (noir-lang/noir#5397) ([10076d9](AztecProtocol/aztec-packages@10076d9)) * Replace relative paths to noir-protocol-circuits ([0124665](AztecProtocol/aztec-packages@0124665)) * Replace relative paths to noir-protocol-circuits ([4007885](AztecProtocol/aztec-packages@4007885)) * Update flamegraph script link ([#7329](AztecProtocol/aztec-packages#7329)) ([0ec83ee](AztecProtocol/aztec-packages@0ec83ee)) * Use `mod.nr` files in stdlib (noir-lang/noir#5379) ([ccfa69c](AztecProtocol/aztec-packages@ccfa69c)) </details> <details><summary>barretenberg: 0.45.1</summary> ## [0.45.1](AztecProtocol/aztec-packages@barretenberg-v0.45.0...barretenberg-v0.45.1) (2024-07-04) ### Features * **avm:** Use template engine for codegen ([#7299](AztecProtocol/aztec-packages#7299)) ([d4359a3](AztecProtocol/aztec-packages@d4359a3)) ### Miscellaneous * **avm:** Basic stat collection ([#7283](AztecProtocol/aztec-packages#7283)) ([adf2331](AztecProtocol/aztec-packages@adf2331)) * **avm:** Less code in prover and verifier ([#7302](AztecProtocol/aztec-packages#7302)) ([f401a9a](AztecProtocol/aztec-packages@f401a9a)) * **avm:** Migrate lookups and permutations ([#7335](AztecProtocol/aztec-packages#7335)) ([56fe4fe](AztecProtocol/aztec-packages@56fe4fe)) * **avm:** Migrate to template engine ([#7316](AztecProtocol/aztec-packages#7316)) ([0fbfe11](AztecProtocol/aztec-packages@0fbfe11)) * **avm:** Re-ordering routines by opcode order ([#7298](AztecProtocol/aztec-packages#7298)) ([4bb512d](AztecProtocol/aztec-packages@4bb512d)) * **avm:** Remove shifts from full row ([#7327](AztecProtocol/aztec-packages#7327)) ([4d641ee](AztecProtocol/aztec-packages@4d641ee)) * Nuking "new" from names ([#7273](AztecProtocol/aztec-packages#7273)) ([b12c6cb](AztecProtocol/aztec-packages@b12c6cb)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

LeilaWang added 2 commits July 3, 2024 08:30

Remove note hash nullifier counter.

098b7d6

Merge remote-tracking branch 'origin/master' into lw/note_hash_nullif…

bc7518f

…ier_counters

LeilaWang marked this pull request as ready for review July 3, 2024 13:03

LeilaWang commented Jul 3, 2024

View reviewed changes

Build private reset circuit output in noir.

db28db7

sirasistant approved these changes Jul 4, 2024

View reviewed changes

Validate output of reset only when constrained.

b859d30

sirasistant approved these changes Jul 4, 2024

View reviewed changes

Merge remote-tracking branch 'origin/master' into lw/note_hash_nullif…

fb7331c

…ier_counters

LeilaWang enabled auto-merge (squash) July 4, 2024 11:23

LeilaWang merged commit c0c9144 into master Jul 4, 2024
89 checks passed

LeilaWang deleted the lw/note_hash_nullifier_counters branch July 4, 2024 11:37

AztecBot mentioned this pull request Jul 4, 2024

chore(master): Release 0.45.1 #7292

Merged

LeilaWang mentioned this pull request Jul 9, 2024

Remove note hash's nullifier counter. #7250

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove note hash nullifier counter. #7294

feat: remove note hash nullifier counter. #7294

LeilaWang commented Jul 3, 2024 •

edited

Loading

github-actions bot commented Jul 3, 2024 •

edited

Loading

AztecBot commented Jul 3, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LeilaWang Jul 3, 2024

sirasistant left a comment

sirasistant Jul 4, 2024

LeilaWang Jul 4, 2024

sirasistant left a comment

feat: remove note hash nullifier counter. #7294

feat: remove note hash nullifier counter. #7294

Conversation

LeilaWang commented Jul 3, 2024 • edited Loading

github-actions bot commented Jul 3, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

AztecBot commented Jul 3, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LeilaWang Jul 3, 2024

Choose a reason for hiding this comment

sirasistant left a comment

Choose a reason for hiding this comment

sirasistant Jul 4, 2024

Choose a reason for hiding this comment

LeilaWang Jul 4, 2024

Choose a reason for hiding this comment

sirasistant left a comment

Choose a reason for hiding this comment

LeilaWang commented Jul 3, 2024 •

edited

Loading

github-actions bot commented Jul 3, 2024 •

edited

Loading

AztecBot commented Jul 3, 2024 •

edited

Loading