feat: simple sparse commitment

barretenberg/cpp/scripts/analyze_client_ivc_bench.py

@@ -71,10 +71,35 @@
     print(f"{key:<{max_label_length}}{time_ms:>8.0f}  {time_ms/total_time_ms:>8.2%}")
 
 
-# Relations breakdown
-# Note: The timings here are off likely because the tracking is occuring in a hot loop but 
-# they should be meaningful relative to one another
-print('\nRelation contributions (times to be interpreted relatively):')
+# Extract a set of components from the benchmark data and display timings and relative percentages 
+def print_contributions(prefix, ivc_bench_json, bench_name, components):
+
+    # Read JSON file and extract benchmark
+    try:
+        with open(prefix / ivc_bench_json, "r") as read_file:
+            read_result = json.load(read_file)
+            bench = next((_bench for _bench in read_result["benchmarks"] if _bench["name"] == bench_name), None)
+            if not bench:
+                raise ValueError(f"Benchmark '{bench_name}' not found in the JSON file.")
+    except FileNotFoundError:
+        print(f"File not found: {prefix / ivc_bench_json}")
+        return
+
+    # Filter and sum up kept times
+    bench_components = {key: bench[key] for key in components if key in bench}
+    sum_of_kept_times_ms = sum(float(time) for time in bench_components.values()) / 1e6
+    print(f"Total time accounted for (ms): {sum_of_kept_times_ms:>8.0f}")
+
+    # Print results
+    max_label_length = max(len(label) for label in components)
+    column_headers = {"operation": "operation", "ms": "ms", "%": "% sum"}
+    print(f"{column_headers['operation']:<{max_label_length}}{column_headers['ms']:>8}  {column_headers['%']:>8}")
+
+    for key in components:
+        time_ms = bench_components.get(key, 0) / 1e6
+        percentage = time_ms / sum_of_kept_times_ms if sum_of_kept_times_ms > 0 else 0
+        print(f"{key:<{max_label_length}}{time_ms:>8.0f}  {percentage:>8.2%}")
+
 relations = [
     "Arithmetic::accumulate(t)",
     "Permutation::accumulate(t)",
@@ -87,23 +112,19 @@
     "PoseidonExt::accumulate(t)",
     "PoseidonInt::accumulate(t)",
 ]
-with open(PREFIX/IVC_BENCH_JSON, "r") as read_file:
-    read_result = json.load(read_file)
-    for _bench in read_result["benchmarks"]:
-        if _bench["name"] == BENCHMARK:
-            bench = _bench
-bench_components = dict(filter(lambda x: x[0] in relations, bench.items()))
 
-# For each kept time, get the proportion over all kept times.
-sum_of_kept_times_ms = sum(float(time)
-                           for _, time in bench_components.items())/1e6
-max_label_length = max(len(label) for label in relations)
-column = {"function": "function", "ms": "ms", "%": "% sum"}
-print(
-    f"{column['function']:<{max_label_length}}{column['ms']:>8}  {column['%']:>8}")
-for key in relations:
-    if key not in bench:
-        time_ms = 0
-    else:
-        time_ms = bench[key]/1e6
-    print(f"{key:<{max_label_length}}{time_ms:>8.0f}  {time_ms/sum_of_kept_times_ms:>8.2%}")
+print('\nRelation contributions (times to be interpreted relatively):')
+print_contributions(PREFIX, IVC_BENCH_JSON, BENCHMARK, relations)
+
+commitments = [
+    "COMMIT::wires(t)",
+    "COMMIT::z_perm(t)",
+    "COMMIT::databus(t)",
+    "COMMIT::ecc_op_wires(t)",
+    "COMMIT::lookup_inverses(t)",
+    "COMMIT::databus_inverses(t)",
+    "COMMIT::lookup_counts_tags(t)",
+]
+
+print('\nCommitment contributions:')
+print_contributions(PREFIX, IVC_BENCH_JSON, BENCHMARK, commitments)

barretenberg/cpp/src/barretenberg/commitment_schemes/commit.bench.cpp

@@ -7,25 +7,137 @@ namespace bb {
 
 template <typename Curve> std::shared_ptr<CommitmentKey<Curve>> create_commitment_key(const size_t num_points)
 {
+    bb::srs::init_crs_factory("../srs_db/ignition");
     std::string srs_path;
     return std::make_shared<CommitmentKey<Curve>>(num_points);
 }
 
-constexpr size_t MAX_LOG_NUM_POINTS = 24;
-constexpr size_t MAX_NUM_POINTS = 1 << MAX_LOG_NUM_POINTS;
+// Generate a polynomial with a specified number of nonzero random coefficients
+template <typename FF> Polynomial<FF> sparse_random_poly(const size_t size, const size_t num_nonzero)
+{
+    auto& engine = numeric::get_debug_randomness();
+    auto polynomial = Polynomial<FF>(size);
+
+    for (size_t i = 0; i < num_nonzero; i++) {
+        size_t idx = engine.get_random_uint32() % size;
+        polynomial[idx] = FF::random_element();
+    }
 
-auto key = create_commitment_key<curve::BN254>(MAX_NUM_POINTS);
+    return polynomial;
+}
+
+constexpr size_t MAX_LOG_NUM_POINTS = 18;
+constexpr size_t MAX_NUM_POINTS = 1 << MAX_LOG_NUM_POINTS;
+constexpr size_t SPARSE_NUM_NONZERO = 5;
 
-template <typename Curve> void bench_commit(::benchmark::State& state)
+// Commit to a zero polynomial
+template <typename Curve> void bench_commit_zero(::benchmark::State& state)
 {
+    auto key = create_commitment_key<Curve>(MAX_NUM_POINTS);
+
     const size_t num_points = 1 << state.range(0);
     const auto polynomial = Polynomial<typename Curve::ScalarField>(num_points);
     for (auto _ : state) {
-        benchmark::DoNotOptimize(key->commit(polynomial));
+        key->commit(polynomial);
+    }
+}
+
+// Commit to a polynomial with sparse nonzero entries equal to 1
+template <typename Curve> void bench_commit_sparse(::benchmark::State& state)
+{
+    using Fr = typename Curve::ScalarField;
+    auto key = create_commitment_key<Curve>(MAX_NUM_POINTS);
+
+    const size_t num_points = 1 << state.range(0);
+    const size_t num_nonzero = SPARSE_NUM_NONZERO;
+
+    auto polynomial = Polynomial<Fr>(num_points);
+    for (size_t i = 0; i < num_nonzero; i++) {
+        polynomial[i] = 1;
+    }
+
+    for (auto _ : state) {
+        key->commit(polynomial);
+    }
+}
+
+// Commit to a polynomial with sparse nonzero entries equal to 1 using the commit_sparse method to preprocess the input
+template <typename Curve> void bench_commit_sparse_preprocessed(::benchmark::State& state)
+{
+    using Fr = typename Curve::ScalarField;
+    auto key = create_commitment_key<Curve>(MAX_NUM_POINTS);
+
+    const size_t num_points = 1 << state.range(0);
+    const size_t num_nonzero = SPARSE_NUM_NONZERO;
+
+    auto polynomial = Polynomial<Fr>(num_points);
+    for (size_t i = 0; i < num_nonzero; i++) {
+        polynomial[i] = 1;
+    }
+
+    for (auto _ : state) {
+        key->commit_sparse(polynomial);
+    }
+}
+
+// Commit to a polynomial with sparse random nonzero entries
+template <typename Curve> void bench_commit_sparse_random(::benchmark::State& state)
+{
+    using Fr = typename Curve::ScalarField;
+    auto key = create_commitment_key<Curve>(MAX_NUM_POINTS);
+
+    const size_t num_points = 1 << state.range(0);
+    const size_t num_nonzero = SPARSE_NUM_NONZERO;
+
+    auto polynomial = sparse_random_poly<Fr>(num_points, num_nonzero);
+
+    for (auto _ : state) {
+        key->commit(polynomial);
+    }
+}
+
+// Commit to a polynomial with sparse random nonzero entries using the commit_sparse method to preprocess the input
+template <typename Curve> void bench_commit_sparse_random_preprocessed(::benchmark::State& state)
+{
+    using Fr = typename Curve::ScalarField;
+    auto key = create_commitment_key<Curve>(MAX_NUM_POINTS);
+
+    const size_t num_points = 1 << state.range(0);
+    const size_t num_nonzero = SPARSE_NUM_NONZERO;
+
+    auto polynomial = sparse_random_poly<Fr>(num_points, num_nonzero);
+
+    for (auto _ : state) {
+        key->commit_sparse(polynomial);
+    }
+}
+
+// Commit to a polynomial with dense random nonzero entries
+template <typename Curve> void bench_commit_random(::benchmark::State& state)
+{
+    using Fr = typename Curve::ScalarField;
+    auto key = create_commitment_key<Curve>(MAX_NUM_POINTS);
+
+    const size_t num_points = 1 << state.range(0);
+    auto polynomial = Polynomial<Fr>(num_points);
+    for (auto& coeff : polynomial) {
+        coeff = Fr::random_element();
+    }
+    for (auto _ : state) {
+        key->commit(polynomial);
     }
 }
 
-BENCHMARK(bench_commit<curve::BN254>)->DenseRange(10, MAX_LOG_NUM_POINTS)->Unit(benchmark::kMillisecond);
+BENCHMARK(bench_commit_zero<curve::BN254>)->DenseRange(14, MAX_LOG_NUM_POINTS)->Unit(benchmark::kMillisecond);
+BENCHMARK(bench_commit_sparse<curve::BN254>)->DenseRange(14, MAX_LOG_NUM_POINTS)->Unit(benchmark::kMillisecond);
+BENCHMARK(bench_commit_sparse_preprocessed<curve::BN254>)
+    ->DenseRange(14, MAX_LOG_NUM_POINTS)
+    ->Unit(benchmark::kMillisecond);
+BENCHMARK(bench_commit_sparse_random<curve::BN254>)->DenseRange(14, MAX_LOG_NUM_POINTS)->Unit(benchmark::kMillisecond);
+BENCHMARK(bench_commit_sparse_random_preprocessed<curve::BN254>)
+    ->DenseRange(14, MAX_LOG_NUM_POINTS)
+    ->Unit(benchmark::kMillisecond);
+BENCHMARK(bench_commit_random<curve::BN254>)->DenseRange(14, MAX_LOG_NUM_POINTS)->Unit(benchmark::kMillisecond);
 
 } // namespace bb
 

barretenberg/cpp/src/barretenberg/commitment_schemes/commitment_key.hpp

@@ -18,6 +18,7 @@
 
 #include <cstddef>
 #include <memory>
+#include <ranges>
 #include <string_view>
 
 namespace bb {
@@ -34,6 +35,7 @@ template <class Curve> class CommitmentKey {
 
     using Fr = typename Curve::ScalarField;
     using Commitment = typename Curve::AffineElement;
+    using G1 = typename Curve::AffineElement;
 
   public:
     scalar_multiplication::pippenger_runtime_state<Curve> pippenger_runtime_state;
@@ -81,6 +83,65 @@ template <class Curve> class CommitmentKey {
         return scalar_multiplication::pippenger_unsafe<Curve>(
             const_cast<Fr*>(polynomial.data()), srs->get_monomial_points(), degree, pippenger_runtime_state);
     };
+
+    /**
+     * @brief Efficiently commit to a sparse polynomial
+     * @details Iterate through the {point, scalar} pairs that define the inputs to the commitment MSM, maintain (copy)
+     * only those for which the scalar is nonzero, then perform the MSM on the reduced inputs.
+     * @warning Method makes a copy of all {point, scalar} pairs that comprise the reduced input. Will not be efficient
+     * in terms of memory or computation for polynomials beyond a certain sparseness threshold.
+     *
+     * @param polynomial
+     * @return Commitment
+     */
+    Commitment commit_sparse(std::span<const Fr> polynomial)
+    {
+        // BB_OP_COUNT_TIME();
+        const size_t degree = polynomial.size();
+        ASSERT(degree <= srs->get_monomial_size());
+
+        // Extract the precomputed point table (contains raw SRS points at even indices and the corresponding
+        // endomorphism point (\beta*x, -y) at odd indices).
+        G1* point_table = srs->get_monomial_points();
+
+        // Define structures needed to multithread the extraction of non-zero inputs
+        const size_t num_threads = degree >= get_num_cpus_pow2() ? get_num_cpus_pow2() : 1;
+        const size_t block_size = degree / num_threads;
+        std::vector<std::vector<Fr>> thread_scalars(num_threads);
+        std::vector<std::vector<G1>> thread_points(num_threads);
+
+        // Loop over all polynomial coefficients and keep {point, scalar} pairs for which scalar != 0
+        parallel_for(num_threads, [&](size_t thread_idx) {
+            const size_t start = thread_idx * block_size;
+            const size_t end = (thread_idx + 1) * block_size;
+
+            for (size_t idx = start; idx < end; ++idx) {
+
+                const Fr& scalar = polynomial[idx];
+
+                if (!scalar.is_zero()) {
+                    thread_scalars[thread_idx].emplace_back(scalar);
+                    // Save both the raw srs point and the precomputed endomorphism point from the point table
+                    const G1& point = point_table[idx * 2];
+                    const G1& endo_point = point_table[idx * 2 + 1];
+                    thread_points[thread_idx].emplace_back(point);
+                    thread_points[thread_idx].emplace_back(endo_point);
+                }
+            }
+        });
+
+        // Reconstruct the full input to the pippenger from the individual threads
+        std::vector<Fr> scalars;
+        std::vector<G1> points;
+        for (size_t idx = 0; idx < num_threads; ++idx) {
+            scalars.insert(scalars.end(), thread_scalars[idx].begin(), thread_scalars[idx].end());
+            points.insert(points.end(), thread_points[idx].begin(), thread_points[idx].end());
+        }
+
+        // Call the version of pippenger which assumes all points are distinct
+        return scalar_multiplication::pippenger_unsafe<Curve>(
+            scalars.data(), points.data(), scalars.size(), pippenger_runtime_state);
+    }
 };
 
 } // namespace bb

barretenberg/cpp/src/barretenberg/commitment_schemes/processed_commitment.test.cpp

@@ -0,0 +1,69 @@
+#include "barretenberg/commitment_schemes/commitment_key.hpp"
+#include "barretenberg/polynomials/polynomial.hpp"
+#include "barretenberg/srs/factories/file_crs_factory.hpp"
+
+#include <gtest/gtest.h>
+
+namespace bb {
+
+template <typename Curve> class CommitmentKeyTest : public ::testing::Test {
+    using CK = CommitmentKey<Curve>;
+
+    using Fr = typename Curve::ScalarField;
+    using Commitment = typename Curve::AffineElement;
+    using Polynomial = bb::Polynomial<Fr>;
+
+  public:
+    template <class CK> inline std::shared_ptr<CK> create_commitment_key(size_t num_points);
+};
+
+template <>
+template <>
+std::shared_ptr<CommitmentKey<curve::BN254>> CommitmentKeyTest<curve::BN254>::create_commitment_key<
+    CommitmentKey<curve::BN254>>(const size_t num_points)
+{
+    srs::init_crs_factory("../srs_db/ignition");
+    return std::make_shared<CommitmentKey<curve::BN254>>(num_points);
+}
+
+template <>
+template <>
+std::shared_ptr<CommitmentKey<curve::Grumpkin>> CommitmentKeyTest<curve::Grumpkin>::create_commitment_key<
+    CommitmentKey<curve::Grumpkin>>(const size_t num_points)
+{
+    srs::init_grumpkin_crs_factory("../srs_db/grumpkin");
+    return std::make_shared<CommitmentKey<curve::Grumpkin>>(num_points);
+}
+
+using Curves = ::testing::Types<curve::BN254, curve::Grumpkin>;
+
+TYPED_TEST_SUITE(CommitmentKeyTest, Curves);
+
+// Check that commit and commit_sparse return the same result for a random sparse polynomial
+TYPED_TEST(CommitmentKeyTest, CommitSparse)
+{
+    using Curve = TypeParam;
+    using CK = CommitmentKey<Curve>;
+    using G1 = Curve::AffineElement;
+    using Fr = Curve::ScalarField;
+    using Polynomial = bb::Polynomial<Fr>;
+
+    const size_t num_points = 1 << 12; // large enough to ensure normal pippenger logic is used
+    const size_t num_nonzero = 7;
+
+    // Construct a sparse random polynomial
+    Polynomial poly{ num_points };
+    for (size_t i = 0; i < num_nonzero; ++i) {
+        size_t idx = (i + 1) * (i + 1) % num_points;
+        poly[idx] = Fr::random_element();
+    }
+
+    // Commit to the polynomial using both the conventional commit method and the sparse commitment method
+    auto key = TestFixture::template create_commitment_key<CK>(num_points);
+    G1 commit_result = key->commit(poly);
+    G1 sparse_commit_result = key->commit_sparse(poly);
+
+    EXPECT_EQ(sparse_commit_result, commit_result);
+}
+
+} // namespace bb