Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs hashes in L2Block.getCalldataHash #760

Merged
merged 8 commits into from
Jun 8, 2023
Merged

Logs hashes in L2Block.getCalldataHash #760

merged 8 commits into from
Jun 8, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jun 6, 2023 •
edited
Loading

Description

Fixes #748

  • sneaked in improved Decoder test and updated jest config.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan marked this pull request as draft June 6, 2023 13:33
@benesjan benesjan force-pushed the janb/logs-in-getcalldatahash branch from 75e22c5 to ae0a7e4 Compare June 6, 2023 13:38
@benesjan benesjan force-pushed the janb/logs-in-getcalldatahash branch from ae0a7e4 to 0d3bcc8 Compare June 7, 2023 12:45
@benesjan benesjan requested a review from spypsy June 7, 2023 14:57
@benesjan benesjan marked this pull request as ready for review June 7, 2023 14:58
spypsy
spypsy approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@spypsy spypsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benesjan benesjan merged commit 8ffad9b into master Jun 8, 2023
@benesjan benesjan deleted the janb/logs-in-getcalldatahash branch June 8, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spypsy spypsy spypsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update L2Block.getCalldataHash with logs hashes
2 participants
@benesjan @spypsy