Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more fixes for networks #7870

Merged
merged 2 commits into from
Aug 9, 2024
Merged

fix: more fixes for networks #7870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
155ab00
fix: read correct env vars
alexghr Aug 8, 2024
f2b3f2e
fix: don't retry public VM proofs
alexghr Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions yarn-project/aztec/src/cli/aztec_start_options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,16 +134,16 @@ export const aztecStartOptions: { [key: string]: AztecStartOption[] } = {
envVar: 'AVAILABILITY_ORACLE_CONTRACT_ADDRESS',
},
{
flag: '--gas-token-address <value>',
flag: '--fee-juice-address <value>',
description: 'The deployed L1 gas token contract address',
defaultValue: undefined,
envVar: 'GAS_TOKEN_CONTRACT_ADDRESS',
envVar: 'FEE_JUICE_CONTRACT_ADDRESS',
},
{
flag: '--gas-portal-address <value>',
flag: '--fee-juice-portal-address <value>',
description: 'The deployed L1 gas portal contract address',
defaultValue: undefined,
envVar: 'GAS_PORTAL_CONTRACT_ADDRESS',
envVar: 'FEE_JUICE_PORTAL_CONTRACT_ADDRESS',
},
],
// We can't easily auto-generate node options as they're parts of modules defined below
Expand Down
3 changes: 2 additions & 1 deletion yarn-project/prover-client/src/prover-agent/memory-proving-queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ export class MemoryProvingQueue implements ServerCircuitProver, ProvingJobSource
return Promise.resolve();
}

if (job.attempts < MAX_RETRIES) {
// every job should be retried with the exception of the public VM since its in development and can fail
if (job.attempts < MAX_RETRIES && job.request.type !== ProvingRequestType.PUBLIC_VM) {
job.attempts++;
this.log.warn(
`Job id=${job.id} type=${ProvingRequestType[job.request.type]} failed with error: ${err}. Retry ${
Expand Down
Loading