Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Docker.dockerignore file can be huge. #8023

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

charlielye
Copy link
Contributor

We run into some nutty error when dockerignore files get large (circleci path):

#3 [internal] load metadata for docker.io/library/ubuntu:noble
#3 sha256:afb7fa05fafd7c9e9fe1ecefd45ae0531e51b736cd519c2fb8893340e4e08b59
#3 DONE 0.4s

#10 [internal] load build context
#10 sha256:8189bdeed2ad9e316ae51d8dddc8d96a01e5180ee99f9f37015f7c3dc8de7e41
#10 ERROR: rpc error: code = Internal desc = header list size to send violates the maximum size (1048896 bytes) set by server

This became the case with avm-transpiler as it's build context is the root of the monorepo so it can gain access to the noir source code. The autogenerated dockerignore file has to explicitly list every file in he monorepo as a reverse match which eventually got so big something broke internally to docker.

New script will not autogen the dockerignore file if its committed to git. This PR includes a manually crafted one for avm-transpiler.

@rahul-kothari rahul-kothari enabled auto-merge (squash) August 15, 2024 16:11
@rahul-kothari rahul-kothari merged commit cee9d9a into master Aug 15, 2024
93 of 94 checks passed
@rahul-kothari rahul-kothari deleted the cl/dockerignore-fix branch August 15, 2024 16:37
rahul-kothari pushed a commit that referenced this pull request Aug 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.49.1</summary>

##
[0.49.1](aztec-package-v0.49.0...aztec-package-v0.49.1)
(2024-08-15)


### Miscellaneous

* Sync alphanet back to master
([#7970](#7970))
([523724d](523724d))
</details>

<details><summary>barretenberg.js: 0.49.1</summary>

##
[0.49.1](barretenberg.js-v0.49.0...barretenberg.js-v0.49.1)
(2024-08-15)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.49.1</summary>

##
[0.49.1](aztec-packages-v0.49.0...aztec-packages-v0.49.1)
(2024-08-15)


### Features

* Add pending reorg chain resistance in contracts
([#7926](#7926))
([f769f84](f769f84))
* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](#8016))
([5801732](5801732))


### Bug Fixes

* Docker.dockerignore file can be huge.
([#8023](#8023))
([cee9d9a](cee9d9a))
* Forking world state in prover-node
([#7995](#7995))
([ebffe96](ebffe96))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](#8010))
([3ad6dd9](3ad6dd9))
* Private reset kernel
([#7984](#7984))
([0d82c79](0d82c79))
* Sync alphanet back to master
([#7970](#7970))
([523724d](523724d))
</details>

<details><summary>barretenberg: 0.49.1</summary>

##
[0.49.1](barretenberg-v0.49.0...barretenberg-v0.49.1)
(2024-08-15)


### Features

* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](#8016))
([5801732](5801732))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](#8010))
([3ad6dd9](3ad6dd9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Aug 16, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@aztec-package-v0.49.0...aztec-package-v0.49.1)
(2024-08-15)


### Miscellaneous

* Sync alphanet back to master
([#7970](AztecProtocol/aztec-packages#7970))
([523724d](AztecProtocol/aztec-packages@523724d))
</details>

<details><summary>barretenberg.js: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@barretenberg.js-v0.49.0...barretenberg.js-v0.49.1)
(2024-08-15)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@aztec-packages-v0.49.0...aztec-packages-v0.49.1)
(2024-08-15)


### Features

* Add pending reorg chain resistance in contracts
([#7926](AztecProtocol/aztec-packages#7926))
([f769f84](AztecProtocol/aztec-packages@f769f84))
* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](AztecProtocol/aztec-packages#8016))
([5801732](AztecProtocol/aztec-packages@5801732))


### Bug Fixes

* Docker.dockerignore file can be huge.
([#8023](AztecProtocol/aztec-packages#8023))
([cee9d9a](AztecProtocol/aztec-packages@cee9d9a))
* Forking world state in prover-node
([#7995](AztecProtocol/aztec-packages#7995))
([ebffe96](AztecProtocol/aztec-packages@ebffe96))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](AztecProtocol/aztec-packages#8010))
([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9))
* Private reset kernel
([#7984](AztecProtocol/aztec-packages#7984))
([0d82c79](AztecProtocol/aztec-packages@0d82c79))
* Sync alphanet back to master
([#7970](AztecProtocol/aztec-packages#7970))
([523724d](AztecProtocol/aztec-packages@523724d))
</details>

<details><summary>barretenberg: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@barretenberg-v0.49.0...barretenberg-v0.49.1)
(2024-08-15)


### Features

* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](AztecProtocol/aztec-packages#8016))
([5801732](AztecProtocol/aztec-packages@5801732))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](AztecProtocol/aztec-packages#8010))
([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants