-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Revert to current date as timestamp for devnet #8193
Conversation
When running devnet, using the slot timestamps instead of current timestmap meant that blocks were often generated with a timestamp much into the future. This screwed up settings such as the min and max time between blocks for a sequencer configuration. In addition, the custom block timestamp interval in anvil meant that we could no longer rely on L1 timestamps for measuring time, which was needed for tracking the time between a block being submitted and its proof. This PR changes timestamps if devnet is set so that we use the current timestamp for building blocks, do not alter anvil's block timestamp, and drop time validations.
4780b21
to
a23cc41
Compare
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 8 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
AVM SimulationTime to simulate various public functions in the AVM.
Public DB AccessTime to access various public DBs.
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | |
Closing in favor of #8211 |
When running devnet, using the slot timestamps instead of current timestmap meant that blocks were often generated with a timestamp much into the future. This screwed up settings such as the min and max time between blocks for a sequencer configuration, which relied on L2 timestamps. In addition, the custom block timestamp interval in anvil meant that we could no longer rely on L1 timestamps for measuring time, which was needed for tracking the time between a block being submitted and its proof.
This PR changes timestamps if devnet is set so that we use the current timestamp for building blocks, do not alter anvil's block timestamp, and drop time validations.