-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixes for the nightly test run against Sepolia #8229
Changes from 11 commits
50ccf6e
542c51b
ae2b75b
f90afec
e185700
5ff1bb4
ea696d6
4f4de35
e236e90
df36f0e
1c29a6b
9903f2f
b9f0c5b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -14,11 +14,14 @@ env: | |||||
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||||||
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||||||
|
||||||
# Uncomment the following to run against Sepolia | ||||||
# SEQ_PUBLISHER_PRIVATE_KEY: ${{ secrets.SEPOLIA_SEQ_PRIVATE_KEY }} | ||||||
# PROVER_PUBLISHER_PRIVATE_KEY: ${{ secrets.SEPOLIA_PROVER_PRIVATE_KEY }} | ||||||
# ETHEREUM_HOST: 'https://sepolia.infura.io/v3/${{ secrets.SEPOLIA_API_KEY }}'; | ||||||
# L1_CHAIN_ID: '11155111' # Sepolia Chain ID | ||||||
# Address 0x652575Ff941e7c2850fB89f2B207efF6B06BC7B4 | ||||||
SEQ_PUBLISHER_PRIVATE_KEY: ${{ secrets.SEPOLIA_SEQ_PRIVATE_KEY }} | ||||||
|
||||||
# Address 0xE3b8F9F23b8D4BD7d437218Bff3bcED1ce5E70B3 | ||||||
PROVER_PUBLISHER_PRIVATE_KEY: ${{ secrets.SEPOLIA_PROVER_PRIVATE_KEY }} | ||||||
|
||||||
ETHEREUM_HOST: "https://sepolia.infura.io/v3/${{ secrets.SEPOLIA_API_KEY }}" | ||||||
L1_CHAIN_ID: "11155111" | ||||||
|
||||||
jobs: | ||||||
setup: | ||||||
|
@@ -28,11 +31,11 @@ jobs: | |||||
runner_type: builder-x86 | ||||||
secrets: inherit | ||||||
|
||||||
build: | ||||||
build-and-test: | ||||||
needs: setup | ||||||
runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86 | ||||||
outputs: | ||||||
e2e_list: ${{ steps.e2e_list.outputs.list }} | ||||||
# outputs: | ||||||
# e2e_list: ${{ steps.e2e_list.outputs.list }} | ||||||
steps: | ||||||
- uses: actions/checkout@v4 | ||||||
with: | ||||||
|
@@ -47,37 +50,47 @@ jobs: | |||||
run: | | ||||||
earthly-ci ./yarn-project+export-e2e-test-images | ||||||
|
||||||
- name: Create list of testnet end-to-end jobs | ||||||
id: e2e_list | ||||||
run: echo "list=$(earthly ls ./yarn-project/end-to-end | grep 'public-testnet' | sed 's/+//' | jq -R . | jq -cs .)" >> $GITHUB_OUTPUT | ||||||
|
||||||
e2e: | ||||||
needs: build | ||||||
runs-on: ubuntu-20.04 | ||||||
strategy: | ||||||
fail-fast: false | ||||||
matrix: | ||||||
test: ${{ fromJson( needs.build.outputs.e2e_list )}} | ||||||
steps: | ||||||
- uses: actions/checkout@v4 | ||||||
with: { ref: "${{ env.GIT_COMMIT }}" } | ||||||
- uses: ./.github/ci-setup-action | ||||||
with: | ||||||
# must be globally unique for build x runner | ||||||
concurrency_key: public-testnet-x86 | ||||||
- name: Setup and Test | ||||||
- name: Run Testnet Test | ||||||
timeout-minutes: 40 | ||||||
uses: ./.github/ensure-tester-with-images | ||||||
with: | ||||||
runner_type: "8core-tester-x86" | ||||||
builder_type: builder-x86 | ||||||
# these are copied to the tester and expected by the earthly command below | ||||||
# if they fail to copy, it will try to build them on the tester and fail | ||||||
builder_images_to_copy: aztecprotocol/end-to-end:${{ env.GIT_COMMIT }} | ||||||
# command to produce the images in case they don't exist | ||||||
builder_command: scripts/earthly-ci ./yarn-project+export-e2e-test-images | ||||||
run: | | ||||||
set -eux | ||||||
cd ./yarn-project/end-to-end/ | ||||||
export FORCE_COLOR=1 | ||||||
../../scripts/earthly-ci -P --no-output +${{ matrix.test }} | ||||||
#id: e2e_list | ||||||
# run: echo "list=$(earthly ls ./yarn-project/end-to-end | grep 'public-testnet' | sed 's/+//' | jq -R . | jq -cs .)" >> $GITHUB_OUTPUT | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
run: | | ||||||
set -eux | ||||||
cd ./yarn-project/end-to-end/ | ||||||
export FORCE_COLOR=1 | ||||||
../../scripts/earthly-ci -P --no-output +e2e-public-testnet \ | ||||||
--SEQ_PUBLISHER_PRIVATE_KEY=${{ secrets.SEPOLIA_SEQ_PRIVATE_KEY }} \ | ||||||
--PROVER_PUBLISHER_PRIVATE_KEY=${{ secrets.SEPOLIA_PROVER_PRIVATE_KEY }} \ | ||||||
--ETHEREUM_HOST="https://sepolia.infura.io/v3/${{ secrets.SEPOLIA_API_KEY }}" \ | ||||||
--L1_CHAIN_ID="11155111" | ||||||
|
||||||
# e2e: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reminder to delete commented-out code There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||||||
# needs: build | ||||||
# runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86 | ||||||
# strategy: | ||||||
# fail-fast: false | ||||||
# matrix: | ||||||
# test: ${{ fromJson( needs.build.outputs.e2e_list )}} | ||||||
# steps: | ||||||
# - uses: actions/checkout@v4 | ||||||
# with: { ref: "${{ env.GIT_COMMIT }}" } | ||||||
# - uses: ./.github/ci-setup-action | ||||||
# with: | ||||||
# # must be globally unique for build x runner | ||||||
# concurrency_key: public-testnet-x86 | ||||||
# - name: Setup and Test | ||||||
# timeout-minutes: 40 | ||||||
# uses: ./.github/ensure-tester-with-images | ||||||
# with: | ||||||
# #runner_type: "8core-tester-x86" | ||||||
# #builder_type: builder-x86 | ||||||
# # these are copied to the tester and expected by the earthly command below | ||||||
# # if they fail to copy, it will try to build them on the tester and fail | ||||||
# builder_images_to_copy: aztecprotocol/end-to-end:${{ env.GIT_COMMIT }} | ||||||
# # command to produce the images in case they don't exist | ||||||
# builder_command: scripts/earthly-ci ./yarn-project+export-e2e-test-images | ||||||
# run: | | ||||||
# set -eux | ||||||
# cd ./yarn-project/end-to-end/ | ||||||
# export FORCE_COLOR=1 | ||||||
# ../../scripts/earthly-ci -P --no-output +${{ matrix.test }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -226,6 +226,7 @@ | |
"schnorr", | ||
"secp", | ||
"SEMRESATTRS", | ||
"Sepolia", | ||
"sigchld", | ||
"Signerless", | ||
"siloes", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,9 +43,28 @@ | |
BUILD ../+export-end-to-end | ||
END | ||
END | ||
# Run our docker compose, ending whenever sandbox ends, filtering out noisy eth_getLogs | ||
RUN docker run -e HARDWARE_CONCURRENCY=$hardware_concurrency --rm aztecprotocol/end-to-end:$AZTEC_DOCKER_TAG $test || $allow_fail | ||
|
||
E2E_TEST_PUBLIC_TESTNET: | ||
FUNCTION | ||
Comment on lines
+48
to
+49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why extract this to a function if it's only called from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just followed the existing pattern really. I did wonder if we might add a couple more tests at which point it maybe makes sense. The way you have to pass those env vars through like that is really annoying. |
||
ARG hardware_concurrency="" | ||
ARG test | ||
ARG allow_fail=false | ||
ARG seq_private_key | ||
ARG prover_private_key | ||
ARG ethereum_host | ||
ARG l1_chain_id | ||
LOCALLY | ||
# Let docker compose know about the pushed tags above | ||
ENV AZTEC_DOCKER_TAG=$(git rev-parse HEAD) | ||
# Optimize to not cause serial behavior if image already exists | ||
IF ! docker image ls --format '{{.Repository}}:{{.Tag}}' | grep "aztecprotocol/end-to-end:$AZTEC_DOCKER_TAG" | ||
WAIT | ||
BUILD ../+export-end-to-end | ||
END | ||
END | ||
RUN docker run -e L1_CHAIN_ID=$l1_chain_id -e ETHEREUM_HOST=$ethereum_host -e SEQ_PUBLISHER_PRIVATE_KEY=$seq_private_key -e PROVER_PUBLISHER_PRIVATE_KEY=$prover_private_key -e HARDWARE_CONCURRENCY=$hardware_concurrency --rm aztecprotocol/end-to-end:$AZTEC_DOCKER_TAG $test || $allow_fail | ||
Check failure on line 66 in yarn-project/end-to-end/Earthfile GitHub Actions / e2e (e2e-public-testnet)Error
|
||
|
||
NETWORK_TEST: | ||
FUNCTION | ||
ARG hardware_concurrency="" | ||
|
@@ -223,7 +242,11 @@ | |
DO +E2E_TEST --test=./src/e2e_token_contract | ||
|
||
e2e-public-testnet: | ||
DO +E2E_TEST --test=./src/public-testnet | ||
ARG L1_CHAIN_ID | ||
ARG ETHEREUM_HOST | ||
ARG SEQ_PUBLISHER_PRIVATE_KEY | ||
ARG PROVER_PUBLISHER_PRIVATE_KEY | ||
DO +E2E_TEST_PUBLIC_TESTNET --test=./src/public-testnet --seq_private_key=${SEQ_PUBLISHER_PRIVATE_KEY:-} --prover_private_key=${PROVER_PUBLISHER_PRIVATE_KEY:-} --ethereum_host=${ETHEREUM_HOST:-} --l1_chain_id=${L1_CHAIN_ID:-} | ||
|
||
flakey-e2e-tests: | ||
DO +E2E_TEST --test=./src/flakey --allow_fail=true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.