refactor: Renaming around Protogalaxy Prover #8272

codygunton · 2024-08-29T15:38:36Z

This is literally just a ton of renaming + shuffling some declaration and defs in the Protogalaxy prover so the orders of these match. Some highlights:

I wanted to stop using the term "optimised" around the Pg optimization that skips computing zero because we have many optimizations and the name was unclear. I also put the extra qualifier on the non-production case where we don't use that optimization, which is currently just in tests of the combiner.
Ariel told me that the real name of the protocol is Protogalaxy--this is in the name of the paper in pdf form, but not on the eprint page 🤷
PowPolynomial is now a misnomer because it doesn't involve powers of a challenge $\beta$, but rather a bunch of monomials generate from a set of $\beta_i$'s. So I rename this and the corresponding files. I didn't have to change this but I do think clarity here comes at a low enough cost to merit making the change.
We have functions that refer to the "full honk" relation, which is fine, but strictly speaking there is no connection to Honk when using Protogalaxy or sumcheck in insolation, so it makes sense to give more agnostic and IMO slightly clearer names.

AztecBot · 2024-08-29T16:26:41Z

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,756	1,562	709 (-1%)	765 (+2%)	780 (+1%)
proof_construction_time_sha256_30_ms	11,458	3,080	1,380 (+1%)	1,430	1,467 (+1%)
proof_construction_time_sha256_100_ms	44,025	11,841	5,429	5,551 (-2%)	5,724 (-1%)
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	34.0	34.0	57.0 (-2%)	87.0
proof_construction_time_poseidon_hash_30_ms	1,526	422	203	228 (+4%)	272
proof_construction_time_poseidon_hash_100_ms	5,640	1,510	676	728	742 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,232	92,988	177,844
l1_rollup_execution_gas	845,566	1,579,218	3,364,130
l2_block_processing_time_in_ms	239 (-7%)	437 (-5%)	834 (+2%)
l2_block_building_time_in_ms	11,349	22,484	44,474
l2_block_rollup_simulation_time_in_ms	11,349	22,484	44,474
l2_block_public_tx_process_time_in_ms	9,671	20,772	42,739

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,931 (-3%)	3,805 (-7%)
node_database_size_in_bytes	12,578,896 (-1%)	16,699,472
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	93.0	380 (-3%)	21,735	44,860	N/A
private-kernel-inner	201 (+12%)	675	72,544	45,007	N/A
private-kernel-reset-tiny	310 (-1%)	689 (-3%)	65,593	44,846	N/A
private-kernel-tail	166	130 (-2%)	50,644	52,257	N/A
base-parity	5.56	N/A	160	96.0	N/A
root-parity	35.3 (+1%)	N/A	73,948	96.0	N/A
base-rollup	2,900 (-2%)	N/A	189,139	664	N/A
block-root-rollup	41.2	N/A	58,205	2,448	N/A
public-kernel-setup	85.1 (+1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	97.9	N/A	104,911	71,222	N/A
public-kernel-tail	861 (+1%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	308 (+1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	816 (+5%)	589	455,400	1,825	N/A
public-kernel-teardown	84.1 (+1%)	N/A	105,349	71,222	N/A
merge-rollup	20.4 (+1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	84,355 (+1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	344 (+1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1
MultiCallEntrypoint:entrypoint	1,920	11,731	404
FeeJuice:deploy	1,376	11,731	391 (+2%)
SchnorrAccount:constructor	1,312	11,731	72.7 (-2%)
SchnorrAccount:entrypoint	2,336	11,731	394
Token:privately_mint_private_note	1,280	11,731	104 (+4%)
FPC:fee_entrypoint_public	1,344	11,731	26.6 (+1%)
Token:transfer	1,312	11,731	223 (+1%)
Benchmarking:create_note	1,344	11,731	84.9 (-3%)
SchnorrAccount:verify_private_authwit	1,280	11,731	31.5 (+13%)
Token:unshield	1,376	11,731	524
FPC:fee_entrypoint_private	1,376	11,731	695

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	59.5 (+3%)	8,174
FeeJuice:set_portal	12.5 (+17%)	4,055
Token:constructor	95.3 (+14%)	29,082
FPC:constructor	57.2 (+4%)	18,940
FeeJuice:mint_public	40.1 (-3%)	6,522
Token:mint_public	311 (-1%)	12,704
Token:assert_minter_and_mint	43.0 (-7%)	8,467
AuthRegistry:set_authorized	48.2 (+22%)	4,194
FPC:prepare_fee	251 (+9%)	6,747
Token:transfer_public	38.7 (+25%)	39,863
FPC:pay_refund	56.4 (+8%)	9,398
Benchmarking:increment_balance	1,225	7,263
Token:_increase_public_balance	42.0 (+2%)	8,686
FPC:pay_refund_with_shielded_rebate	63.8 (+5%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.165 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.16 (-4%)	3.81 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112 (-4%)	0.107 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2 (+2%)	18.1	30.6 (-1%)	59.0 (-4%)	114 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.107 (+2%)	0.105	0.0993 (-1%)	0.101 (-3%)	0.102 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.6 (+1%)	25.7 (-1%)	43.2 (-1%)	82.8 (-4%)	163 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.111 (+1%)	0.103 (-1%)	0.105	0.102 (-3%)	0.102
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.6	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

codygunton · 2024-08-29T17:05:54Z

Looks like git didn't detect me moving pow.hpp

maramihali · 2024-08-30T14:29:30Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover_internal.hpp

-    static std::vector<FF> compute_full_honk_evaluations(const ProverPolynomials& instance_polynomials,
-                                                         const RelationSeparator& alpha,
-                                                         const RelationParameters<FF>& relation_parameters)
+    static std::vector<FF> compute_row_evaluations(const ProverPolynomials& instance_polynomials,


can you also change the docs accordingly please? :)

maramihali · 2024-08-30T14:32:37Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover.hpp

+    /**
+     * @brief Execute the folding prover.
+     *
+     * @todo TODO(https://github.com/AztecProtocol/barretenberg/issues/753): fold goblin polynomials


Remove this todo please

maramihali · 2024-08-30T14:35:33Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover.hpp

-    // Returns the accumulator, which is the first element in ProverInstances. The accumulator is assumed to have the
-    // FoldingParameters set and be the result of a previous round of folding.
-    std::shared_ptr<Instance> get_accumulator() { return instances[0]; }
+    void run_oink_prover_on_instance(std::shared_ptr<Instance>, const std::string& domain_separator);


it's fine if you don't want to do it in this PR but we also have an oink verifier (and recursive verifier I think) so they could be mirrored in the PG verifiers

Yeah I'm just focusing on the prover and then I'm going to do analogous refactoring to the verifiers.

I agree it's kinda ick but to me it feels much more efficient to work this way. Just need to make sure the verifier refactor also happens.

maramihali

Also LGTM mostly, left some small requests.

maramihali · 2024-08-30T14:37:53Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover_mega.cpp

@@ -5,5 +5,5 @@
 #include "protogalaxy_prover_impl.hpp"
 namespace bb {

-template class ProtoGalaxyProver_<ProverInstances_<MegaFlavor, 2>>;
+template class ProtogalaxyProver_<ProverInstances_<MegaFlavor, 2>>;


I didnt actually ask, maybe you know, why did we move all the PG logic in header files?

I think Adam did this when he was cleaning up how we did instantiation.

maramihali · 2024-08-30T14:44:25Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover.hpp

+    // Returns the accumulator, which is the first element in ProverInstances. The accumulator is assumed to have the
+    // FoldingParameters set and be the result of a previous round of folding.
+    std::shared_ptr<Instance> get_accumulator() { return instances[0]; }
+
    /**
     * @brief For each instance produced by a circuit, prior to folding, we need to complete the computation of its


we kinda have the same documentation for both run_oink_prover_on_instance and run_oink_prover_on_each_instance so these could be refined. I also I'm quite meh about the function names but cant come up with sth better than run_oink_on_all_instances and run_oink_on_instance. To me I think mentioning prover is unnecessary because we are in a prover so we won't call oink_verifier but up to you,

maramihali · 2024-08-30T14:47:04Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_verifier.cpp

@@ -6,15 +6,15 @@
 namespace bb {

 template <class VerifierInstances>
-void ProtoGalaxyVerifier_<VerifierInstances>::receive_and_finalise_instance(const std::shared_ptr<Instance>& inst,
+void ProtogalaxyVerifier_<VerifierInstances>::receive_and_finalise_instance(const std::shared_ptr<Instance>& inst,


As mentioned in the prover, either rename these as well in this PR or add an issue please.

maramihali · 2024-08-30T14:51:01Z

...etenberg/cpp/src/barretenberg/stdlib/protogalaxy_verifier/protogalaxy_recursive_verifier.cpp

@@ -5,7 +5,7 @@
 namespace bb::stdlib::recursion::honk {

 template <class VerifierInstances>
-void ProtoGalaxyRecursiveVerifier_<VerifierInstances>::receive_and_finalise_instance(
+void ProtogalaxyRecursiveVerifier_<VerifierInstances>::receive_and_finalise_instance(


same here about changing names to reflect those in the prover

maramihali · 2024-08-30T14:52:46Z

barretenberg/cpp/src/barretenberg/sumcheck/sumcheck.hpp

@@ -211,7 +211,7 @@ template <typename Flavor> class SumcheckProver {
            setup_zk_sumcheck_data(zk_sumcheck_data);
        };

-        bb::PowPolynomial<FF> pow_univariate(gate_challenges, multivariate_d);
+        bb::GateSeparatorPolynomial<FF> gate_separators(gate_challenges, multivariate_d);


i would still preserve the univariate in the variable name for clarity but up to you

I thought it was confusing because it's not actually an instance of a Univariate class!

maramihali · 2024-08-30T14:54:34Z

barretenberg/cpp/src/barretenberg/sumcheck/sumcheck_round.hpp

@@ -518,15 +519,15 @@ template <typename Flavor> class SumcheckVerifierRound {
    // also copy paste in PG


would you delete these 3 lines of stale comments oks, it's probably leftovers of me talking to myself ;)

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.52.0</summary> ## [0.52.0](aztec-package-v0.51.1...aztec-package-v0.52.0) (2024-09-01) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.52.0</summary> ## [0.52.0](barretenberg.js-v0.51.1...barretenberg.js-v0.52.0) (2024-09-01) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.52.0</summary> ## [0.52.0](aztec-packages-v0.51.1...aztec-packages-v0.52.0) (2024-09-01) ### ⚠ BREAKING CHANGES * Check unused generics are bound (noir-lang/noir#5840) ### Features * Add `Expr::as_assert` (noir-lang/noir#5857) ([cf5b667](cf5b667)) * Add `Expr::resolve` and `TypedExpr::as_function_definition` (noir-lang/noir#5859) ([cf5b667](cf5b667)) * Add `FunctionDef::body` (noir-lang/noir#5825) ([cf5b667](cf5b667)) * Add `FunctionDef::has_named_attribute` (noir-lang/noir#5870) ([cf5b667](cf5b667)) * Add `Type::as_string` (noir-lang/noir#5871) ([cf5b667](cf5b667)) * Clarify state in Protogalaxy 3 ([#8181](#8181)) ([4a9bb9d](4a9bb9d)) * LSP signature help for assert and assert_eq (noir-lang/noir#5862) ([cf5b667](cf5b667)) * **meta:** Comptime keccak (noir-lang/noir#5854) ([cf5b667](cf5b667)) * **optimization:** Avoid merging identical (by ID) arrays (noir-lang/noir#5853) ([cf5b667](cf5b667)) * **perf:** Simplify poseidon2 cache zero-pad (noir-lang/noir#5869) ([cf5b667](cf5b667)) * Populate epoch 0 from initial validator set ([#8286](#8286)) ([cbdec54](cbdec54)) * Remove unnecessary copying of vector size during reversal (noir-lang/noir#5852) ([cf5b667](cf5b667)) * Removing `is_dev_net` flag ([#8275](#8275)) ([fc1f307](fc1f307)) * Show backtrace on comptime assertion failures (noir-lang/noir#5842) ([cf5b667](cf5b667)) * Simplify constant calls to `poseidon2_permutation`, `schnorr_verify` and `embedded_curve_add` (noir-lang/noir#5140) ([cf5b667](cf5b667)) * Sync from aztec-packages (noir-lang/noir#5790) ([cf5b667](cf5b667)) * Warn on unused imports (noir-lang/noir#5847) ([cf5b667](cf5b667)) ### Bug Fixes * Check unused generics are bound (noir-lang/noir#5840) ([cf5b667](cf5b667)) * Enforce parity of sequencer tx validation and node tx validation ([#7951](#7951)) ([c7eaf92](c7eaf92)) * Make simulations validate resulting tx by default ([#8157](#8157)) ([f5e388d](f5e388d)) * **nargo:** Resolve Brillig assertion payloads (noir-lang/noir#5872) ([cf5b667](cf5b667)) * Prevent honk proof from getting stale inputs on syncs ([#8293](#8293)) ([2598108](2598108)) * Remove fee juice mint public ([#8260](#8260)) ([2395af3](2395af3)) * **sha256:** Add extra checks against message size when constructing msg blocks (noir-lang/noir#5861) ([cf5b667](cf5b667)) * **sha256:** Fix upper bound when building msg block and delay final block compression under certain cases (noir-lang/noir#5838) ([cf5b667](cf5b667)) * **sha256:** Perform compression per block and utilize ROM instead of RAM when setting up the message block (noir-lang/noir#5760) ([cf5b667](cf5b667)) ### Miscellaneous * Add documentation to `to_be_bytes`, etc. (noir-lang/noir#5843) ([cf5b667](cf5b667)) * Add missing cases to arithmetic generics (noir-lang/noir#5841) ([cf5b667](cf5b667)) * Add test to reproduce [#8306](#8306) ([41d418c](41d418c)) * Alert slack on Sepolia test ([#8263](#8263)) ([6194b94](6194b94)) * **bb:** Make compile on stock mac clang ([#8278](#8278)) ([7af80ff](7af80ff)) * **bb:** More graceful pippenger on non-powers-of-2 ([#8279](#8279)) ([104ea85](104ea85)) * Bump noir-bignum to 0.3.2 ([#8276](#8276)) ([4c6fe1a](4c6fe1a)) * **ci:** Try to debug 'command brotli not found' ([#8305](#8305)) ([9ee8dd6](9ee8dd6)) * Don't require empty `Prover.toml` for programs with zero arguments but a return value (noir-lang/noir#5845) ([cf5b667](cf5b667)) * Fix a bunch of generics issues in aztec-nr ([#8295](#8295)) ([6e84970](6e84970)) * Fix more issues with generics ([#8302](#8302)) ([4e2ce80](4e2ce80)) * Fix warnings in `avm-transpiler` ([#8307](#8307)) ([359fe05](359fe05)) * Introduce the Visitor pattern (noir-lang/noir#5868) ([cf5b667](cf5b667)) * **perf:** Simplify poseidon2 algorithm (noir-lang/noir#5811) ([cf5b667](cf5b667)) * **perf:** Update to stdlib keccak for reduced Brillig code size (noir-lang/noir#5827) ([cf5b667](cf5b667)) * Redo typo PR by nnsW3 (noir-lang/noir#5834) ([cf5b667](cf5b667)) * Renaming around Protogalaxy Prover ([#8272](#8272)) ([be2169d](be2169d)) * Replace relative paths to noir-protocol-circuits ([56e3fbf](56e3fbf)) * Replace relative paths to noir-protocol-circuits ([1b245c4](1b245c4)) * Replace relative paths to noir-protocol-circuits ([9c3bc43](9c3bc43)) * **revert:** Earthfile accidental change ([#8309](#8309)) ([2d3e0b6](2d3e0b6)) * Underconstrained check in parallel (noir-lang/noir#5848) ([cf5b667](cf5b667)) ### Documentation * **bb:** Transcript spec ([#8301](#8301)) ([18abf37](18abf37)) </details> <details><summary>barretenberg: 0.52.0</summary> ## [0.52.0](barretenberg-v0.51.1...barretenberg-v0.52.0) (2024-09-01) ### Features * Clarify state in Protogalaxy 3 ([#8181](#8181)) ([4a9bb9d](4a9bb9d)) ### Bug Fixes * Prevent honk proof from getting stale inputs on syncs ([#8293](#8293)) ([2598108](2598108)) ### Miscellaneous * **bb:** Make compile on stock mac clang ([#8278](#8278)) ([7af80ff](7af80ff)) * **bb:** More graceful pippenger on non-powers-of-2 ([#8279](#8279)) ([104ea85](104ea85)) * Renaming around Protogalaxy Prover ([#8272](#8272)) ([be2169d](be2169d)) * **revert:** Earthfile accidental change ([#8309](#8309)) ([2d3e0b6](2d3e0b6)) ### Documentation * **bb:** Transcript spec ([#8301](#8301)) ([18abf37](18abf37)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.52.0</summary> ## [0.52.0](AztecProtocol/aztec-packages@aztec-package-v0.51.1...aztec-package-v0.52.0) (2024-09-01) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.52.0</summary> ## [0.52.0](AztecProtocol/aztec-packages@barretenberg.js-v0.51.1...barretenberg.js-v0.52.0) (2024-09-01) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.52.0</summary> ## [0.52.0](AztecProtocol/aztec-packages@aztec-packages-v0.51.1...aztec-packages-v0.52.0) (2024-09-01) ### ⚠ BREAKING CHANGES * Check unused generics are bound (noir-lang/noir#5840) ### Features * Add `Expr::as_assert` (noir-lang/noir#5857) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add `Expr::resolve` and `TypedExpr::as_function_definition` (noir-lang/noir#5859) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add `FunctionDef::body` (noir-lang/noir#5825) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add `FunctionDef::has_named_attribute` (noir-lang/noir#5870) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add `Type::as_string` (noir-lang/noir#5871) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Clarify state in Protogalaxy 3 ([#8181](AztecProtocol/aztec-packages#8181)) ([4a9bb9d](AztecProtocol/aztec-packages@4a9bb9d)) * LSP signature help for assert and assert_eq (noir-lang/noir#5862) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **meta:** Comptime keccak (noir-lang/noir#5854) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **optimization:** Avoid merging identical (by ID) arrays (noir-lang/noir#5853) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **perf:** Simplify poseidon2 cache zero-pad (noir-lang/noir#5869) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Populate epoch 0 from initial validator set ([#8286](AztecProtocol/aztec-packages#8286)) ([cbdec54](AztecProtocol/aztec-packages@cbdec54)) * Remove unnecessary copying of vector size during reversal (noir-lang/noir#5852) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Removing `is_dev_net` flag ([#8275](AztecProtocol/aztec-packages#8275)) ([fc1f307](AztecProtocol/aztec-packages@fc1f307)) * Show backtrace on comptime assertion failures (noir-lang/noir#5842) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Simplify constant calls to `poseidon2_permutation`, `schnorr_verify` and `embedded_curve_add` (noir-lang/noir#5140) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Sync from aztec-packages (noir-lang/noir#5790) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Warn on unused imports (noir-lang/noir#5847) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) ### Bug Fixes * Check unused generics are bound (noir-lang/noir#5840) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Enforce parity of sequencer tx validation and node tx validation ([#7951](AztecProtocol/aztec-packages#7951)) ([c7eaf92](AztecProtocol/aztec-packages@c7eaf92)) * Make simulations validate resulting tx by default ([#8157](AztecProtocol/aztec-packages#8157)) ([f5e388d](AztecProtocol/aztec-packages@f5e388d)) * **nargo:** Resolve Brillig assertion payloads (noir-lang/noir#5872) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Prevent honk proof from getting stale inputs on syncs ([#8293](AztecProtocol/aztec-packages#8293)) ([2598108](AztecProtocol/aztec-packages@2598108)) * Remove fee juice mint public ([#8260](AztecProtocol/aztec-packages#8260)) ([2395af3](AztecProtocol/aztec-packages@2395af3)) * **sha256:** Add extra checks against message size when constructing msg blocks (noir-lang/noir#5861) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **sha256:** Fix upper bound when building msg block and delay final block compression under certain cases (noir-lang/noir#5838) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **sha256:** Perform compression per block and utilize ROM instead of RAM when setting up the message block (noir-lang/noir#5760) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) ### Miscellaneous * Add documentation to `to_be_bytes`, etc. (noir-lang/noir#5843) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add missing cases to arithmetic generics (noir-lang/noir#5841) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add test to reproduce [#8306](AztecProtocol/aztec-packages#8306) ([41d418c](AztecProtocol/aztec-packages@41d418c)) * Alert slack on Sepolia test ([#8263](AztecProtocol/aztec-packages#8263)) ([6194b94](AztecProtocol/aztec-packages@6194b94)) * **bb:** Make compile on stock mac clang ([#8278](AztecProtocol/aztec-packages#8278)) ([7af80ff](AztecProtocol/aztec-packages@7af80ff)) * **bb:** More graceful pippenger on non-powers-of-2 ([#8279](AztecProtocol/aztec-packages#8279)) ([104ea85](AztecProtocol/aztec-packages@104ea85)) * Bump noir-bignum to 0.3.2 ([#8276](AztecProtocol/aztec-packages#8276)) ([4c6fe1a](AztecProtocol/aztec-packages@4c6fe1a)) * **ci:** Try to debug 'command brotli not found' ([#8305](AztecProtocol/aztec-packages#8305)) ([9ee8dd6](AztecProtocol/aztec-packages@9ee8dd6)) * Don't require empty `Prover.toml` for programs with zero arguments but a return value (noir-lang/noir#5845) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Fix a bunch of generics issues in aztec-nr ([#8295](AztecProtocol/aztec-packages#8295)) ([6e84970](AztecProtocol/aztec-packages@6e84970)) * Fix more issues with generics ([#8302](AztecProtocol/aztec-packages#8302)) ([4e2ce80](AztecProtocol/aztec-packages@4e2ce80)) * Fix warnings in `avm-transpiler` ([#8307](AztecProtocol/aztec-packages#8307)) ([359fe05](AztecProtocol/aztec-packages@359fe05)) * Introduce the Visitor pattern (noir-lang/noir#5868) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **perf:** Simplify poseidon2 algorithm (noir-lang/noir#5811) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **perf:** Update to stdlib keccak for reduced Brillig code size (noir-lang/noir#5827) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Redo typo PR by nnsW3 (noir-lang/noir#5834) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Renaming around Protogalaxy Prover ([#8272](AztecProtocol/aztec-packages#8272)) ([be2169d](AztecProtocol/aztec-packages@be2169d)) * Replace relative paths to noir-protocol-circuits ([56e3fbf](AztecProtocol/aztec-packages@56e3fbf)) * Replace relative paths to noir-protocol-circuits ([1b245c4](AztecProtocol/aztec-packages@1b245c4)) * Replace relative paths to noir-protocol-circuits ([9c3bc43](AztecProtocol/aztec-packages@9c3bc43)) * **revert:** Earthfile accidental change ([#8309](AztecProtocol/aztec-packages#8309)) ([2d3e0b6](AztecProtocol/aztec-packages@2d3e0b6)) * Underconstrained check in parallel (noir-lang/noir#5848) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) ### Documentation * **bb:** Transcript spec ([#8301](AztecProtocol/aztec-packages#8301)) ([18abf37](AztecProtocol/aztec-packages@18abf37)) </details> <details><summary>barretenberg: 0.52.0</summary> ## [0.52.0](AztecProtocol/aztec-packages@barretenberg-v0.51.1...barretenberg-v0.52.0) (2024-09-01) ### Features * Clarify state in Protogalaxy 3 ([#8181](AztecProtocol/aztec-packages#8181)) ([4a9bb9d](AztecProtocol/aztec-packages@4a9bb9d)) ### Bug Fixes * Prevent honk proof from getting stale inputs on syncs ([#8293](AztecProtocol/aztec-packages#8293)) ([2598108](AztecProtocol/aztec-packages@2598108)) ### Miscellaneous * **bb:** Make compile on stock mac clang ([#8278](AztecProtocol/aztec-packages#8278)) ([7af80ff](AztecProtocol/aztec-packages@7af80ff)) * **bb:** More graceful pippenger on non-powers-of-2 ([#8279](AztecProtocol/aztec-packages#8279)) ([104ea85](AztecProtocol/aztec-packages@104ea85)) * Renaming around Protogalaxy Prover ([#8272](AztecProtocol/aztec-packages#8272)) ([be2169d](AztecProtocol/aztec-packages@be2169d)) * **revert:** Earthfile accidental change ([#8309](AztecProtocol/aztec-packages#8309)) ([2d3e0b6](AztecProtocol/aztec-packages@2d3e0b6)) ### Documentation * **bb:** Transcript spec ([#8301](AztecProtocol/aztec-packages#8301)) ([18abf37](AztecProtocol/aztec-packages@18abf37)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

codygunton added 23 commits August 26, 2024 20:02

Add notes to state

14c560d

Rename compressed_perturbator

80e27c6

Outline IO of rounds

fbd4872

Link rounds to Pg interation steps.

6dd760e

Remove pass-through round and rename rounds

72ac9d6

Perturbator round is a pure function

5297848

Combiner quotient round is a pure function

61c0df0

Big refactor of final round, incl brittle folding loops

c49abd8

Delete accumulators from state

64ed816

Remove non-optimised parameters from state

2aa89d1

No Prover in combiner test

a6d0b08

Move gate challenges out of state

301522a

Merge remote-tracking branch 'origin/master' into cg/pg-state-3

acea7b4

Final TODO is bigger

49efd45

Rename optimised, combined

c55dea3

Parameters are const

4d943c7

Use const more

c11a029

Rename PgTupOfUnivOberSubs

96085fa

Rename some OptimisedTupleOf...

7f5f052

Rename base method

84b1b81

Rename OptimisedProverUnivariates

41fdcb8

Rename PgTupleOfTuples

a18212c

Rename ExtendedUnivs

de21eaf

codygunton self-assigned this Aug 29, 2024

codygunton changed the base branch from master to cg/pg-state-3 August 29, 2024 15:39

codygunton mentioned this pull request Aug 29, 2024

feat: Clarify state in Protogalaxy 3 #8181

Merged

codygunton added 3 commits August 29, 2024 15:51

Change var names to reflect new types

0993f48

Ariel said this is the real name and I like it better

5648884

PowPolynomial is a misnomer

54349b3

codygunton marked this pull request as ready for review August 29, 2024 17:01

codygunton requested review from jeanmon, IlyasRidhuan, fcarreiro and Maddiaa0 as code owners August 29, 2024 17:01

Remove stray pow.hpp

89b39f3

codygunton added 3 commits August 29, 2024 14:55

Merge branch 'master' into cg/pg-state-3

092c82a

Rename finalize_and_send more literally

5a08889

Rearrange so header and impl match order

01e4e81

maramihali reviewed Aug 30, 2024

View reviewed changes

maramihali approved these changes Aug 30, 2024

View reviewed changes

codygunton added 4 commits August 30, 2024 18:44

Add comment

c0a0c26

Don't use LegacyPolynomial

b1fc7cd

Merge branch 'cg/pg-state-3' into cg/pg-state-4

185493f

Respond to review

a73b55b

Base automatically changed from cg/pg-state-3 to master August 30, 2024 19:54

codygunton added 2 commits August 30, 2024 20:04

Fix broken merge

882b4c4

Merge remote-tracking branch 'origin/master' into cg/pg-state-4

a4c903f

codygunton force-pushed the cg/pg-state-4 branch 2 times, most recently from eb0c7be to a4c903f Compare August 30, 2024 20:27

codygunton enabled auto-merge (squash) August 30, 2024 20:36

codygunton merged commit be2169d into master Aug 30, 2024
100 checks passed

codygunton deleted the cg/pg-state-4 branch August 30, 2024 21:14

AztecBot mentioned this pull request Aug 30, 2024

chore(master): Release 0.52.0 #8289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Renaming around Protogalaxy Prover #8272

refactor: Renaming around Protogalaxy Prover #8272

codygunton commented Aug 29, 2024 •

edited

Loading

AztecBot commented Aug 29, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

codygunton commented Aug 29, 2024

maramihali Aug 30, 2024

maramihali Aug 30, 2024

maramihali Aug 30, 2024

codygunton Aug 30, 2024

codygunton Aug 30, 2024

maramihali left a comment

maramihali Aug 30, 2024

codygunton Aug 30, 2024

maramihali Aug 30, 2024

maramihali Aug 30, 2024

maramihali Aug 30, 2024

maramihali Aug 30, 2024

codygunton Aug 30, 2024

maramihali Aug 30, 2024

		@@ -518,15 +519,15 @@ template <typename Flavor> class SumcheckVerifierRound {
		// also copy paste in PG

refactor: Renaming around Protogalaxy Prover #8272

refactor: Renaming around Protogalaxy Prover #8272

Conversation

codygunton commented Aug 29, 2024 • edited Loading

AztecBot commented Aug 29, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

codygunton commented Aug 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maramihali left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codygunton commented Aug 29, 2024 •

edited

Loading

AztecBot commented Aug 29, 2024 •

edited

Loading