Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): getting started, portals page, some other nits #8515
feat(docs): getting started, portals page, some other nits #8515
Changes from 12 commits
5d89867
7658d12
12b8d13
4dfaed4
96241a9
ee49be9
f18d93a
7f28cda
f932acb
3eb8b76
67a93b3
5ae2ad8
f112008
94a4983
043f376
d7d2c62
46b49b4
1b74430
0227861
117cb8f
2d387c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove one page by putting the content of
cross_chain_calls
inside this one, and make the the## Private / Public execution
as an admonition block like:::tip
at the top or bottom?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We kind of need this page as it we're throwing "PXE" everywhere without properly saying what it is. Wondering if there's anything in the reference we could move here?
Thinking the PXE deserves its own explainer though. Maybe we could just produce more content around it, given its function will likely not change so I guess it wouldn't incur in big maintenance cost
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create a bash script that runs these commands as part of CI, then references the commands using
#include_code
, to ensure that we catch if (when) they break?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the tutorials test framework I have lying around, waiting for that promised day of a more motivated version of me to pick it up again...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should use
aztec-wallet
, I'm surprisedaztec deploy
oraztec send
are still commands even...It's very confusing because we have two ways of doing stuff even though
aztec-wallet
is the one we want devs to useThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can pass the
-a
flag to make it an alias like:And then just reference this account like
accounts:my_account
. This is the correct way of doing as it already takes care of all the required fields for any subsequent command, and avoids having toexport
stuff.I think the
CLI
wallet tutorial could help with this. @Thunkar is the mastermind behind aliasesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we're not really using the CLI wallet here? It would be something like
aztec-wallet deploy --from accounts:my_wallet
etc (see the amazing alias there)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, the
aztec-wallet
is pretty useful, would could either pass-a contracts:token_contract
and then use it like that, or just do nothing and it will auto alias the contract aslast
so you can pass justlast
orcontracts:last
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(an example)
(see the
last
being passed here? the CLI knows what type it expects for-ca
so it will just resolve the contract aliased aslast
with typecontracts
)