-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniswap: L2 to L1 to L2 #873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-kothari
force-pushed
the
rk/uniswap_l1l2
branch
5 times, most recently
from
June 19, 2023 15:37
57e0983
to
b92a4e5
Compare
rahul-kothari
force-pushed
the
rk/uniswap_l1l2
branch
3 times, most recently
from
June 19, 2023 16:37
5e7c6cf
to
ab0ca0c
Compare
LHerskind
reviewed
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some nits, otherwise good. If you create the extra issue for cancellations on uniswap portal
yarn-project/end-to-end/src/uniswap_trade_on_l1_from_l2.test.ts
Outdated
Show resolved
Hide resolved
yarn-project/end-to-end/src/uniswap_trade_on_l1_from_l2.test.ts
Outdated
Show resolved
Hide resolved
yarn-project/end-to-end/src/uniswap_trade_on_l1_from_l2.test.ts
Outdated
Show resolved
Hide resolved
rahul-kothari
force-pushed
the
rk/uniswap_l1l2
branch
3 times, most recently
from
June 20, 2023 13:55
9d6898a
to
e98d14b
Compare
rahul-kothari
force-pushed
the
rk/uniswap_l1l2
branch
from
June 20, 2023 15:37
e98d14b
to
d48c9a6
Compare
Co-authored-by: Lasse Herskind <LHerskind@users.noreply.github.com> Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
rahul-kothari
force-pushed
the
rk/uniswap_l1l2
branch
3 times, most recently
from
June 20, 2023 16:25
79fd692
to
c6b5712
Compare
rahul-kothari
force-pushed
the
rk/uniswap_l1l2
branch
from
June 20, 2023 17:22
c6b5712
to
a79017f
Compare
LHerskind
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Y'all personal aztec connect is here!!
Close #875 (builds on #843)
Goal -> Deposit WETH into L2 and then swap to DAI using L1 Uniswap i.e.
Some things were updated to make it all work:
MAX_ARGS
in a noir function to 16!lastProcessedBlockNumber
toconfig.searchStartBlock
- this ensures that we skip processing blocks based on what the config wants! Useful when forking mainnet (like we have to) and only process blocks from current block.swap()
message.swap()
message request from L2, execute the swap and then push the swapped asset (here WETH) to its portal so it can be minted on LChecklist: