Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pad epochs with empty blocks #8842

Closed
wants to merge 6 commits into from

Conversation

spalladino
Copy link
Collaborator

@spalladino spalladino commented Sep 26, 2024

Root rollup cannot handle a single child, so this PR uses the empty block root circuit to pad the epoch in the orhcestrator.

Builds on #8794.

@spalladino spalladino added the e2e-all CI: Enables this CI job. label Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Changes to circuit sizes

Generated at commit: 59d1c0b6c0ed20cf6689722d8b3b377cf679c218, compared to commit: cc30220d1beec1620f6443601f395c8d33fa640d

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root +70 ❌ +0.37% +126 ❌ +0.00%
rollup_block_merge +70 ❌ +0.37% +126 ❌ +0.00%
parity_root 0 ➖ 0.00% +112 ❌ +0.00%
rollup_block_root 0 ➖ 0.00% +84 ❌ +0.00%
rollup_block_root_final 0 ➖ 0.00% +84 ❌ +0.00%
rollup_merge 0 ➖ 0.00% +56 ❌ +0.00%
public_kernel_merge 0 ➖ 0.00% +28 ❌ +0.00%
public_kernel_tail 0 ➖ 0.00% +28 ❌ +0.00%
rollup_base 0 ➖ 0.00% +28 ❌ +0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root 18,844 (+70) +0.37% 2,787,661 (+126) +0.00%
rollup_block_merge 18,860 (+70) +0.37% 2,787,693 (+126) +0.00%
parity_root 2,114 (0) 0.00% 5,486,736 (+112) +0.00%
rollup_block_root 1,966 (0) 0.00% 4,121,162 (+84) +0.00%
rollup_block_root_final 1,966 (0) 0.00% 4,121,162 (+84) +0.00%
rollup_merge 1,483 (0) 0.00% 2,751,436 (+56) +0.00%
public_kernel_merge 53,488 (0) 0.00% 1,535,245 (+28) +0.00%
public_kernel_tail 259,172 (0) 0.00% 2,699,168 (+28) +0.00%
rollup_base 423,026 (0) 0.00% 3,734,646 (+28) +0.00%

@spalladino spalladino force-pushed the palla/prover-node-epochs branch from cc30220 to 7a11c7b Compare September 27, 2024 01:06
Root rollup cannot handle a single child, so this PR uses the empty
block root circuit to pad the epoch in the orhcestrator.
@spalladino spalladino force-pushed the palla/prover-node-epochs branch from 7a11c7b to 5519759 Compare September 27, 2024 12:52
@spalladino
Copy link
Collaborator Author

Manually rebased on top of #8794 to have a single CI run for both

@spalladino spalladino closed this Sep 27, 2024
@spalladino spalladino deleted the palla/pad-epoch branch September 27, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants